From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9305442B10 for ; Tue, 25 Aug 2026 15:58:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787673513; cv=none; b=isFrzBtBwJUu99a5LhnG0cx/VfKa4rExTKmJjhoAxLQL785iJLCZaYS3X3Z3yKKuBMlNiEPAjWlhY7OjaL8yQ2I2cPEt8Z3vvPn43KLZs0N4oF3d6PQ2DFglIY3hgReFTtY4IrJgAA8HiJM+DrIS2QGgg31Vp+S1HCe99T7P1VM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787673513; c=relaxed/simple; bh=6fYdnRk6pjxrSAxMwAMTe/HvBW3p3tPhqo9+iE/1eec=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L/DctMniNd3+hj9yuCKcN01k7F/IIwQ5H6ySY4fW9nCBBT9sZxIgrBPWWVl27L7Pw+O5nxYMwZR3/2UJtXtC5KmjVrf94oqbqlz4RKzLuGC3rSnzSDZB0+2JJgymrFZjd4gfX6k1u918TAPvaM3xVEcr3CCsJO2wiTT/oWl0UU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=c2he3xVX; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gROz/wtF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="c2he3xVX"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gROz/wtF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787673510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zw8rgTkqg/RMXzjbEGS0cAS0wOEwqckgtTyrqfWP7Hc=; b=c2he3xVXIDvIlSvS1ysNqij7f6EfiG6t9GJItyYbkjQV9ZXqm995T81Jw2uGoqRUcKA+Mg FwHZ0hDEuAm70p88MGkK7SfvgE4EdYSpqmRyLsobc12/93gA1Qwo1hFDnv6/+ST+griI1R kKyskUNSBFRFtRq1ZiviJFym3NtxKok= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-1hXjFAvzNl-jSipVyViSKw-1; Tue, 25 Aug 2026 11:58:28 -0400 X-MC-Unique: 1hXjFAvzNl-jSipVyViSKw-1 X-Mimecast-MFC-AGG-ID: 1hXjFAvzNl-jSipVyViSKw_1787673508 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8f1e4e0eac1so26869646d6.1 for ; Tue, 25 Aug 2026 08:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787673508; x=1788278308; darn=vger.kernel.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zw8rgTkqg/RMXzjbEGS0cAS0wOEwqckgtTyrqfWP7Hc=; b=gROz/wtFHyFHm7b1Xh61kdHuGftMMumJHsK9fR25bIBWs4rbNbz0szWvAqpLzwiGPj M4H4KMy+YTIS2fXIx7esRrwnwAxHivJYp5ZUlnPOePEg+bqF/OxfRwc+4QDH52zNCCIr aUh7j3DIbC2hP1DFNWIl+z3dF45mpDIxxybgaY5VfdI2cYlNktn/VltyoB3b2CBounLi BaG66ytaML9TSDJf1tYssG8tDdBt6+eNs99c3A9EReLPYrz7W7OG3s0AS2ZI5rXFWEAE MxUHYE25RzqvhNvoO6JI7Kht6gtqDvi8MgCnxZ2vckM+PXanwajWjbvOTN8MOnQGfOR4 OhyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787673508; x=1788278308; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=zw8rgTkqg/RMXzjbEGS0cAS0wOEwqckgtTyrqfWP7Hc=; b=J3+o2hFXZvnlTrQMf/liZiJ5mY/DZaAUwZH/8o+qx59XzBjdA9tLoOHicwROYDe7PP Lnfq1v29OklpIPPhr7em3wkPCHq7XU8XVHMitQsaqnFJHaq2er3TeLERbt+q2B1mae5e 6AZQcLue85ow93S58RuyQvXsm9P/YPaCKvi7q4NQlalPorBicpVJLpv+WgJl0l5yB/3x RBETzDyXGU3KoND85Rkc2xHXhuFUmZ+tNcURQyoXAgJmzpDVlmWkNXN3WzpLISnNDySm +znPXaCQlN9YCHlEBzKM8rawE7E3TEmxVndFDe3cTrnowwEB2oFq4xWH1Bx3MYUd6Sj4 RhsQ== X-Forwarded-Encrypted: i=1; AHgh+Rp45q2ZkoBNRJTGtyi9sWeH0tL/NQMroJRjT7b8jduqnOaoTuE+2IcaCoEXgjoLYJDgcXaMstymldXJAYQ=@vger.kernel.org X-Gm-Message-State: AFuF++l3RWK1giFYvdTsNft3dWopSYuCfQes209apahOr1+4/jH0vmPA OyEDu4dvMOI/VlFK6Vq7+JWMGmg0UYL+6TvH6rH9fyYFaMksgMUT5DYs/sPu5J8qL1ID+kPbCxH Z5S0PVfZ4Guea32BF/tQnGd25CdCTcCMxawYgHF7hLa/gDM/HW8+EzzsrxIqbFOapuQ== X-Gm-Gg: AR+sD13u42AVeTy4OTgiLSeJXK9rPVMqBsUVZ/tavshFZkgj/hapzDtjMvCzhnI9e9M JLHeQ/PBNMgZRfek1gMP3PFaU8xeBf6CHNmO6OZADoq/KZcLhsM/MEG6l91q80rBGxbyunYDjzT TZZdAOZYhcjN1uPZJySFahcwRA/J/4WYRfbeNnR/VRXJu6n92IVZBLqVg3ck4uKxRR+tvDgsCsF MD1+/fKephPK4owrwWu8yJQ204vw/5cFi3m1i7gqXGoNO0r7CNmMl7wwIuj9T0KAAJwpeMc+WHx OU9jbxq0B8ATIGnNeLI+NTBapFq04wJma3+m0jsGhMSyrbZhwcoqV7pT4L2hGNzRiVEA6zBCTLV yYMWLBUfoElBhY+Dy39tviiX72wrIP+X8ANI= X-Received: by 2002:ad4:5aed:0:b0:90c:6936:b508 with SMTP id 6a1803df08f44-90c807b2784mr342748266d6.0.1787673507497; Tue, 25 Aug 2026 08:58:27 -0700 (PDT) X-Received: by 2002:ad4:5aed:0:b0:90c:6936:b508 with SMTP id 6a1803df08f44-90c807b2784mr342747526d6.0.1787673506916; Tue, 25 Aug 2026 08:58:26 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90cc64216c6sm1915416d6.22.2026.08.25.08.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 08:58:26 -0700 (PDT) Date: Tue, 25 Aug 2026 11:58:25 -0400 From: Brian Masney To: Yang Zi <2959243019@qq.com> Cc: sboyd@kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: si5341: Fix NULL pointer dereference in probe Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) Hi Yang, On Tue, Aug 25, 2026 at 04:59:56PM +0800, Yang Zi wrote: > si5341_probe() dereferences client->dev.of_node->name without first > checking that a device tree node is present. When the device is > instantiated without DT, e.g. via sysfs "new_device", client->dev.of_node > is NULL and probe crashes with a NULL pointer dereference. > > Add an early check and return -ENODEV when no of_node is available, since > this driver requires device tree bindings. > > Signed-off-by: Yang Zi <2959243019@qq.com> This patch doesn't apply against linux-next. Otherwise the change looks fine to me. Brian > --- >  drivers/clk/clk-si5341.c | 3 +++ >  1 file changed, 3 insertions(+) > > diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c > index 2499b771cd83..9d901c2fd0df 100644 > --- a/drivers/clk/clk-si5341.c > +++ b/drivers/clk/clk-si5341.c > @@ -1567,6 +1567,9 @@ static int si5341_probe(struct i2c_client *client) >      bool initialization_required; >      u32 status; >   > +    if (!client->dev.of_node) > +        return -ENODEV; > + >      data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL); >      if (!data) >          return -ENOMEM; > >