From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Jan Polensky <japo@linux.ibm.com>,
ltp@lists.linux.it, Namjae Jeon <linkinjeon@kernel.org>,
linux-kernel@vger.kernel.org, regressions@lists.linux.dev,
Andrea Cervesato <andrea.cervesato@suse.com>,
Sungjong Seo <sj1557.seo@samsung.com>,
Yuezhang Mo <yuezhang.mo@sony.com>,
Christoph Hellwig <hch@lst.de>,
"Darrick J . Wong" <djwong@kernel.org>
Subject: Re: [LTP] [PATCH v1 1/1] swap: Add exfat to filesystems requiring tst_fill_file
Date: Tue, 25 Aug 2026 15:46:15 +0200 [thread overview]
Message-ID: <ao2cpyGYcL-rZLgc@yuki.lan> (raw)
In-Reply-To: <20260825132604.GA70046@pevik>
Hi!
> > That does not make much sense, if swap_activate was added to kernel,
> > pre-filling the fallocated file shouldn't be needed anymore.
>
> Good catch, you're right. I'm also confused, before v7.2 swap worked on exfat,
> now even with 82a81a7352bc ("exfat: add iomap buffered I/O support") [2]
> and your fix 03a43677ca91 ("exfat: add swap_activate support") [3] is not
> working. Obviously the fix was not good enough.
There were two bugs I suppose, one is that fallocate() support for exfat broke
the swapon on fallocated file. The second bug was introduced later when
exfat was rewritten to use iomap. The iomap case was fixed in the patch
above, however it looks like the original bug caused by fallocate()
implementation for exfat is still there.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2026-08-25 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ajQFErzQW4qfU_Cp@li-276bd24c-2dcc-11b2-a85c-945b6f05615c.ibm.com>
[not found] ` <6a463902.41a38e5f.27f5bd.337a@mx.google.com>
[not found] ` <akzN_iISxNTztbEw@li-276bd24c-2dcc-11b2-a85c-945b6f05615c.ibm.com>
[not found] ` <20260825112755.GA62429@pevik>
[not found] ` <ao2TtyQpCGP5TLpx@yuki.lan>
2026-08-25 13:26 ` [LTP] [PATCH v1 1/1] swap: Add exfat to filesystems requiring tst_fill_file Petr Vorel
2026-08-25 13:46 ` Cyril Hrubis [this message]
2026-08-26 0:23 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao2cpyGYcL-rZLgc@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=japo@linux.ibm.com \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=regressions@lists.linux.dev \
--cc=sj1557.seo@samsung.com \
--cc=yuezhang.mo@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox