From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 519D83BF665 for ; Tue, 25 Aug 2026 19:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787684903; cv=none; b=DP0jmz1LBkL0zo6zgJE8xe1TbH9fBo47LTo4BA1IYgqfIsTMI6zp8awgT2qlL8wvCQbGNVoU6xbqTAGhvdMoDPHm3fn8BTxgHcVYot41/rE9Gr8iEGNOQxuzBuJjOnWdSR1EWlvvjHooGRTT08fvKC8voSG2KpyMTNFChr7m7RQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787684903; c=relaxed/simple; bh=VgttgqeeOlrykLZCGS/qEjZQQbVFLqSvRQ4792GQ6P0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y8O86qz0m4ADPei1pHaE2mxqqrdPYW9fuXQEb4JhE68qimFYlW/A/d5okQ4uoxbA322NAcCGUy76vHsdlh06Eb31eIlYK1htwpZ/V+aEv4H1cFS7cNWih+/RViI3E6mWbnPuTUTDSLePTE2SgY0jBt7ruTm51cEmDozV/CMmDlE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hD0oRyO6; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hD0oRyO6" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2d3b440b97aso24175ad.1 for ; Tue, 25 Aug 2026 12:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787684902; x=1788289702; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=qTbnZdKCLLlaDJ0a/A2nFTAg6s9FohnWs0NnAWaP8fU=; b=hD0oRyO6gXw6hdznoGSfO33NpPWi4djuVa5POBKpm546ihiHMrK2SRRbIq/EwLsZws wnxqw6beMxgeOWe9HSSg1PchdigX42GgTLQObDDDq3CdXP0ovPTD4hjVywtHZffHmio8 qRSddNQAVpyj6whrChmqtXYVM7w9x0yUQne26osEmY02XLnqIfVIHLTYyempAwSuUsLY 8Y8ktRy+BO2pU79y4Hc2QdKRDFK8Qv+uQy/wwjMY8f0uKPhyQz3nuRZ/e11iahUvHYkl bXkB17TNa8E1SEsR08Q6HXRk9nz0aaldtkPOtkpvhCdfR90zfAxMHEMuWw0vubzWwRlO vl8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787684902; x=1788289702; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qTbnZdKCLLlaDJ0a/A2nFTAg6s9FohnWs0NnAWaP8fU=; b=YS8V9M4DXRPfH3ecRzNo+30/Si4oz0l8bWGD0+ApdLTM00txlk8g03KqJ28dA3lT7T C5OjV6YU0WcC/5oy5R0ECeuKSjrWPCcSbMFeC2PIXusnxWIYsTMr9X9GrkKocoJHNEES b/YI/6Hy127c0AF36yFNITWSXG58/TpUaC5qdRh84v9OluT1pMwmPmK8k5wF/aTpO+rM q881M0PA27Za/QO7+ZM5eQvGjxYH5MCapPs6gLO3dLNXplTHQUUAxGNwhBdxs17WBheS oEtCgqlU+/9a3QZQUc0+N+OuXYGmkuiWKTTwb+shQIZrt2vd3V5/b6HxVoq3YM3055LS XeSQ== X-Forwarded-Encrypted: i=1; AHgh+RqZlXjp/gQMhvNN90uaK532ZCQeCQwTBsoTy/4Rz/Uim1nd8ct4rZ5b7HBvD2rUnr2yyMaByAvkEhQMMoc=@vger.kernel.org X-Gm-Message-State: AFuF++keiUhwxPJsn1R87GRbAko4fRB7I3fLpluh9DKf+YTbpdBzzO68 PBEybt2n3qLD6e/vbdwu9+MOsOKR5Q9YW9RRrLL92rKGbGQHHAqjX8Ao77iFKTuGTA== X-Gm-Gg: AR+sD12PK+7ov2MaereyCayYr3SkLzbvQzLANC1bwlyQNhXP83O/b7w5VBsMdC7I8jz D7ykrMVPIYQYjUDdJ0DLZ5yUFK/vtoHaDyW4nB0R6ahAdpSrVifRRxuTTHeBSsJq3vEe1YHSDrh hEbhbtYjHcfhQP49QWxbmS/bFdU8QWpp94cwmjS1qFR1IfUbS8xwE9YfQz05YhqnyFkFgbhwd0D fxpOHoocqBPUHCeVR9BGvqsXG7g/BXAR9eyrDA5ETH+cB+P2gGREunC4ORNF5FNgofkvyZJqN55 Z6avehMH5LEIS0vYXpEEcLCcEwtDJ/WDrdDW+Funhkpm8knyNTgbrNht0MS3U6WflJ1MCZMAgzx 5hiouISjDwQt/QnV10nzddWVqJw2zt1hjvHYVZoGl5JI7KNfbbzIdMrrTgqoZ8jJnnBZCSIaNzF UN7Cdti9aHkiIzt9eqDQan09FHB+vLTAwYsc99ab3YbihWwHKfmaaDgwBLScqyMob+mW6cBw1Zh 60N3nMNtUKfRqSd7Z2NIbQH2AC28skmhfBkXA== X-Received: by 2002:a17:902:e545:b0:2bf:1000:d3ac with SMTP id d9443c01a7336-2d707bc9904mr640115ad.11.1787684900811; Tue, 25 Aug 2026 12:08:20 -0700 (PDT) Received: from google.com (164.210.142.34.bc.googleusercontent.com. [34.142.210.164]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39668a5832bsm805257a91.15.2026.08.25.12.08.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 12:08:20 -0700 (PDT) Date: Tue, 25 Aug 2026 19:08:14 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel , Suravee Suthikulpanit , Vasant Hegde , Ankit Soni , Bjorn Helgaas , Samiullah Khawaja , sashiko-bot@kernel.org Subject: Re: [PATCH v3 2/5] iommu/amd: Fix DTE clearing and rename iommu_ignore_device() Message-ID: References: <20260824122347.1588592-1-praan@google.com> <20260824122347.1588592-3-praan@google.com> <178759520117.3131778.15279605903087565179.b4-review@b4> <20260825114916.GT244917@nvidia.com> <20260825175315.GD3325090@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260825175315.GD3325090@nvidia.com> On Tue, Aug 25, 2026 at 02:53:15PM -0300, Jason Gunthorpe wrote: > On Tue, Aug 25, 2026 at 05:29:59PM +0000, Pranjal Shrivastava wrote: > > > I agree, but I wonder why the existing code used memset here > > (in ignore_device): > > > > memset(&dev_table[devid], 0, sizeof(struct dev_table_entry)); > > > > I was thinking it might've been done for probe failures in a kdump > > kernel (normal kexec would've called shutdown for clearing all DTEs). > > (I see this was added long time back and existed when PCI segments were > > added [1]). > > For kdump you'd want to keep the original translation running in this > case. > > > Are you suggesting to remove the DTE clearing from this path entirely? > > Yes > Even I'm not sure why we had this memset here, I'll just dig into the history once if there's anything. Otherwise, I'll simply drop this. Vasant, please let us know if there was a different context to it? Thanks, Praan