From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f6.google.com (mail-pj2-f6.google.com [74.125.227.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC04E3E835E for ; Tue, 25 Aug 2026 22:07:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.134 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787695630; cv=none; b=qzph/BRQ95E/9CLF2O+sNDLl54RdLnAXkaSbfCRdDBu13xKLqojGNVf9mjjkZJkjEOxDYAqEYInnVy6OPbSLtN4aG5F9fKKOhTr2hxSqeYFKZIwLgZlzqGshUywYkR90V5Z7J52mBXdOAgKsQ682oiNW7gYKalZePoPPm2O+8Zw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787695630; c=relaxed/simple; bh=63qI2K79bcm4cDczUBl3jeHM3xipML3Gz7DLpnr04Gg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Het3t4PBfPiOWDNr2l2wF8a36/jA0PPVS0dQdnlUzFSnUgystNMyMdR3ey2PMWXpZfvkt1bZIX+WxdTLPWdyoq/E+felebYAXVtO0HeB0ke0tD+RH3gssbo60t/onVcBKgujBFe97qRJi+dGVgQaCfIU4VAoinKecr11L+OEN6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yd59fMiL; arc=none smtp.client-ip=74.125.227.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yd59fMiL" Received: by mail-pj2-f6.google.com with SMTP id 98e67ed59e1d1-39655e2a1d9so106177a91.1 for ; Tue, 25 Aug 2026 15:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787695628; x=1788300428; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=E2HRqo0BNmOG+wvSL71FMHVkpYIR+F5v9R73Mp72HJs=; b=Yd59fMiLkFIJFSaPsIB3sDLIkOhLNFFSJ2OohGDo2kEp+Mb7bBfjkPhbYzXsKoDtEc FaYfC+TL965X0LUTYCDhIDa36EfNtR9+jpwimN1ufte8eJSU82m765RVGEXCcLF1iNvr +84R+0SeJ0oEC8f0mLCRlZ/PFjelJ84y3Iw0SepbLLH7NUfwhNK2Q4Pmtmib1bhF+aE5 4awltP8HYAr1IldJ4ip5GO8ANpYtn8dq4nAXzbPufhc38milbbM/HQh2hrxR0QsEwD8G Oye1PCF41GB17nFHF1WxRpSFCg1VH8tHC+XWKOJ00JSEJiy7F779FWtSYWPw90kn/ViJ QCcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787695628; x=1788300428; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E2HRqo0BNmOG+wvSL71FMHVkpYIR+F5v9R73Mp72HJs=; b=dYRQHx2GFPcE5BI4gUtZtAadjA+4jSqDCQXdi9vTGqln214AmV6V+Gu3OC0L/Ki+ll NL8mBL+VaJM6HTgOgbXuQfSu3rNWv6gY0QXNkwAm2FhRF1VxFCdvLiB64W3Yu088qBaV bvS2Y/p0hPJdU60U/8bOtPGc6SqSuR3HGEifZEhs5GPKoYHNQoNfZb/rIMyyV4DRiM3c pnTFanboKrOhCo8tmqOAc9a5R9KlfHH83FlxQxTP7Ujc6oYKIhOO2q5lMT4QRWPNXr+/ xe3GT7LGUUcjypg1KgyH13POY4VvLsN31sFa7VP+xJiC+vvYcXlwyhWtE5tW6Y9GIjZq rl2g== X-Forwarded-Encrypted: i=1; AHgh+RpRW97HCnze7eqG5W4YYJIecEk3bCZbr7nfnCIy97xikfUE+j8Xy4fLeL3F0F9IaoNAkqmH5R3p+5SKvTc=@vger.kernel.org X-Gm-Message-State: AFuF++kpe63dizZhYHT4LBE6c6iDDT4ze34paFqYnrcNJ9fqciRQYqvF gXNHAvGKM5eRaWXQA34E3DeaXVBx3BpbIfd0FOFLcHI5szyv/8b5smZ/ X-Gm-Gg: AR+sD129X973PNM11eA31+nh0RlBIzeYtbrw/+HD42kxft8FY7hmMkDEejI/D7pBSU1 GWI+vkNZ1uBkfGSYrHl4Z32RXem71E/wGmsPrzi2iIMOJjK9F3/V9xxggzYg2jFM33qIPH4T7kK JZgQQgTBuw8i2gSuml63vOFQa2ahu0/fE8HVADyc9/IEqLegkFAqXUwTjs08rh9xNuCRAI2B7FY TpjlpWPIwpgQ1ztA/j5ZOBWDPWFkCIlnP5F90Rc+X6PYfqyn9Vbk7QTf7cVCFjYtBHxhQIyYJYa au2Tv+8pV8d6kTt4pAfiXD/0CxMW74uLkcfA12KLMs/inuxAkZFdwvXfTpzGljYCvHNsReOw9Jm APN6REghqbE5asBmQfBz2vXwYpSa5FzMXDT3VE+MgiU1V4rOrpYo1ZaNcBifmM2Luo+/5de1Y13 IbyJe0BoUGIBdJ42PvGHkUhOs9kaQDIkT1RxuhAIjoVlHv51a+/gX5s0v+LJGjMfhz X-Received: by 2002:a17:90b:3b4b:b0:381:11eb:d78e with SMTP id 98e67ed59e1d1-3966d8b6295mr4351538a91.14.1787695628197; Tue, 25 Aug 2026 15:07:08 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:46::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39668a57396sm1314425a91.13.2026.08.25.15.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 15:07:07 -0700 (PDT) Date: Tue, 25 Aug 2026 15:05:46 -0700 From: Stanislav Fomichev To: Jakub Kicinski Cc: Maciej Fijalkowski , netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, aleksander.lobakin@intel.com, horms@kernel.org, magnus.karlsson@intel.com, sdf@fomichev.me, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, guoren@kernel.org, dtatulea@nvidia.com, witu@nvidia.com, martin.lau@kernel.org, yoong.siang.song@intel.com, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org, linux-csky@vger.kernel.org, leon@kernel.org Subject: Re: [PATCH net v3 3/3] net: stmmac: document oversized AF_XDP frame handling Message-ID: References: <20260819160535.1472459-1-sdf@fomichev.me> <20260819160535.1472459-4-sdf@fomichev.me> <20260824111443.34bffe04@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260824111443.34bffe04@kernel.org> On 08/24, Jakub Kicinski wrote: > On Fri, 21 Aug 2026 10:28:47 -0700 Stanislav Fomichev wrote: > > > > I do agree that a better idea is to probably do these checks during control > > > > paths, but it's a bit more involved (and not sure if it's possible? if we > > > > have a bunch of xsk sockets and we change that max_sdu, do we go over all > > > > sockets on the system somehow?). My main motivation with this patch was > > > > to make our LLM reviewers less chatty about preexisting issues. > > > > > > I hear you, however I feel like we do not know this driver too much and > > > probably we don't have a HW to test out such changes, so maybe let us try > > > to fix existing behavior? > > > > Let's definitely fix it properly if you have better ideas. But since we > > don't have HW, I'm not super confident doing anything sophisticated > > myself :-D > > Let me take the first 2 patches and leave the stmmac for later. > I don't think anyone involved care particularly deeply here. > > Maxime said he bought a bunch of relevant HW. If we finally wrap > the AF_XDP tests into driver runtime he should be able to help us... Sounds fair, thanks!