From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Matt DeVillier <matt.devillier@gmail.com>
Cc: "Sebastian Reichel" <sre@kernel.org>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
chrome-platform@lists.linux.dev, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] power: supply: cros_charge-control: adopt EC charge state on probe
Date: Wed, 26 Aug 2026 01:58:09 +0000 [thread overview]
Message-ID: <ao5IMfqCOlrTBv5E@google.com> (raw)
In-Reply-To: <20260825120929.13168-2-matt.devillier@gmail.com>
On Tue, Aug 25, 2026 at 07:09:00AM -0500, Matt DeVillier wrote:
> diff --git a/drivers/power/supply/cros_charge-control.c b/drivers/power/supply/cros_charge-control.c
...
> +static int cros_chctl_init_state(struct cros_chctl_priv *priv)
> +{
> + struct ec_response_charge_control resp;
> + s8 lower, upper;
> + int ret;
> +
> + guard(mutex)(&priv->lock);
> +
> + /* v1 cannot report current state; force a well-known EC configuration. */
> + if (priv->cmd_version < 2) {
> + cros_chctl_set_default_state(priv);
> + return cros_chctl_configure_ec(priv);
Given it has introduced the label, how about:
goto defaults;
prev parent reply other threads:[~2026-08-26 1:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 15:57 [PATCH] power: supply: cros_charge-control: adopt EC charge state on probe Matt DeVillier
2026-08-25 10:04 ` Tzung-Bi Shih
2026-08-25 10:40 ` Thomas Weißschuh
2026-08-25 12:08 ` [PATCH v2] " Matt DeVillier
2026-08-25 12:09 ` Matt DeVillier
2026-08-25 16:51 ` Thomas Weißschuh
2026-08-26 1:58 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao5IMfqCOlrTBv5E@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=matt.devillier@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox