From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBAD5231842 for ; Wed, 26 Aug 2026 08:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787734678; cv=none; b=pY3AFIzr0ld3juiblAhYkoNh31l87HLpeGc6b9ZFky3y0uGpnhg1EmKryH2Mz+C/6oOaYbuXC6rIxr+fzncLkk8Kuw+KaY5EEKPZwnoNLlWzKkyESENsMY/E9cUq2af1HKXUBoVVmP2dFa72BjqzG6zdCzOEllP4gsCL/SLuviQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787734678; c=relaxed/simple; bh=ulkf/t7OJ7WGXCfgEhtP/r7bS9OB9yLRw7ZeDCQeDek=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ku0Oel4l9LDT3WHQpEiAOlSxxE3+4xZ6YahUbNzQ69ne5mj8jdeyPqcLcBJ8Ylg/8XeRktwaWZFfoD41PT4Rf9YRgMJaGWtU84JzhZ2pTpDapZq2vzMC1GwdI2qJbIpZuakd+LwfesTUpUlQ5I+SjiUzFp7ij7TsYvDT92EyZyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=vJIOXXPY; arc=none smtp.client-ip=95.215.58.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="vJIOXXPY" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=ulkf/t7OJ7WGXCfgEhtP/r7bS9OB9yLRw7ZeDCQeDek=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787734673; v=1; x=1788339473; b=vJIOXXPY8eYJB+RKVWaPWzNBvyFoLDOZxd1hRviOdO6YdLh8dmfkXKXJI0KYedDZMDGKypnu 27lMv45PJFh3+SsxzSR3YUEr3B9AHJfH63k38eDU22kfGDrZOzPJpbl60DdSHX0nbQzVJ0yA+Ju cp4KifaUNaHGh+1LWqsGzTi4= X-Envelope-To: linux-kernel@vger.kernel.org Received: from localhost (223.70.159.239) by mta12.migadu.com with ESMTPS id 984b0c1ee52124eb; Wed, 26 Aug 2026 08:57:53 +0000 X-Mizu-Trace-ID: 984b0c1ee52124eb X-Migadu-Flow: FLOW_OUT Date: Wed, 26 Aug 2026 16:57:50 +0800 From: Baoquan He To: "Barry Song (Xiaomi)" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, axelrasmussen@google.com, baolin.wang@linux.alibaba.com, chenridong@xiaomi.com, david@kernel.org, hannes@cmpxchg.org, kasong@tencent.com, lianux.mm@gmail.com, linux-kernel@vger.kernel.org, ljs@kernel.org, lyugaofei@xiaomi.com, mhocko@kernel.org, qi.zheng@linux.dev, shakeel.butt@linux.dev, stevensd@chromium.org, wangzicheng@honor.com, weixugc@google.com, yuanchu@google.com, zhangbo56@xiaomi.com Subject: Re: [PATCH 4/6] mm/mglru: exclude folios promoted by aging from protected in inc_min_seq() Message-ID: References: <20260821102538.22642-1-baohua@kernel.org> <20260821102538.22642-5-baohua@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260821102538.22642-5-baohua@kernel.org> On 08/21/26 at 06:25pm, Barry Song (Xiaomi) wrote: > Some folios may have been promoted during aging, so don't count them > as protected, similar to sort_folio(). Makes sense, the change makes it consistent with sort_filio. Reviewed-by: Baoquan He > > Signed-off-by: Barry Song (Xiaomi) > --- > mm/vmscan.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 3b618a51cde2..7bd01875fade 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -3949,16 +3949,15 @@ static bool inc_min_seq(struct lruvec *lruvec, int type, int swappiness) > if (gen_increased) { > delta += nr_pages; > list_move_tail(&folio->lru, &lrugen->folios[new_gen][type][zone]); > + /* don't count the workingset being lazily promoted */ > + if (refs + workingset != BIT(LRU_REFS_WIDTH) + 1) { > + int tier = lru_tier_from_refs(refs, workingset); > + > + protected[tier] += nr_pages; > + } > } else { > list_move(&folio->lru, &lrugen->folios[new_gen][type][zone]); > } > - /* don't count the workingset being lazily promoted */ > - if (refs + workingset != BIT(LRU_REFS_WIDTH) + 1) { > - int tier = lru_tier_from_refs(refs, workingset); > - > - protected[tier] += nr_pages; > - } > - > if (!--remaining) > break; > } > -- > 2.34.1 >