From: Breno Leitao <leitao@debian.org>
To: Adam Young <admiyo@amperemail.onmicrosoft.com>
Cc: Sudeep Holla <sudeep.holla@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Adam Young <admiyo@os.amperecomputing.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
rmikey@meta.com, kernel-team@meta.com
Subject: Re: [PATCH] mailbox: pcc: Free the channel before unmapping the shared memory
Date: Mon, 17 Aug 2026 02:42:46 -0700 [thread overview]
Message-ID: <aoLVnCqlj3ffTd-e@gmail.com> (raw)
In-Reply-To: <1a2fb06b-a5e1-46e6-93d8-829b7419142d@amperemail.onmicrosoft.com>
Hello Adam,
On Sat, Aug 15, 2026 at 11:58:16PM -0400, Adam Young wrote:
> On 8/12/26 08:36, Breno Leitao wrote:
> > Free the channel first, before the memory unmap. mbox_free_channel()
> > calls pcc_shutdown(), which frees the platform interrupt, and then unmap
> > shared memory.
>
> I posted a related fix undere the MCTP PCC Driver changes.
>
> This fix is necessary but not sufficient to deal with the race conditions.
> Take a look at the series of patches under here:
>
> https://lore.kernel.org/all/20260721175258.87600-1-admiyo@os.amperecomputing.com/
That looks like a much bigger series, with new features, open discussions,
Nacks, and already 45 revisions.
This curent fix is only meant to address a real problem (user after
free) I am hitting in production systems.
My suggestion is that we get this real issue unblocked, even if not
complete, while you keep working on your larger series.
Thanks,
--breno
prev parent reply other threads:[~2026-08-17 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 12:36 [PATCH] mailbox: pcc: Free the channel before unmapping the shared memory Breno Leitao
2026-08-13 2:57 ` Sudeep Holla
2026-08-13 8:18 ` Breno Leitao
2026-08-13 10:45 ` Sudeep Holla
2026-08-13 10:54 ` Sudeep Holla
2026-08-16 3:58 ` Adam Young
2026-08-17 9:42 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoLVnCqlj3ffTd-e@gmail.com \
--to=leitao@debian.org \
--cc=admiyo@amperemail.onmicrosoft.com \
--cc=admiyo@os.amperecomputing.com \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmikey@meta.com \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox