From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1210840A944 for ; Mon, 17 Aug 2026 11:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786966819; cv=none; b=jRVyK9LLrIq5uGXn0RMyJ7ne1kAJimHj64zwVq0p570EXDhvexmn/APd+XKROkoh7uNkTzgbDM3y4sq0cbB03/YScT4iImwR+DGsxpDNWyzMUZ9tvDTqc1wK5deRl3wR8PiDRsLstQuQFjDUS1FSSac1JYWY3Q9naklFpF10Prs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786966819; c=relaxed/simple; bh=LGNa7Rl2qx4fJ0uiJwbdCZFP1Nx2xZ5uWARAvSFuRgQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=em/m9Kv419yKL0gT2012zYaS39789vbXUApdW8Gpeo+sfJjVPWV6y45X5VI0OwvEZnuuyYQx3FnPmf87g81/wsv9bTY01BQrKzRp6M74NaYhu6rQV3dR3AOVc+CndjcKTL2GfloWVMY8YrZggZ0bYmFRhDG5PwELg13ovTfPWAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=fza3L/8a; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="fza3L/8a" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7ec3b429a3aso2182958a34.1 for ; Mon, 17 Aug 2026 04:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1786966817; x=1787571617; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:reply-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=S2qLgNpA4LRtDpmkwBOfuxl0FZx+HMlqBHB/1ChDUmg=; b=fza3L/8aMPiEkXV43A63PbujqvZ1qI0v5H+LFGZZv+WV9nZJbFVUVCxsrfjRhVqgr2 urNQmHe3FiQyyiNYyxbjbAA+dLd9xIA4SN7FOkZajftjmlVqIMHJ/+EelWO2Yr03ZpZ+ pIDMoD0SIAHD9jpsTzQXVb/2vQ4ue6RcduXNrX2+fw29edVNs8vmICAKCAR9B9Co6fiL HgrvzphMyrPt19TXfVTCpauJ4XdGucp3zUuChxKeyCtPx3dAuMTW2L65CB/ia0eQ+FaI MJzV9xiy8KkDvkI4A8oA019DoGTJusZNh6vWuelD8UbT3Jjadlx9x5IxJYnuZK5F4iEL yFqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786966817; x=1787571617; h=in-reply-to:content-disposition:content-type:mime-version :references:reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=S2qLgNpA4LRtDpmkwBOfuxl0FZx+HMlqBHB/1ChDUmg=; b=nWCocSUJDyaBIPH1+jX/62z29ICjTGFOgWYM2kMWiANaCfQxrATFqAjiyIl6O0i7QI F4prBeLWP2FTiEzjXYMxo8BZMfmcS9UVgvDXr5ae7cRdSRSyxRp7aCQ8WldYOxosuIfn VteN8pMKYYhcC6RVe7z9+HwdHSJ1/3N8hg/VXGQ1+b9h0lJ2cjMcX8j7ix5Nx8EsJAvd 8g49XarW0QGYWEdQkvFPGfZsARW8Hn/RU+JWfVlbBpc9ny47NEUn9v50G9kREvKh/m0A G8tDbh1CqKFVZwXTIAED+e4qzRRT/Pu5nX3imMniYTHRMse0R9jJv1YIKY1C9Vs5XPLd Q2+w== X-Forwarded-Encrypted: i=1; AHgh+RrXTWJjxXU7lBxDDsYS5HpQB+cOxzTZNN8bibU1yHDlw0uGYEaaKlunP11Kc2zQxoMcZOiEFcKZVporfc4=@vger.kernel.org X-Gm-Message-State: AOJu0YxCYr7KCMuXrurbaJQZIEtTkDBWIEDdjW1l9E9Pwqd6x9wbTIap 2v7S9Z7lCya7QpjyjPYsYSu4Yts6MK4CZJC/e7uOzoBV61a2DaYVy99oCWE6Cyg4gsA= X-Gm-Gg: AR+sD13Eq4YG0bUkKPB7vstgZVSvRhbKLIJoGEiLeZjGirVqKT4ZDTEmGo9tkMazI34 W9uwW+Ztb7biFOXniSUHmzKoWi99+sEV8a6okKJc3ZbVK1Q0NaZmQWYGVitF0AbMNhC9I9zxMhn eyTPFyMNP2XItuOHMcqvUjkh2p5UUeFTOw9bP+M0vjzXQK8bgHzEelbwuwXI8viJ777XrnuHd9l VFaApPlNub0geJTOCWgqi5+3xK6FTXvxoGfpHVrCP04RaD+mb+gGz804YNi2asiyPs1VVo+gkET E8CWgsG0g0wq6RKm+XE6Ou6i/4OHTfXFfjIKp74Zdyaxe+tMyeTaM/GH5k10rJyvF2xVVACKaVi rrQ8sb1K10PUkfr92KUZEN1O7BlLwLBTs0X8VrAl/N3imAWVNGAYvqXMnCU/3B0Dq4A4S1pvsF7 O4k3UY/aLwxLphnH4pnNABuQOIcRSA8NUz8euk3psy/Wy4eE/eLqj4ld8wiCteZsuu5RNZbuIkW YYYDCACeRJOaoCmLTpznbO0abQ/lOeTgiDDHGqVgcRVn12NW+VUs3pm0hrcd8yRgyuTqP5xoQAh l2VBGGOsDPMqR5XUW7k8 X-Received: by 2002:a05:6820:3415:20b0:6b0:b57c:a8c9 with SMTP id 006d021491bc7-6b0d690e813mr15415015eaf.34.1786966816936; Mon, 17 Aug 2026 04:40:16 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:c4a1:35b4:5ae5:9edc]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f41bef03b9sm1110878a34.3.2026.08.17.04.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 04:40:16 -0700 (PDT) Date: Mon, 17 Aug 2026 06:40:12 -0500 From: Corey Minyard To: phucduc.bui@gmail.com Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] ipmi: bt-bmc: Handle -ENXIO from optional IRQ lookup Message-ID: Reply-To: corey@minyard.net References: <20260817105041.63224-1-phucduc.bui@gmail.com> <20260817105041.63224-2-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260817105041.63224-2-phucduc.bui@gmail.com> On Mon, Aug 17, 2026 at 05:50:39PM +0700, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > platform_get_irq_optional() can return -ENXIO when no IRQ resource is > available, as well as other negative error codes. > > The probe path supports running without an IRQ by falling back to > the timer. Treat -ENXIO as the no-IRQ case while propagating other > errors to the caller. This is obviously wrong, it will pass -ENXIO into devm_request_irq() if returned. -corey > > Signed-off-by: bui duc phuc > --- > drivers/char/ipmi/bt-bmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c > index 7d3944bda8db..4c5457c88503 100644 > --- a/drivers/char/ipmi/bt-bmc.c > +++ b/drivers/char/ipmi/bt-bmc.c > @@ -380,7 +380,7 @@ static int bt_bmc_config_irq(struct bt_bmc *bt_bmc, > u32 reg; > > bt_bmc->irq = platform_get_irq_optional(pdev, 0); > - if (bt_bmc->irq < 0) > + if (bt_bmc->irq < 0 && bt_bmc->irq != -ENXIO) > return bt_bmc->irq; > > rc = devm_request_irq(dev, bt_bmc->irq, bt_bmc_irq, IRQF_SHARED, > -- > 2.43.0 >