The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: "Nico Pache (Red Hat)" <nico.pache@linux.dev>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	 linux-doc@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	 David Hildenbrand <david@kernel.org>, Zi Yan <ziy@nvidia.com>,
	 Baolin Wang <baolin.wang@linux.alibaba.com>,
	"Liam R. Howlett" <liam@infradead.org>,
	 Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
	Barry Song <baohua@kernel.org>,
	 Lance Yang <lance.yang@linux.dev>,
	Usama Arif <usama.arif@linux.dev>,
	 Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	 Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Jonathan Corbet <corbet@lwn.net>,
	 Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v4 7/7] mm: Documentation: clarify where the mTHP stats live
Date: Mon, 17 Aug 2026 13:37:56 +0100	[thread overview]
Message-ID: <aoMAkG9hGAXAh9va@lucifer> (raw)
In-Reply-To: <20260811-khugepaged_pte_refactor-v4-7-ddac39d61c4a@linux.dev>

On Tue, Aug 11, 2026 at 06:48:39AM -0600, Nico Pache (Red Hat) wrote:
> The note about khugepaged counters references /proc/vmstat for the PMD
> case, but never mentions where the mTHPs stats can be found
> (i.e.: /sys/kernel/mm/transparent_hugepage/hugepages-<size>kB/stats/)
> Add a small addition to this section for clarity.
>
> Also fix a missing period while we are at it.
>
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Suggested-by: Lorenzo Stoakes <ljs@kernel.org>
> Acked-by: David Hildenbrand (Arm) <david@kernel.org>
> Signed-off-by: Nico Pache (Red Hat) <nico.pache@linux.dev>

Thanks! LGTM so:

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>


> ---
>  Documentation/admin-guide/mm/transhuge.rst | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst
> index 16f37135ed80..b187d618452f 100644
> --- a/Documentation/admin-guide/mm/transhuge.rst
> +++ b/Documentation/admin-guide/mm/transhuge.rst
> @@ -224,7 +224,7 @@ khugepaged will be automatically started when any THP size is enabled
>  (either of the per-size anon control or the top-level control are set
>  to "always" or "madvise"), and it'll be automatically shutdown when
>  all THP sizes are disabled (when both the per-size anon control and the
> -top-level control are "never")
> +top-level control are "never").
>
>  process THP controls
>  --------------------
> @@ -301,7 +301,9 @@ being replaced by a PMD mapping, or (2) physical pages replaced by one
>  hugepage of various sizes (PMD-sized or mTHP). Each may happen independently,
>  or together, depending on the type of memory and the failures that occur.
>  As such, this value should be interpreted roughly as a sign of progress,
> -and counters in /proc/vmstat consulted for more accurate accounting)::
> +and counters in /proc/vmstat consulted for more accurate accounting.
> +Per-order mTHP collapse statistics are also available under
> +/sys/kernel/mm/transparent_hugepage/hugepages-<size>kB/stats/)::
>
>  	/sys/kernel/mm/transparent_hugepage/khugepaged/pages_collapsed
>
>
> --
> 2.55.0
>

--
Cheers, Lorenzo

  parent reply	other threads:[~2026-08-17 12:38 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 12:48 [PATCH v4 0/7] mm/khugepaged: several cleanups Nico Pache (Red Hat)
2026-08-11 12:48 ` [PATCH v4 1/7] mm/khugepaged: refactor per-scan state clearing into collapse_control_init_scan() Nico Pache (Red Hat)
2026-08-12  9:23   ` Pedro Falcato
2026-08-13  0:16     ` Nico Pache (Red Hat)
2026-08-17  4:33   ` Lance Yang
2026-08-11 12:48 ` [PATCH v4 2/7] mm/khugepaged: extract reference check into folio_pte_referenced() helper Nico Pache (Red Hat)
2026-08-11 15:47   ` David Hildenbrand (Arm)
2026-08-13  0:19     ` Nico Pache (Red Hat)
2026-08-17 11:31       ` Lorenzo Stoakes (ARM)
2026-08-11 20:45   ` Zi Yan
2026-08-12  9:19   ` Baolin Wang
2026-08-12  9:25   ` Pedro Falcato
2026-08-17  4:35   ` Lance Yang
2026-08-17 11:32   ` Lorenzo Stoakes (ARM)
2026-08-11 12:48 ` [PATCH v4 3/7] mm/khugepaged: introduce a count_collapse_event() helper Nico Pache (Red Hat)
2026-08-11 20:45   ` Zi Yan
2026-08-12  9:36   ` Pedro Falcato
2026-08-17  4:37   ` Lance Yang
2026-08-17 11:34   ` Lorenzo Stoakes (ARM)
2026-08-11 12:48 ` [PATCH v4 4/7] mm/khugepaged: fix outdated comments Nico Pache (Red Hat)
2026-08-11 20:48   ` Zi Yan
2026-08-12  9:38   ` Pedro Falcato
2026-08-17  4:37   ` Lance Yang
2026-08-17 11:37   ` Lorenzo Stoakes (ARM)
2026-08-11 12:48 ` [PATCH v4 5/7] mm/khugepaged: Refactor the PTE state checks into a helper Nico Pache (Red Hat)
2026-08-12  2:04   ` Zi Yan
2026-08-12  8:40   ` David Hildenbrand (Arm)
2026-08-12  9:51     ` David Hildenbrand (Arm)
2026-08-12 10:06       ` David Hildenbrand (Arm)
2026-08-13  2:14       ` Zi Yan
2026-08-13  7:13         ` David Hildenbrand (Arm)
2026-08-14 13:58           ` Zi Yan
2026-08-12 19:39     ` Andrew Morton
2026-08-12 20:56       ` David Hildenbrand (Arm)
2026-08-13  2:12         ` Nico Pache (Red Hat)
2026-08-13 20:53           ` Andrew Morton
2026-08-12 10:50   ` Pedro Falcato
2026-08-11 12:48 ` [PATCH v4 6/7] mm/khugepaged: unmap pte before releasing vma write lock Nico Pache (Red Hat)
2026-08-11 20:54   ` Zi Yan
2026-08-12  9:21   ` Baolin Wang
2026-08-12 10:51   ` Pedro Falcato
2026-08-17  4:40   ` Lance Yang
2026-08-17 11:38   ` Lorenzo Stoakes (ARM)
2026-08-11 12:48 ` [PATCH v4 7/7] mm: Documentation: clarify where the mTHP stats live Nico Pache (Red Hat)
2026-08-11 20:54   ` Zi Yan
2026-08-12 10:52   ` Pedro Falcato
2026-08-17  4:41   ` Lance Yang
2026-08-17 12:37   ` Lorenzo Stoakes (ARM) [this message]
2026-08-11 18:23 ` [PATCH v4 0/7] mm/khugepaged: several cleanups Andrew Morton
2026-08-11 18:55   ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoMAkG9hGAXAh9va@lucifer \
    --to=ljs@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=nico.pache@linux.dev \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox