From: Corey Minyard <corey@minyard.net>
To: Bui Duc Phuc <phucduc.bui@gmail.com>
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ipmi: bt-bmc: Handle -ENXIO from optional IRQ lookup
Date: Tue, 18 Aug 2026 06:46:54 -0500 [thread overview]
Message-ID: <aoRGLnpF4hUw1nXK@mail.minyard.net> (raw)
In-Reply-To: <CAABR9nHq0mWUHCQwiymaN4HcRJoqnoBdR8vCNPEka0kGCE7_CQ@mail.gmail.com>
On Tue, Aug 18, 2026 at 01:29:56PM +0700, Bui Duc Phuc wrote:
> Hi Corey,
>
> Thanks for your feedback.
>
snip...
>
> > And it must work if no interrupt is available for any reason.
> >
>
> As I understand it, you mean keeping the current behavior of ignoring
> all errors and
> continuing to run, in order to ensure that existing systems can still work?
> Since the current code already ignores all errors, is that correct?
Yes, ignoring errors is the right thing to do in this case. Printing a
warning log about incorrect configuration is ok, but breaking systems
that have incorrect configuration is not ok.
It is common for these systems to not have interrupts. I think it's a
bad idea, but I didn't design the hardware or the specifciations. And
it's common for configuration to have issues :-(
Anyway, I think you have the parameters now, looking forward to the next
patch.
-corey
next prev parent reply other threads:[~2026-08-18 11:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 10:50 [PATCH 1/4] ipmi: bt-bmc: Propagate errors from IRQ configuration phucduc.bui
2026-08-17 10:50 ` [PATCH 2/4] ipmi: bt-bmc: Handle -ENXIO from optional IRQ lookup phucduc.bui
2026-08-17 11:40 ` Corey Minyard
2026-08-17 14:28 ` Bui Duc Phuc
2026-08-17 17:35 ` Corey Minyard
2026-08-18 6:29 ` Bui Duc Phuc
2026-08-18 11:46 ` Corey Minyard [this message]
2026-08-19 2:22 ` Bui Duc Phuc
2026-08-19 2:35 ` Corey Minyard
2026-08-17 10:50 ` [PATCH 3/4] ipmi: bt-bmc: Request IRQ only when available phucduc.bui
2026-08-17 10:50 ` [PATCH 4/4] ipmi: bt-bmc: Check IRQ number correctly phucduc.bui
2026-08-17 11:37 ` [PATCH 1/4] ipmi: bt-bmc: Propagate errors from IRQ configuration Corey Minyard
2026-08-17 14:22 ` Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoRGLnpF4hUw1nXK@mail.minyard.net \
--to=corey@minyard.net \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=phucduc.bui@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox