The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ali Nasrollahi <a.nasrolahi01@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fuse: ioctl: fix comparison in fuse_setup_measure_verity()
Date: Tue, 18 Aug 2026 19:33:54 +0330	[thread overview]
Message-ID: <aoSBawbYSlRNUTc-@zephyr> (raw)
In-Reply-To: <CAJfpegv19MoYVsvGP4S4k1n5u5u=za3yNrY4Z7wULHwLcPJ42g@mail.gmail.com>

On 26/08/18 10:53AM, Miklos Szeredi wrote:
> On Thu, 13 Aug 2026 at 09:07, Ali Nasrollahi <a.nasrolahi01@gmail.com> wrote:
> >
> > Clang reports a warning in fuse_setup_measure_verity() in
> > fs/fuse/ioctl.c when comparing the `__u16 digest_size` with SIZE_MAX
> > minus the size of `struct fsverity_digest`:
> >
> >         warning: result of comparison of constant 18446744073709551611
> >         with expression of type '__u16' (aka 'unsigned short') is always
> >         false [-Wtautological-constant-out-of-range-compare]
> 
> The warning is right: that condition is never going to succeed.  So
> just remove it?

Well, I wasn't sure why it was there in the first place, so I didn't want
to change the logic. So I'll send the v2 considering your comment.

Thanks,
    Ali

      reply	other threads:[~2026-08-18 16:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13  7:06 [PATCH] fuse: ioctl: fix comparison in fuse_setup_measure_verity() Ali Nasrollahi
2026-08-18  8:53 ` Miklos Szeredi
2026-08-18 16:03   ` Ali Nasrollahi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoSBawbYSlRNUTc-@zephyr \
    --to=a.nasrolahi01@gmail.com \
    --cc=fuse-devel@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox