From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 68A2448124E for ; Tue, 18 Aug 2026 17:09:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787072977; cv=none; b=LK0bsuifm2G0roiG2mHW58SoP4a7cqWFu/F+s7LwPBPzJXTduPzX49ixm6kIPz/H2Vy4huUO1idzcO8ff/+spVV8OZHyF0yvU5PvPizaII9ANdajPlNruo3l5FYxoLGl8hYACTpqdf1YXpFNmgXRi+jSdGH7TnnW99pIM0qkKUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787072977; c=relaxed/simple; bh=EzeUcnZ/yjp7MrpPjGMan4KyMak0EKtdio5H4NspdMA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kWgEohblZIDsKd9kLtA/U0iKP2K/slRYNAI2HscbkSzBpDxie6wOA8tOFJEzNgXyd3XSPZlucto2gEv8v8Cy4q5JrE3UAL+QD4jifo2yyVLOLS7hK5ss4cf4xXEC/+Eevtq/D3PtrhKdLg/Fl3XlyGSUzGUdPix3d3+RuY/LRkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=KJPW6XCd; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="KJPW6XCd" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1677514BF for ; Tue, 18 Aug 2026 10:09:31 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C11803F763 for ; Tue, 18 Aug 2026 10:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1787072975; bh=EzeUcnZ/yjp7MrpPjGMan4KyMak0EKtdio5H4NspdMA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KJPW6XCd1Yi9xPYHr3QKaHbaYUZ5TQxokB4UiDZCeFipvxgRtRAD6T/LFT/uAzDE9 q8cKVh0H2sLBlToJf6R4LQBLQcjjdjku2LXiXoIXXtIU7BH3YO6lR9hrmlFIhGN45O C2CMOSYGzxGtfgS0SqYi3aeVJIJqtdfz8MlB5QHg= Date: Tue, 18 Aug 2026 18:09:23 +0100 From: Liviu Dudau To: Boris Brezillon Cc: Steven Price , Chia-I Wu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 5/9] drm/panthor: Get rid of panthor_group::fatal_lock Message-ID: References: <20260811-panthor-signal-from-irq-v6-0-12f2ab53d735@collabora.com> <20260811-panthor-signal-from-irq-v6-5-12f2ab53d735@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260811-panthor-signal-from-irq-v6-5-12f2ab53d735@collabora.com> On Tue, Aug 11, 2026 at 01:23:39PM +0200, Boris Brezillon wrote: > This lock is never used, and we're about to make fatal_queues an > atomic to cope with concurrent updates. > > Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau Best regards, Liviu > --- > drivers/gpu/drm/panthor/panthor_sched.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index baa06731797c..9adf1e21eb83 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -565,9 +565,6 @@ struct panthor_group { > /** @idle_queues: Bitmask reflecting the idle queues. */ > u32 idle_queues; > > - /** @fatal_lock: Lock used to protect access to fatal fields. */ > - spinlock_t fatal_lock; > - > /** @fatal_queues: Bitmask reflecting the queues that hit a fatal exception. */ > u32 fatal_queues; > > @@ -3675,7 +3672,6 @@ int panthor_group_create(struct panthor_file *pfile, > if (!group) > return -ENOMEM; > > - spin_lock_init(&group->fatal_lock); > kref_init(&group->refcount); > group->state = PANTHOR_CS_GROUP_CREATED; > group->csg_id = -1; > > -- > 2.55.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯