The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ameer Hamza <ameer.hamza@truenas.com>
To: Chuck Lever <cel@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
	 Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
	 Trond Myklebust <trondmy@kernel.org>,
	Anna Schumaker <anna@kernel.org>,
	linux-nfs@vger.kernel.org,  linux-kernel@vger.kernel.org,
	alexander.motin@truenas.com, caleb.stjohn@truenas.com
Subject: Re: [PATCH 1/2] NFSD: Use nfsd_iter_read() when ->splice_read is not zero-copy
Date: Wed, 19 Aug 2026 04:12:55 +0500	[thread overview]
Message-ID: <aoTmC-jhOLD6F4gY@hamza-PC> (raw)
In-Reply-To: <2ed0ee16-c20e-44bd-9e7a-f5b71764f14f@app.fastmail.com>

On Tue, Aug 18, 2026 at 09:55:56AM -0400, Chuck Lever wrote:
> Hi Ameer -
> 
> First off, thanks for posting the full series to provide good
> context for your problem statement. Contention in the page
> allocator is vexing, and is a problem we've been chasing for
> years.
> 
> There is a lot to unpack. I'm going to focus on patch 1/2 and
> set 2/2 aside for the moment. I promise we will come back to it.

[ ... ]

> So what I'd like you to do is provide a backportable fix that applies
> before your series to address the fsnotify and atime accounting issues.
> I'm not convinced that stable will want the bulk of the 1/2 changes as
> you have them here.
> 
> I don't expect this work will be a heavy lift, but let me know if it
> turns into one.

Thanks, both issues were real. Fixes posted:

  https://lore.kernel.org/linux-nfs/20260818225715.572140-1-ameer.hamza@truenas.com/
  https://lore.kernel.org/linux-nfs/20260818225715.572140-2-ameer.hamza@truenas.com/

  reply	other threads:[~2026-08-18 23:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 21:08 [PATCH 0/2] SUNRPC: Recycle sent Reply pages instead of freeing them Ameer Hamza
2026-08-17 21:08 ` [PATCH 1/2] NFSD: Use nfsd_iter_read() when ->splice_read is not zero-copy Ameer Hamza
2026-08-18 13:55   ` Chuck Lever
2026-08-18 23:12     ` Ameer Hamza [this message]
2026-08-18 14:42   ` Christoph Hellwig
2026-08-18 23:44     ` Ameer Hamza
2026-08-18 22:54   ` NeilBrown
2026-08-18 23:22     ` Ameer Hamza
2026-08-17 21:08 ` [PATCH 2/2] SUNRPC: Recycle sent Reply pages instead of freeing them Ameer Hamza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoTmC-jhOLD6F4gY@hamza-PC \
    --to=ameer.hamza@truenas.com \
    --cc=Dai.Ngo@oracle.com \
    --cc=alexander.motin@truenas.com \
    --cc=anna@kernel.org \
    --cc=caleb.stjohn@truenas.com \
    --cc=cel@kernel.org \
    --cc=jlayton@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox