From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Rob Barnes <robbarnes@google.com>
Cc: bleung@chromium.org, tomhughes@chromium.org,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/chrome: cros_ec_proto: Fix deferred response
Date: Wed, 19 Aug 2026 05:16:08 +0000 [thread overview]
Message-ID: <aoU8GDNRGiyOZhQZ@google.com> (raw)
In-Reply-To: <CA+Dqm338B_5unrSnb2ztcuA2xakNj_Lp76mEXQpwmOCEXm7cYw@mail.gmail.com>
On Tue, Aug 18, 2026 at 02:35:43PM -0400, Rob Barnes wrote:
> diff --git a/drivers/platform/chrome/cros_ec_proto.c
...
> static int cros_ec_wait_until_complete(struct cros_ec_device *ec_dev,
> - struct cros_ec_command *orig_msg)
> + struct cros_ec_command *orig_msg)
It looks like the patch was generated against to wrong base.
> @@ -171,8 +171,31 @@ static int cros_ec_wait_until_complete(struct
> cros_ec_device *ec_dev,
^^^^^^^^^^^^^^^^^^^^^^^
Please check your tools. The hunk header shouldn't wrap.
> @@ -185,7 +213,7 @@ static int cros_ec_send_command(struct
> cros_ec_device *ec_dev, struct cros_ec_co
./scripts/checkpatch.pl --strict:
ERROR: patch seems to be corrupt (line wrapped?)
> diff --git a/drivers/platform/chrome/cros_ec_proto_test.c
...
> @@ -2858,7 +3008,7 @@ static struct kunit_case cros_ec_proto_test_cases[] = {
> KUNIT_CASE(cros_ec_proto_test_cmd_xfer_protocol_v3_no_op),
> KUNIT_CASE(cros_ec_proto_test_cmd_xfer_protocol_v2_normal),
> KUNIT_CASE(cros_ec_proto_test_cmd_xfer_protocol_v2_no_op),
> - KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_normal),
> + KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_payload_0byte),
> KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_payload_4bytes),
> KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_payload_gt4bytes),
It looks like the patch was generated against to wrong base.
prev parent reply other threads:[~2026-08-19 5:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 18:35 [PATCH v2] platform/chrome: cros_ec_proto: Fix deferred response Rob Barnes
2026-08-19 5:16 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoU8GDNRGiyOZhQZ@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=robbarnes@google.com \
--cc=tomhughes@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox