From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72FA93D411B for ; Wed, 19 Aug 2026 07:50:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787125831; cv=none; b=bt1iGxR7D5t72nplG6b5XRfy2ClOk02uKvoLVEn4yale86ry5pjXHeq5t8sgtmRB0dQaKPsHGrBr5CUlZktF5EG1ievOgtSTIH2nbTi49eVuSNAcyUrI/NgZ48E1TlGfp7J8nxTuLvocHPN3DUTuikUlYpNra/xQEx+HaIz/02c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787125831; c=relaxed/simple; bh=HnlDWlV7nCIHS2w3Bfo3f4BCVjnoFaqOKKjWakeiO60=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JV6wP4VhTvlnlsyIljsuoei5s/YqFRRq6MMmhdjTSID169GDZzt5mxUy5//ZI7HdEOO2lSSviu/9oYn/5C7vchbIvbCxKeI4um+8OcwYQ98s1oHNLWn67614dkRO0KHPiIgf7jJQ1gvdBadL9ZKrz6TiKmxcb1mVkcIITJjgisc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HXGPqQnL; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HXGPqQnL" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-495437bb891so4715795e9.1 for ; Wed, 19 Aug 2026 00:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787125829; x=1787730629; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1xTC2q/BWntL5hamUpphYUPdQshPoAuJKKit6UOQN/I=; b=HXGPqQnLEzHmhSLl8hjpZerEs/3tacgt+1+wanMnlOzVf4NwgFa16VW8pcU58CS3t1 IFy3W/bqd4ZajvRqilCEn043zuPsHi93YlAkNo+fivv3pKGPemPksVHu8ncxXBl3ltsE +5NQNgHhnZSbBdnWGzMQCz0LnvLh81aBmwljwKnI4jh7VQgj4s7DWPxJCMGcWEg6g5FD s+1utX2owHzu3Mk3PA3ZlY5YGEQgwndDzVsIxtXo7ZPy58OtjHeLMMKR2TgW78NUzaH8 PTY4ZEinCJXhlKBJ7J5629YPDBdLQN51qNZMi2wlHmf7ryMSBwekQPq+dR24d7XTxwGh myDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787125829; x=1787730629; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1xTC2q/BWntL5hamUpphYUPdQshPoAuJKKit6UOQN/I=; b=orD6oXTVPEbDiC4qSM386NnIdiqtJ7cYXjBnz0A+J4bpc67y6KvncFxp96Asu/nD6a pOyVhG0TxqqubBu1f52/LR3O+ZCpXqbfoGDFsR0dvoYuxz0EAkvC99LN3ZlZdaQECQmd yF6glIS7ybsy7j8S/B20sAuxO1jPbK2b/3JcygfAYYDEt/DWIpj2VyKjJ/Zp5gxHk5/W 7ElX2j9H67zLKTxup9lurlg9iHPS2m0tDpZS73w3P914DHpemGrfYMRXigxZZFyF6lfW GgyNBwuye/hIkRR4MjwWfYhOPXGcbICPWk4RwrphWy4olRl13iR7/U3oTnzaZ8JmxInY Kfww== X-Forwarded-Encrypted: i=1; AHgh+RokSda6+aT/kHrmHguc25u8122MltWIUYf5dMpY5GbvCCLA/8au8wEUQOK4pKBJsC3Of6g2ID3K+SPC8TM=@vger.kernel.org X-Gm-Message-State: AOJu0YyGiC9EBJ6ENxFKSXxfQ1QYITOELIRTWH70IrlfT/2CeYyY7GxQ f3M0dZ8N1yme5331re1vDNpRFSPHAYcpy3Nv2BghZEkovB/+Aj+HQ+J3 X-Gm-Gg: AR+sD12p0OX+h0nwVdkasqBHAUUOjiMZ5KmdW+QMYSnkflrs6NrNnmnn/LsCYyyMJfe UvQgaSHbI/T7GqEB5LhDtRnGt+D7hFPL4hvH2rY9n372xqfQzcjz2T9nNyDmHz0jbHaxRvWiBpy 4MGj7C/ry16DwLunhljDdcKmgF7atx7qtyNnMBjzsnZ0Xfep2Bz85Wb+QAE5BvcbWcbohfJBCrA blhRVadpVgxuVnnePvlO/JVYTKNGCLd0RQvrsYuxREZY41xp9qhf6kwws30R7TdBR88QyYeTV9w VY3c6CnJC8I9FsEoe0gSNeUioMbYV4dOCDNvCTPiJcY6onbizji7YjLCQoUFg4IdUWrBGrBzppD b5usr7VojUJ79oGZqn+ivrg+M8FsP67OMn5XLsw1X7ZwYUcrXaCFHKQBSTRyt2wFabVlNXl3amn YWjxLfg9Y3KjKHq0kyNTlzDmBX+KIMkq90bb6eKhR48Vi8vn2UpkhmT5E7 X-Received: by 2002:a05:600c:604f:b0:495:58fe:88e5 with SMTP id 5b1f17b1804b1-499aa0aaeb0mr28785065e9.2.1787125828606; Wed, 19 Aug 2026 00:50:28 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14c45d1sm3380695f8f.30.2026.08.19.00.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 00:50:27 -0700 (PDT) Date: Wed, 19 Aug 2026 10:50:23 +0300 From: Dan Carpenter To: Dhanush Muralidharan Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: remove extern from function declarations in header files Message-ID: References: <20260818131601.96509-1-dhanushmuralidharan@gmail.com> <20260818152055.486-1-dhanushmuralidharan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260818152055.486-1-dhanushmuralidharan@gmail.com> On Tue, Aug 18, 2026 at 08:50:55PM +0530, Dhanush Muralidharan wrote: > Function declarations in header files are implicitly extern. Remove the redundant extern keyword to clean up the code. > > Signed-off-by: Dhanush Muralidharan > --- 1. Run your patch through checkpatch 2. Add a little note under the --- cut off to say what changed https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ > -extern int rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrib); > +s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrib); 3. Don't make unrelated changes like s/int/s32/ 4. Also int is better than s32 regards, dan carpenter