From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8246442394 for ; Thu, 20 Aug 2026 13:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787231436; cv=none; b=RLnoScz0hUM64PCIuVfbeIsKyDyl0YJQekZv5PHbHYXcVGsrPfbMlwKzDA67K8XpzDIsyftqA8ptWK6SxY0jO5/4SY0WwNMMGM0vPGgxTTB3hOfS9fUlIF1SheS5YwDlJBTaLF65JFVYlDI7P05zIeEjeRC41hhUr4xsBd3tMkY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787231436; c=relaxed/simple; bh=5R7jPWhO+X8CftucDZFDpqQddilY5D/JBgSKCg5UcUw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C95+8k9QWlP5oidpa4VrhKhS9TIO3pROQ7LJjIaQXPyoyrG2d1+PNB6QLTAL4U3SOUZhN/+3XPTAYkXERmbIxRRnbsZ9c6Q0EWcZVhd3XuQ9XqxwpeizGpyZ3kTjEcv9lsurCTlK7ONT6EvpgprbfJzhoKuxAiW2d9OhF4UKc0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oShboYWx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oShboYWx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C3EC1F00A3A; Thu, 20 Aug 2026 13:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787231434; bh=3fRmigEw7qmFQY4eu/xZ0xLHtznc2W4nB8FZd9DSCys=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oShboYWxprDqsqk3dvye3hwz6sMF8/sOWXUoYuRIKZFI0D4bjFMIys93mnlmnleRq tcETnFQVfXaEnFwy0Kgzgx3/BMXnWRthzmPJCkQCNAgrD2YQXfdXYxf9oGbSTN8Aeh R5SYmeQnxlxsl3kW27j7t6LpATsosHotRsUdsKacyNYvf8VBcndbmYND9OCSflelNZ 7y+e3WFYfWezFlIXDeaLhA1hxCfoTIhlqQPPrzBQdcfi6ik69aUp0KzQ2wQRF7ayRc lPNyCKlZCrCeFRl2oNdbxA9i5hUVPmJdqqXHg37nbpDhW83rRz8fRl7MW0tAP+d7gZ nWXhrjQK/me3w== Date: Thu, 20 Aug 2026 21:10:25 +0800 From: Gao Xiang To: Guenter Roeck Cc: Geert Uytterhoeven , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Michael Bommarito , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] erofs: Fix EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS default logic Message-ID: Mail-Followup-To: Guenter Roeck , Geert Uytterhoeven , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Michael Bommarito , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <3d845134-9b75-40bd-b221-2bd35f98d425@roeck-us.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3d845134-9b75-40bd-b221-2bd35f98d425@roeck-us.net> On Thu, Aug 20, 2026 at 05:51:08AM -0700, Guenter Roeck wrote: > On Thu, Aug 20, 2026 at 12:00:23PM +0200, Geert Uytterhoeven wrote: > > When NR_CPUS is less than 16, or when SMP is disabled, the default value > > of 16 is invalid. > > > > While actual configuration picks up a sensible and valid default > > (NR_CPUS or 1), "make savedefconfig" will still write a line like > > > > CONFIG_EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS=1 > > > > to the defconfig file, even if that matches the sensible default. > > > > Avoid needlessly enlarging the defconfig files, and reduce churn for > > updating them, by specifying valid defaults depending on SMP and > > NR_CPUS. > > > > While at it, make the prompt depend on SMP, as there is no point in > > asking the user about the maximum number of decompression streams if > > there is only one valid answer. > > > > Absolutely agree. As I replied to Geert, unless there is a mandatory requirement documented that "there is no point to make a Kconfig visible if there is only one valid number". I tend to avoid making EROFS Kconfig visibility depend on arbitrary architecture Kconfig options such as SMP or !SMP; SMP here is due to some arches make NR_CPUS = 0 if !SMP, but it doesn't need to bother users why a EROFS kconfig visibility has some relationship with an arch kconfig. Thanks, Gao Xiang