The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-doc@vger.kernel.org, feng.tang@linux.alibaba.com,
	include@grrlz.net, corbet@lwn.net, skhan@linuxfoundation.org,
	rdunlap@infradead.org, andriy.shevchenko@linux.intel.com,
	kees@kernel.org, tony.luck@intel.com,
	linux-kernel@vger.kernel.org, kernel-dev@igalia.com,
	kernel@gpiccoli.net
Subject: Re: [PATCH V2] docs: panic: Disclaimer about console verbosity when using panic_print with pstore
Date: Thu, 20 Aug 2026 11:16:25 +0200	[thread overview]
Message-ID: <aobF6f7u_AF7F67H@pathway.suse.cz> (raw)
In-Reply-To: <20260819183419.2203903-1-gpiccoli@igalia.com>

On Wed 2026-08-19 15:31:30, Guilherme G. Piccoli wrote:
> Users of panic_print / panic_sys_info are usually aware of the potentially
> huge amount of information displayed with such options - their goal by
> using them is indeed to dump more information during panic!
> 
> What might come unnoticed at first is the impact that the console_verbose()
> call on panic path has, specially in cases that users rely on pstore as
> a means to collect the panic logs. Recent experience shows that dumping
> all tasks in an ARM64 system (with qcom_geni tty driver) gets a 2 minute
> delay on panic time due to writing such information to console. But in
> that case, pstore was used, so there was no need for console printing,
> and suppressing that reduced the full time to less than 0.5 second.
> 
> The option "printk.console_no_auto_verbose" aims exactly at this use
> case: avoid automatically increasing the loglevel during panic path.
> So, let's officially document this to avoid users wasting their time
> either on long panic printing or debugging the panic delays.
> 
> While at it, improve the readability of the panic_print text, by
> adding some line breaks.
> 
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Reviewed-by: Bradley Morgan <include@grrlz.net>
> Reviewed-by: Feng Tang <feng.tang@linux.alibaba.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>

Looks good to me:

Reviewed-by: Petr Mladek <pmladek@suse.com>

I am not sure if the doc team would want to take it.

I am going to wait a week or so. Then I would take it via
the printk tree if anyone else did not take it in the meantime.

Best Regards,
Petr

      parent reply	other threads:[~2026-08-20  9:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 18:31 [PATCH V2] docs: panic: Disclaimer about console verbosity when using panic_print with pstore Guilherme G. Piccoli
2026-08-19 19:03 ` Bradley Morgan
2026-08-20  9:16 ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aobF6f7u_AF7F67H@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=feng.tang@linux.alibaba.com \
    --cc=gpiccoli@igalia.com \
    --cc=include@grrlz.net \
    --cc=kees@kernel.org \
    --cc=kernel-dev@igalia.com \
    --cc=kernel@gpiccoli.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox