The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Alvin Šipraga" <alvin.sipraga@analog.com>
To: Chancel Liu <chancel.liu@oss.nxp.com>
Cc: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com,
	nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org,
	perex@perex.cz, tiwai@suse.com, Frank.Li@nxp.com,
	linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins
Date: Thu, 20 Aug 2026 15:47:55 +0200	[thread overview]
Message-ID: <aocFGXgB9X22W0XD@analog.com> (raw)
In-Reply-To: <20260820021454.2229094-1-chancel.liu@oss.nxp.com>

On Thu, Aug 20, 2026 at 11:14:53AM +0900, Chancel Liu wrote:
> From: Chancel Liu <chancel.liu@nxp.com>
> 
> Provide DAPM output widgets for the MQS_L/MQS_R pins and route them
> from the "Playback" stream. This allows external amplifiers connected
> to the MQS outputs to be properly linked into the DAPM graph, so their
> power state can follow the playback stream.
> 
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
>  sound/soc/fsl/fsl_mqs.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Reviewed-by: Alvin Šipraga <alvin.sipraga@analog.com>

> diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
> index 901f840df904..5b00488253bb 100644
> --- a/sound/soc/fsl/fsl_mqs.c
> +++ b/sound/soc/fsl/fsl_mqs.c
> @@ -183,7 +183,21 @@ static void fsl_mqs_shutdown(struct snd_pcm_substream *substream,
>  			   mqs_priv->soc->en_mask, 0);
>  }
>  
> +static const struct snd_soc_dapm_widget fsl_mqs_dapm_widgets[] = {
> +	SND_SOC_DAPM_OUTPUT("MQS_L"),
> +	SND_SOC_DAPM_OUTPUT("MQS_R"),
> +};
> +
> +static const struct snd_soc_dapm_route fsl_mqs_dapm_routes[] = {
> +	{ "MQS_L", NULL, "Playback" },
> +	{ "MQS_R", NULL, "Playback" },
> +};
> +
>  static const struct snd_soc_component_driver soc_codec_fsl_mqs = {
> +	.dapm_widgets = fsl_mqs_dapm_widgets,
> +	.num_dapm_widgets = ARRAY_SIZE(fsl_mqs_dapm_widgets),
> +	.dapm_routes = fsl_mqs_dapm_routes,
> +	.num_dapm_routes = ARRAY_SIZE(fsl_mqs_dapm_routes),
>  	.idle_bias_on = 1,
>  };
>  
> -- 
> 2.50.1
> 

  reply	other threads:[~2026-08-20 13:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20  2:14 [PATCH] ASoC: fsl_mqs: Add DAPM output widgets for MQS_L/MQS_R pins Chancel Liu
2026-08-20 13:47 ` Alvin Šipraga [this message]
2026-08-20 15:48 ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aocFGXgB9X22W0XD@analog.com \
    --to=alvin.sipraga@analog.com \
    --cc=Frank.Li@nxp.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=broonie@kernel.org \
    --cc=chancel.liu@oss.nxp.com \
    --cc=festevam@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=perex@perex.cz \
    --cc=shengjiu.wang@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox