From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 758064756BC for ; Thu, 20 Aug 2026 14:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787235670; cv=none; b=kt3Xk/I0M7oaPrzYXQaxbeXRuA3HWhHkITbH1O+aOibKaoT5SVa+ebFICBkjy2ls3Nmyk1ZaCAzvUezLgxDa+u4BZAT3iXZCGxUQI3x7W9E/Go8VZuorAcPQYzo3wH4/eEFL/s9VeZOUKea+ihMqhk4/t4s6ppcXOt4i8igjp0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787235670; c=relaxed/simple; bh=APFi0YytqyOrAkKwrnwjGG8mz7HhgttHVpRoAxh5C0g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PhdCMtI7m2ihPqHKYxuvla4PTXzKtfZk57lX5RD13LXOUrtjAS6QQP1Qm3ns4ZeiGGk7uYgFPahHlryhtigGu0w6IVNniJfaH6VPuO2rH20i/vOEqOSctQI+CDyxu5SgGg0hbg8rNaHVCxGRp2FopMEOli67EpuWIkXGwOgssT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MfVAaghu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MfVAaghu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A7A41F00A3E; Thu, 20 Aug 2026 14:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787235667; bh=+ZcdAEUhkbXN4K8ncEoNu11AWGnMK2rPAWCk6bkQll0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=MfVAaghuH+JUIlsupRpToolb10KNGB4HeLaJD0pjCKF0f8MowP+g92NifS4cuX7Nf ObA34ZNP2YDr1lNdOSuUcKLz2pBbeWK481BimPyPcyiAahccVtOPMhiRmULz7UBnYs b76zcZi+tsMBLKDzZ9OHtQCrpBkgBet8FsHFM0iGVwnfqFeFEANbxnGIw5bwKZVmTG T8CkNKsxOmtISxKhaPuyiwgMSxI2qUbREOMuFlHyN7xG1HZhnsbP1y9nY/RbzG76qm sKjD4nKdFLby/K/b5wpCjkoRiV1ja7LO9rYZPy6sQl7BSe9xpX6g8TYG3eJOsEGFFE u7ppNwbTI7siQ== Date: Thu, 20 Aug 2026 22:20:56 +0800 From: Gao Xiang To: Guenter Roeck , Geert Uytterhoeven Cc: Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Michael Bommarito , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] erofs: Fix EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS default logic Message-ID: Mail-Followup-To: Guenter Roeck , Geert Uytterhoeven , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Michael Bommarito , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <3d845134-9b75-40bd-b221-2bd35f98d425@roeck-us.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Aug 20, 2026 at 06:43:20AM -0700, Guenter Roeck wrote: > On Thu, Aug 20, 2026 at 09:10:25PM +0800, Gao Xiang wrote: > > On Thu, Aug 20, 2026 at 05:51:08AM -0700, Guenter Roeck wrote: > > > On Thu, Aug 20, 2026 at 12:00:23PM +0200, Geert Uytterhoeven wrote: > > > > When NR_CPUS is less than 16, or when SMP is disabled, the default value > > > > of 16 is invalid. > > > > > > > > While actual configuration picks up a sensible and valid default > > > > (NR_CPUS or 1), "make savedefconfig" will still write a line like > > > > > > > > CONFIG_EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS=1 > > > > > > > > to the defconfig file, even if that matches the sensible default. > > > > > > > > Avoid needlessly enlarging the defconfig files, and reduce churn for > > > > updating them, by specifying valid defaults depending on SMP and > > > > NR_CPUS. > > > > > > > > While at it, make the prompt depend on SMP, as there is no point in > > > > asking the user about the maximum number of decompression streams if > > > > there is only one valid answer. > > > > > > > > > > Absolutely agree. > > > > As I replied to Geert, unless there is a mandatory requirement > > documented that "there is no point to make a Kconfig visible if there > > is only one valid number". > > > I would call that common sense. Ok, I don't want to argue with that minor stuff more. Thanks for the patch, I will pick up this patch with all rvb tags later (no later than 7.3-rc2) Thanks, Gao Xiang > > Guenter > > > I tend to avoid making EROFS Kconfig visibility depend on arbitrary > > architecture Kconfig options such as SMP or !SMP; SMP here is due to > > some arches make NR_CPUS = 0 if !SMP, but it doesn't need to bother > > users why a EROFS kconfig visibility has some relationship with an arch > > kconfig. > > > > Thanks, > > Gao Xiang >