From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 205043C1F41 for ; Thu, 20 Aug 2026 20:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787256308; cv=none; b=HnuPKyRO0fkHSHoQPvxx/HywXrMZvv1ratdcDchfjgsnKWYxMpEh755xXZ5iaE67o7PS2uJoVkYD6id56BCreZtQ0fhkSrJzIUGnmH/81cYfklfUofbf/gWGBH6BZjNnZe6SJnwQUqjOYDkCJYowgv197CGdq1KDRyeERvoeaFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787256308; c=relaxed/simple; bh=Aw/ofYSmMq/hCctkdEPZ9sneab2XTminwcfhlt6xz3g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gWhu+qy2B24Q8mAgNSeHvuNbejAWlXsq5u3kqQ9V3CXrKo+i/zoAfv9v3S92+u6u1Zo5uhEGrcdrrcg1o45XKI6CO+aALzwlg1zIsOQs34Mj9uQcNtD0YVVm3kfbiY+Tq1h0xeJ87wSZOvcJDEYiBtW6cZ+k85LKXhFFrkbG4sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CspOK5+8; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CspOK5+8" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ce98cb8165so1651015ad.1 for ; Thu, 20 Aug 2026 13:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787256305; x=1787861105; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=W+ttLV2jMb/uOUdRDGthE1WHXT4FvT3P7ffiAV7gUtI=; b=CspOK5+8rXyfrhCiSkiXDpyCsuBHQUUYtm7NREaRjf48p5mXd9uLLSVBLzWt8FhdhD BvnzmGQPVmFq306Hsl5npy8DBYOYjaDGv5QFOnbTLAfQ5SNcTr75xEbDurQBBN9pbd6W YQllygYUNyDq0gU3ia79PycvUh1QerCAbwF1JMM/h45ovXt8JMnacYRtJasKMV7CZX5A PjvDVoo0AyrQVRddbTO7t1cDHdtYx6eY8d8IEqQRB1nLbL4w6yNSbXl3LJGEV70t4EZ7 b8UZGipq+Yu8zxh4/f+J7xwa5Ttrgq+wkiNocoCHGNbsIwnBFWz3uOL8B93MmQJMfb35 Jycw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787256305; x=1787861105; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=W+ttLV2jMb/uOUdRDGthE1WHXT4FvT3P7ffiAV7gUtI=; b=SNEssThYwlzsbUvlXV2QWsaWoc0X+xnxSlGnp1CundsyT6NNUfn9J1BHsKffULl/bd x1MJos0ODJXikobuguCqJjJNqGRpNSajJMCQ+sKuI1vqILNydGRC4kYJK0XAli46l+Yb 4I1VxgKch6RYgJE/yl2JEW0S8QkkHqGk+pSOLEVCTbWJwI5loeftvvWfkSBqD9htSCTG yn4sRnMKip6mXwZfFrFBE776lDAr27obhqt6BpJIgy19N8p/VrDZGj/OBKzWY6JFb7Jw i8xmXtHyB89Qbcy5DVFBxGQHoxlNPP832J3fEaWu+OdsYWzkLOSprhl1c3+drUZuOEUe nCLw== X-Forwarded-Encrypted: i=1; AHgh+RoAPxkW6ne13SelN/XxDTedUmpXXBYrZ4I/WcqoT6yyScWNVqqDyOtHtY1W08iBSuDY8vSqTHVu8cP0plo=@vger.kernel.org X-Gm-Message-State: AFuF++k/T57CyOkGlXMxoPw5lBQghu7RX6V43fEfHV6DSe16gFwQv+oe progjohOFD0p3p+ZG0/enKkULMVDC124C+ZgT16xdOIi8KFjNxrjw9l5 X-Gm-Gg: AR+sD10Welhh77XacsisfmlBEDSX/srAtOkvzYPuGKTdlCccagkTftXT3UWQGvOTqJm r84FNmNi48xU7rv2l/tKusdftyYz6GcCvb/l4onXjMRssjwIzmxTlMtlQpiewaxkMRD01RhS8pe Pwa9IUcF8JAowbOUa0sROHysQrJWEseA6dgtKIceeU7ThE4TAcg1Ab4MvrMcMi6iTN9LcrZ5Fm5 fvzDf9N6yncZ74vxmLNtXxvwZJS/EIAx3vLDMc72TwVEdDIwUNMyOVvp9sUGjYe5XobOCmgCdfP JdrBRRntaBaVQtZiYPxzY2Kmb34QK3X30MHb5AXrw0D1nI13vc0+k3qd9SUW0k+DafxHiplDpxP +OJek0CK8z/artTqU9XBx7oGDwyaa2/ymYrsC8erW4277K2uGV56hrhNkBVRU6FrXbeMPP0eS9O wV9Lig0t8pG0yCx+RttPHtDCSLXxWNGHE3a0/4xnwat8QJnOMKrLWUP/zdcE81fNHylIb/czdT7 /DRZJMh X-Received: by 2002:a17:902:fc48:b0:2cf:7ea3:7cf1 with SMTP id d9443c01a7336-2d61a078e1amr118047715ad.5.1787256305116; Thu, 20 Aug 2026 13:05:05 -0700 (PDT) Received: from devvm16600.scu0.facebook.com ([2a03:2880:9ff:6b::]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf191821sm18740151eec.28.2026.08.20.13.05.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 13:05:04 -0700 (PDT) Date: Thu, 20 Aug 2026 13:05:01 -0700 From: Ziyang Men To: Tejun Heo Cc: Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Shuah Khan , kernel-team@meta.com, Ingo Molnar , Peter Zijlstra , Vincent Guittot , Ben Segall , Dietmar Eggemann , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Roman Gushchin , Shakeel Butt , JP Kobryn , bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] cgroup: add BPF kfuncs to read a cpu cgroup's stats Message-ID: References: <20260818002450.3071325-1-ziyang.meme@gmail.com> <20260818002450.3071325-2-ziyang.meme@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Hi Tejun, On Wed, Aug 19, 2026 at 10:55:59AM -1000, Tejun Heo wrote: >Hello, > >On Tue, Aug 18, 2026 at 04:59:17PM -0700, Ziyang Men wrote: >> > > The bpf_cgroup_base_stat() takes an rstat spinlock_t, which can sleep on >> > > PREEMPT_RT. >> > >> > Is this actually required? This doesn't really make sense to me. Shouldn't >> > what SLEEPABLE mean change on RT kernels instead? >> >> Oh sorry, I didn't notice that. >> >> I might be wrong: this function calls the cputime_adjust(), which in turn >> acquires raw_spin_lock_irqsave(), so there would be NMI deadlock in the >> perf_event program. The __css_rstat_lock() take the spin_lock_irq() as well. So >> maybe a SLEEPABLE tag is still necessary? > >I think this is for BPF folks to answer. I don't think SLEEPABLE is needed >because of RT but yeah it wouldn't be safe to be called from nmi context. Ok I see, let's remove the SLEEPABLE for now. Thanks, Ziyang > >Thanks. > >-- >tejun