From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22A0237F332 for ; Fri, 21 Aug 2026 06:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787295506; cv=none; b=ptF7vZWMTWu5tpSx6ZluCWmT+L6ALtqYxDzeBbYco7+pEVrW4smnxmfOxzYbZMyXBCfXv2ZB7acY/zAAY+W7er2pfsWc9waWiz+UGb3D1LFCMQYqS3+k78rE0XkJ+vgGTp6I2D8VOtcUtXQd+i3M8dkAfQSEWwHFcUVsW7Qwvp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787295506; c=relaxed/simple; bh=YWnqbBRFTqCa8CkD2PRlcyIBunfux/8atCCsfulqGWc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f328aYCeNmBlg5aTJyJ75uZv8bV1dJqLZ6SDY8jpHTfu0Y43YmuV60cQNub+QZmHor68JH3v5oYtPPU1Uf5Tt9/XI/4AbhgEazTZkGOVm3H8HyAT+8Ihw9Dhyo/StqI2d16AwA24p/cS3uTAVoom7EdugGZfa+zcpNMhWt5thso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Amrt/8/4; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Amrt/8/4" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-480033bdcf4so377112f8f.2 for ; Thu, 20 Aug 2026 23:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787295503; x=1787900303; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=tk01vz4OOXH1YMA2hJuMI+IKr5JVcaCgldOQQB4ILzU=; b=Amrt/8/4H+7YZD9tgd6Lv+2fvVWxsNWehx/sJAOymOoZ4iRDA6XyzG3erQmys54LM+ /gtqITi3e08Uwkdg9mrV6bK9uVXeQrnaMRzBdRCjE3NCbHn/7eToI/trcWsVdXsrq7eo sBwexIM4HHbaRtp/9IzOFZA8Y7eUqDOO/05zf/ev6/iWjHMIvaupifQV5SvXek2Q7odf SnQ0uoOgAsbzwiY4asoU3KJefGd2KvTrJB1I/SeudB5nPCeG56QYMBA8XpL9J0x9b6K9 q5mb6jmm5gySFM1pAcN0d/jtxIwZ/5EGZNylu4B8zokshMS5EKc7yv59CwKyplIg8xCZ e7Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787295503; x=1787900303; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tk01vz4OOXH1YMA2hJuMI+IKr5JVcaCgldOQQB4ILzU=; b=tIqVdG/Jal1KcKJ3ltPZu9c57IBvuyFB/Iy+pfKB9m2OKHqg34ZriWldFTFwPiY+sP /Y6Np/nAExc1eNYXU0N3wlmH1g/s3gItWGKBI7Xc9uxMW4Hod2V2gGmV1FYS5+dGGUcr F1luVtmN2kXm5BqqRX4WxTpJgK6k3D00p8+cDSb5UeXFIPpvjAMjDOJYALBDEoQejxxE rSgbRYPPmS4bcnq+k6QT9Ctc1pCs9sWI9N9jsbLgxViFqSxljbehPQ9f2fD0h/h+mzp8 pPVSvo9zK96+P+KeZ1IR7OotOKO5O44TFlhVY3WgqhEHVAtAN77GC88QwajV1FLs7Eo2 TR1g== X-Forwarded-Encrypted: i=1; AHgh+RrXO/SDUqXvC5s2mjf4tIQxpoL49B3iE1gjhSubsr0aa+R+Q3Wu9F6AI2e8BA5/Ue4A9bDzTOkSO1V97nk=@vger.kernel.org X-Gm-Message-State: AFuF++k2/IFMi89sbcpdckGVvWNe9cmmthnF5xN/Op/0IRCe3TTFkhmp ebAPpS03V9EB9aD85OwlwqlwbWpU1y04ruOWMojKu0NZm8C5Kmvb4bLx X-Gm-Gg: AR+sD11Os4hei1ihtmA7AOb8ri1Lvz228+g3E7bcDXEdOcXXHL3D8dpYLR2WXA0E04T OYgWYvbTDVzKPgCoLGBLJ5i/MziHhG1LciuPwPYrZW2KD95J0jDbQw2VCMl+pYqunGpLKW/PXRk wr7k3aqhfPVNL7Q8RcWEWegJQ0qMM6TtnU8oca2vUV4vUkJRMpzDo9OOZtSwbD94GMNsXjngCdp daaU5NgFLxncwPaSMzvGr6mWS3FkZM64BsCZYSrOSKOso0DCBxnhmXAZngRySuDxgUi8ACxMpwO AYfuc/EgX7f9MIWbvaL0kgK0Edbst/QiCHZ2ciiuaw/u8cvVTrN6WxNxp+PUoeBE1BV4chY2/a8 v5fcMEmY/viX9Aw0rJxZlYaBPIyXyuTPN6TysXPL2tL+Y5tnMeT/EPwXW4IPYyd51FzapRHBVhg 9Ni5jUgcFvjKBGhFthahX8AWkEioCVvVrh1xdS556mHsR7C+tWkJM5Y2PikwXLzy/EhD8= X-Received: by 2002:a05:6000:4717:b0:47f:7759:89df with SMTP id ffacd0b85a97d-482c0b4236fmr5996951f8f.3.1787295503207; Thu, 20 Aug 2026 23:58:23 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b145c9d7sm18172409f8f.15.2026.08.20.23.58.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 23:58:22 -0700 (PDT) Date: Fri, 21 Aug 2026 09:58:18 +0300 From: Dan Carpenter To: Tiago Panizio Gottardo Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] staging: octeon: fix style issues in ethernet.c Message-ID: References: <20260821041255.1616843-1-tiago.panizio@hotmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Aug 21, 2026 at 01:12:53AM -0300, Tiago Panizio Gottardo wrote: > Fix several coding style issues in ethernet.c, including line wrapping, > continuation alignment and function declaration formatting. > > No functional changes intended. > > Signed-off-by: Tiago Panizio Gottardo > --- 1. This patch does a bunch of things at once. Do, one thing per patch. 2. Some of things are weird. > static void cvm_oct_rx_refill_worker(struct work_struct *work) > { > struct octeon_ethernet_platform *plat = container_of(work, > - struct octeon_ethernet_platform, rx_refill_work.work); > + struct octeon_ethernet_platform, > + rx_refill_work.work); > /* regards, dan carpenter