From: Johannes Weiner <hannes@cmpxchg.org>
To: Enlin Mu <enlin.mu@linux.dev>
Cc: akpm@linux-foundation.org, kasong@tencent.com,
qi.zheng@linux.dev, shakeel.butt@linux.dev, baohua@kernel.org,
axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com,
david@kernel.org, mhocko@kernel.org, ljs@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
enlin.mu@unisoc.com
Subject: Re: [PATCH] mm/vmscan: fix comment logic in balance_pgdat
Date: Thu, 20 Aug 2026 23:41:30 -0400 [thread overview]
Message-ID: <aofI6uXxq4TD5QTS@cmpxchg.org> (raw)
In-Reply-To: <20260821005107.3416-1-enlin.mu@linux.dev>
On Fri, Aug 21, 2026 at 08:51:07AM +0800, Enlin Mu wrote:
> In balance_pgdat(), when the low watermark is met, processes sleeping on
> pfmemalloc_wait are woken up because they are able to safely make forward
> progress.
>
> However, the comment incorrectly states "they should not be able",
> which contradicts the actual code behavior. Fix this typo to accurately
> reflect the logic.
>
> No functional changes are introduced.
>
> Signed-off-by: Enlin Mu <enlin.mu@unisoc.com>
> Signed-off-by: Enlin Mu <enlin.mu@linux.dev>
> ---
> mm/vmscan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 35c3bb15ae96..822f73758c42 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -7188,7 +7188,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
>
> /*
> * If the low watermark is met there is no need for processes
> - * to be throttled on pfmemalloc_wait as they should not be
> + * to be throttled on pfmemalloc_wait as they should be
Pretty sure this was supposed to be "now" instead of "not". That would
make more sense than removing it, since this is about the watermark
check after kswapd has performed reclaim.
> * able to safely make forward progress. Wake them
> */
> if (waitqueue_active(&pgdat->pfmemalloc_wait) &&
prev parent reply other threads:[~2026-08-21 3:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 0:51 [PATCH] mm/vmscan: fix comment logic in balance_pgdat Enlin Mu
2026-08-21 3:41 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aofI6uXxq4TD5QTS@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=david@kernel.org \
--cc=enlin.mu@linux.dev \
--cc=enlin.mu@unisoc.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=qi.zheng@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox