From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8200F263F4A for ; Fri, 21 Aug 2026 09:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787304105; cv=none; b=WWpazroK9vzs6L1NBqePUQZDBqeesjao+KhvbC26rptwF5b5vGcogyEvTc61+ocsmu8SMe2ENRfg0t9n7aKKwI3/1Mz9ATg7iuSEpUAkaWAo9kFoCCdysOWi7SvpNPQ4tXG8J8wGkV+TxO5ClMqmkp3mvvyhM3th/VBFi6aSCOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787304105; c=relaxed/simple; bh=uunfijC6rTzppRQRQ1x9Ga0ozQnwCEPdHun9k3ww++E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fuzINPn0FoU4NiS67rEEV+NiT1YDzr6R/iylyu3NB4Gvrfy0/bjbqik+tbnjKOF24OCWEFusHWPfQqFLWShAAxf4tZtxtaPiS7iw6CDeMUi89Kjk7+mTX67/NVt15kyRZsf2j7U3sS93schyq3gV80Wygqqs7N5mU14X2Lgv2wg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CL9hMaRn; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CL9hMaRn" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-c2055f5a993so90812266b.2 for ; Fri, 21 Aug 2026 02:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787304093; x=1787908893; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6n6jOb/zWKy+uFuqnOpxvnr4nj6Kewh54Ypx9tbGovo=; b=CL9hMaRno0uj0RFNeHfFo7dF/xIl0U4F9N57i3TTcYAUfGbIs/6hTmzQqL4itIwYfs yhANdNqS/yfPWXZI7xft4003E1UaBk+pLUAvZAC4Ar1fCyYBVkulYyvuelhzp9ww/T4l JvpAb1/JHksLkUgDRx4YMyTHZEsAS/c+RbjGNjDXGyi1vSi0UgQOuK261yPYf4r5X1iT 1JtJOWk4oMe9lEUSm97gUekC1zswc18wxBwH8ceKLp/7yGEWTKa3qlg4WhOHeWu/sbjR DalThdRQXVWCZyiDrFwnEe97h4IVRLh71mg5PswCt7epmT06LrsyYb9OhmrDtr39EleF Y1YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787304093; x=1787908893; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6n6jOb/zWKy+uFuqnOpxvnr4nj6Kewh54Ypx9tbGovo=; b=Q9nqShIHvJTtZy2giywo7wcpvPT6kpWeBuHX+PDqDpWmujtzjond6BVSUlu+lyRthv aEWR3987PljI4kBAdKYLrt+jMd9RnymLNJ4W7yZZBRSNpsPU2CwTrjuJ0dHJ0Mk6U6PF r8rfkh+PMLfJucySXb53DDbVecAlwrs1alWHqE4RoNMHNuhMX4EhnWaWf8TrSqCyBQuG Za5/TFXKjsUXHFglhoQKTW/yf89S/9LGrx36Ke5pM2bWIAq9Y2NPQgv16DL3GPCgDRRv Dttn0lwXoyLhwP02OwsuLzlt5LgEl2fRe9vkc1JRaJvUISJW0KSB1fmBo/kUN+IwsdXa bqiQ== X-Forwarded-Encrypted: i=1; AHgh+RqBXmI3D58onVhl41L2hYP0Xc9EUthc4727pWjb4kMNGupQf6dyvO9WSn/5+Kfr1oKjkTnshQv/6L82ims=@vger.kernel.org X-Gm-Message-State: AFuF++mLwKD5j4KUXXGp8FU1+SDL8FzEvABzJo/ci6067mlXbkgozU0d 0FP6a3T5TxffiLmy/nSwDm4HEf4aMhw3BZ5TQMy6Pb2QRZ9yomvqOrHgaITHuXaSLxM= X-Gm-Gg: AR+sD10gdEiER5T4n9y0BCeLj+imJxWOWNzwjUI5euolnPsuAE99ORtmdIp+Kp9RVVM fNuxFuYJPalqq34mdfgf2eBmJCMkMPC8jYohNirA021xdFg6R4nJ/WUb2GGtZ35s7sUpOF5aX39 G+Di823PjAgRIchtLcCFNiLs+Xi7U80Mnx/IgN/1EMYaWx4mnIwiSowW4fToKezn+DoxUnte+AE o5G5T7hETBZgNTTe2c+CpYMWhvIDIm0deLsPQtbhVFg+6R1K2xgOct3Bz3UiGhs1YJNi2+RahLp QPv0pyCd+qe89onlG2/dCL5pUt/nJK+02VU5N3IEexfMhBoHAtsF3ieQm06p4vvBc1/KsTDWvOj rOcdseujgdS3Ge+brfijbdzxdfnO/P9hRXkiX7jllhV3pwxYruifJ87pd14PhpzKw0zMYhKN+1J 0CpTZ6PyRwNETR7L2+OTsdM8ivi/Jb3Da6jCk7ppA7ILQKHyvg4q7YD3PItOSEGyZmKTBjReh9F w== X-Received: by 2002:a17:907:3d56:b0:c1f:e9d6:2a6f with SMTP id a640c23a62f3a-c2469f9991dmr528416666b.0.1787304093460; Fri, 21 Aug 2026 02:21:33 -0700 (PDT) Received: from localhost (109-81-81-112.rct.o2.cz. [109.81.81.112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2459223af1sm385166566b.58.2026.08.21.02.21.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 02:21:33 -0700 (PDT) Date: Fri, 21 Aug 2026 11:21:31 +0200 From: Michal Hocko To: "Lorenzo Stoakes (ARM)" Cc: Ridong Chen , Andrew Morton , Johannes Weiner , David Hildenbrand , Qi Zheng , Shakeel Butt , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen , Roman Gushchin Subject: Re: [RFC PATCH 0/4] mm/vmscan: honour node reclaim limits per type Message-ID: References: <20260821081741.1340277-1-ridong.chen@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri 21-08-26 09:58:52, Lorenzo Stoakes (ARM) wrote: > +cc Roman for suggestion. > > On Fri, Aug 21, 2026 at 10:31:06AM +0200, Michal Hocko wrote: > > You are explaining what but missing the most important part _Why_ do we > > need to have this addressed? Is this just addressing Sashiko review > > refernced below? Is there any real usecase where the current behavior > > matters? > > This is exactly the issue with these 'unrelated to your patch but' suggestions > from sashiko. > > You end up in loops: > > AI generated patch ---------------> AI generated review > ^ | > | | > | v > AI generated 'unrelated to your patch but' > > And _at every stage_ reviewers have to do _additional work_ (with ~50% signal/noise). > > This isn't sustainable. > > We already had _too much work_ prior to the slopgeddon. Now we have a multiple > of that. > > Roman - I really think we a way of switching off the 'unrelated to your patch > but' stuff per-subsystem would be useful. > > Maybe we could figure out a way of funnelling this stuff somewhere separately > longer term. > > (I have I think 2 slopped fixes to rewrite after the previous what like 7 or 8 > this cycle? So forgive the grumpiness :) I wouldn't blame Sashiko on this really. Yes it points to a theoretical problem. That is fine. But we should encourage people to not blindly follow that lead and immediately jump at fixing something that is not a real problem. Quite honestly I even haven't looked into patches until it is clear that the usecase is sound. We should enforce this more and leave patches lingering if they are not sufficiently justified. -- Michal Hocko SUSE Labs