From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0381B3AFCE2 for ; Fri, 21 Aug 2026 10:36:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787308621; cv=none; b=qhhu8gDcU3+N+H3+el+i9Ty1Vu1CWtCNbAY4dL2k0t7UfLv0Ugx2BQJl1AsJbUsMjYMskO2zv3ttnlAZLTKmZbWlH4P/weQaxH/C2+3OdlKDCNWtq2Y5qelkWThideJw3NyQqnrLEke3lr1gFKirGqqwE8cMtVTHpY51dyqx6wg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787308621; c=relaxed/simple; bh=b8OrTdm7l/bHAh1BFCbvKBBAJlt33YXBsSrQAG+/eqc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FlHny8onPqNSePfxy7LMbpXPxUoigjBAgD4hdshVyEM/4O85D3b4c4bMAmJkZCEddDeQrCo+Go/BOnck2YBSwplxtvhiGczlsw7tUVudEHU0sBVWnDKb13Qpp/Hd6DYZNg+vBR9L4OFaVD6DYHOy1To7vXweUQvnbGG3gjhqHhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pzhr/cUG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iuFh0/aH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pzhr/cUG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iuFh0/aH" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67L9M3O32006429 for ; Fri, 21 Aug 2026 10:36:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= x+/TUZQqtWMcSQBmELloooyymV8cy7fWHjTFq4Y7vHE=; b=Pzhr/cUGL+CVVoi5 TXT7wCB/F87yxsygEFZGnZ+L8TceExE8cotOWyNTADW9Hfx2MZwqBjnu39ZpX3bt A0L+aBkuaxLYyBpssKHDwyG6d2I1qK4ttWGlm71bcB6vdQWBJJsAj+GNgATVsPHw l27BGzDJAtq+/rR/oNyO/nTvFvjjARru6PKbKZgw6WqofUKQcr2x/Ud8ZRzIaaaX qhHcS+UziN8jfZMncmKEViL/li2ZUvD1U/lliPEAhUoUGIAF+9r0OCY4Nub28eaG fqDZzekn6WLUt8amT9bMV72I/xUF4yL8v+XL7HdkHWISQuCN0sgb7Hwjn/r1rOrb +wmJqw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g6gddh4n1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Aug 2026 10:36:49 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cb835525b10so1138957a12.2 for ; Fri, 21 Aug 2026 03:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787308609; x=1787913409; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=x+/TUZQqtWMcSQBmELloooyymV8cy7fWHjTFq4Y7vHE=; b=iuFh0/aHCH/VZis1rWWq5lCBryXfKnHDlSNkBa7UXBtlqYjhicTB0ZCibCkCl0Sw00 CV5HKwyXrbNNmGB63zOTkAuIwJI1haY+hOkQoyP9BWPfhaDbRHQXNWomX7LLTYJTawfi fkLp35+QrmIxkJhpj1SknpPFQ10w0ALy6bJwxA4BayNqgDOPQm1CAWxhuuH13u47hHBD ZyprxPYLDAlgkdlPe5rCGSt3AW5HrFuvbSsxAtmiDcWjaoh7vbI5PyyrHIiFdOgRhxjU jAyVdnNgbXNHoHev4Jig1Cel++b50dLypfGoO/v2jqr76YnGhmMvllRW0R90S2yx2wTN G/kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787308609; x=1787913409; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=x+/TUZQqtWMcSQBmELloooyymV8cy7fWHjTFq4Y7vHE=; b=CpjfDFfK93rzj3YMIL0gUWe9cj1+O6e7+TyYXnSZGtLUInYBeGeXzkmbFxbsXMh2R5 oX1Jvio6jsxi8rpDQoEa1ocQJohUJK3L794DUTyajn8bGxwlxSsU56HRcTFWDpJNSM4w XQ3Cp/o87FjkYOTaXOwhX1UwjrpX0dQ99608gKUz1VQWhandUfCCfcVyR8geyJbUvNVJ yNFu46w1yO6YsbPl/gAQGK497LT5dmnHVCASTDtMbCztyMGUB97eMQ16kj5TN2pwIaEv ON6Y0DM1gNEnAIzJr9P6zu9Wx2oE+OCP2uVCG/8wkFqurs2PUAl7hMMEy7uBZV6dy/85 s/Nw== X-Forwarded-Encrypted: i=1; AHgh+RpLP+tBIBKG5iukGwIGnDp2SgNX93ztrXTa4jK3ItxP/QxEh2CJ1G70TEeIBz3pQYoKmoImuWstW0fMess=@vger.kernel.org X-Gm-Message-State: AFuF++mL0MuIJL0/CNEzhyZUbY+NHj5UmoubvkxZaWD+naL9ET8Pc9G3 BsaSiDveEPqdPckVS2RUtodOWU+0y7f0iXlbmwF2uNSgr1UlVPQQGgRwJufXMfHSpzZkWUd2H1m TNSz91HjLNeVWoEWGG6//70X2qrWXqOk2G3RkgrBJN7wTUbq9iD40l6KdaBFv2y0+PlM= X-Gm-Gg: AR+sD10M2h3XrdBy0glyK6vQgRLNXTMDnZHIWi7kdBEf2MQtX+3uhbzZoUBXNgAsZTS SFr4BeAGljgbGxU5YK7Ej4Q86h2dhNHsaFauHCKm7fQws9iloDt/pkIDxsvLpAgr3u66f6XavwS UN8ozyCK/joxwdfjr3ahkbO5557UnWPXBZxPcQqPTQR7kN710bwqBS3/ErHKiNSbW6Y6vjkmm1f T0YqFv/HqTHKWIZ249/UdqSVu41nuMTueqkhbbqEJrj7022C+170KFCKXLGTjispEyojcCu20MB 0MN3Qyd5Jbl14VfVQZqbcF0PTbVbe4xSxtDf7NyTED/BgLuDmT9zLeMuQOgp/bKX9OpDamlQz4V Ti1eEnaliSF+4uLc3eH9zioHNU80He8HwZRAaZQ== X-Received: by 2002:a17:90b:394b:b0:381:9028:5945 with SMTP id 98e67ed59e1d1-395c384d95bmr10132144a91.14.1787308608492; Fri, 21 Aug 2026 03:36:48 -0700 (PDT) X-Received: by 2002:a17:90b:394b:b0:381:9028:5945 with SMTP id 98e67ed59e1d1-395c384d95bmr10132085a91.14.1787308608069; Fri, 21 Aug 2026 03:36:48 -0700 (PDT) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c467d907sm2662874a91.7.2026.08.21.03.36.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 03:36:47 -0700 (PDT) Date: Fri, 21 Aug 2026 16:06:39 +0530 From: Abhinaba Rakshit To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Adrian Hunter , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neeraj Soni , Harshal Dev , Kuldeep Singh , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v11 5/6] arm64: dts: qcom: monaco: Add OPP-table for ICE UFS and ICE eMMC nodes Message-ID: References: <20260609-enable-ice-clock-scaling-v11-0-1cebc8b3275b@oss.qualcomm.com> <20260609-enable-ice-clock-scaling-v11-5-1cebc8b3275b@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Proofpoint-Spam-Info: AW1haW4tMjYwODIxMDA3OSBTYWx0ZWRfX5iCIy313NGVy NO+d1VxiIsDI4/Fy0hxvCYhnHAY1kZYOFKEGlRxe3yjPTSfJK/1MY86+nf/PJLVQTIzOQh26nO6 H19VuJEt30dWraK+nGXLoPeD2ekWGo0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIxMDA3OSBTYWx0ZWRfX6lCc0qlB/2aB OCKYHo8DpM3EKv7/Ui9imSAmG09Y3K4WVLkSzUkQMqRvubQK5+4mg+EdSXrY3uP5cxmxGrsgEDF gTCfcOz7lSbgo0Q/dumYPwCHFwVmR7fA+mWA7fOxkE1dAwo43UnGpWrKaxtwp/kbb7WUd7hYDJS T6kTFEP/JrFU/3M4DiL1tpvBMT3YYl2ysVBslztfLndDnQJjDM2Fx7bo1f/Zmp4F8Oq80C5ZUWk 34/D1xrzgMpwjMxIm5RizV5CS96H67TdEa1U9X2cq4kG59/+OVCluATvWF2vvJKmiqJXv7jzs3x 5T47KMKdbtSV0FmM4adWldd6ZIX2aU116mPFuFiuIcl4/60exDsoIQjCqCi+J25SEiBdvmRLbbU rwG+Rnl08Hy7BmricJ4Ji2ZjK7lF98+xMDwmAPBB8OuRqKjg4idsfwad7KhoXhFgNvS9TwCFM/b YLWxOdH1aM0Nkf1DZLQ== X-Authority-Analysis: v=2.4 cv=ApHeGu9P c=1 sm=1 tr=0 ts=6a882a41 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=jk3V8XEzhubCWnqVx50A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-GUID: LGjXdv6yXZJ8AGcCgskBwI_rLIe9njf0 X-Proofpoint-ORIG-GUID: LGjXdv6yXZJ8AGcCgskBwI_rLIe9njf0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-21_03,2026-08-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608210079 On Fri, Jun 26, 2026 at 04:28:54PM +0200, Konrad Dybcio wrote: > On 6/22/26 9:38 AM, Abhinaba Rakshit wrote: > > On Thu, Jun 18, 2026 at 03:04:57PM +0200, Konrad Dybcio wrote: > >> On 6/8/26 11:47 PM, Abhinaba Rakshit wrote: > >>> Qualcomm Inline Crypto Engine (ICE) platform driver now, supports > >>> an optional OPP-table. > >>> > >>> Add OPP-table for ICE UFS and ICE eMMC device nodes for Monaco > >>> platform. > >>> > >>> Signed-off-by: Abhinaba Rakshit > >>> --- > >>> arch/arm64/boot/dts/qcom/monaco.dtsi | 37 ++++++++++++++++++++++++++++++++++++ > >>> 1 file changed, 37 insertions(+) > >>> > >>> diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi > >>> index a1b6e6211b84d0d5008231c55613a0ccd61b9450..d9298d8b7874b8669b2cded2a28a99dce6eadbda 100644 > >>> --- a/arch/arm64/boot/dts/qcom/monaco.dtsi > >>> +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi > >>> @@ -2742,6 +2742,27 @@ ice: crypto@1d88000 { > >>> clock-names = "core", > >>> "iface"; > >>> power-domains = <&gcc GCC_UFS_PHY_GDSC>; > >>> + > >>> + operating-points-v2 = <&ice_opp_table>; > >>> + > >>> + ice_opp_table: opp-table { > >>> + compatible = "operating-points-v2"; > >>> + > >>> + opp-75000000 { > >>> + opp-hz = /bits/ 64 <75000000>; > >>> + required-opps = <&rpmhpd_opp_svs_l1>; > >>> + }; > >>> + > >>> + opp-201600000 { > >>> + opp-hz = /bits/ 64 <201600000>; > >>> + required-opps = <&rpmhpd_opp_svs_l1>; > >>> + }; > >> > >> Since 75 MHz and 201.6 Mhz require the same power level, is the former > >> OPP any useful? > > > > Yes, both use the same power requirements. However recommended by the ICE team, > > the DT should include all opp/freq supported by the hardware. > > Is there any reason at all where the OS would prefer the lower OPP? > > I think you at one point mentioned some dependency vs the storage > controller's clock frequency > Monaco UFS controller supports a 75 MHz clock rate at the same power level, as specified in the hardware description. Although both frequencies (75 and 201.6MHz) use the same power domain (OPP), retaining the 75 MHz ICE OPP allows the ICE clock to align with the UFS controller’s clock frequency. This synchronization is required for the controller’s supported operating modes and can help avoid unnecessary frequency mismatches. Abhinaba Rakshit