From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50CF7375ADE; Fri, 21 Aug 2026 16:01:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787328108; cv=none; b=dw612TDW00himblHb5vZeA+pSiuhZpe1rRjtsC76ejuqv1nodMISE2hJCiKlMZqnIgebHwDNCEQQRliwxHSRkR1Emh0jjahzSbdbejvk6vns6Sy3xtd4gLpMBSrzVE/dvnuld+hM1xgw4nFxWMueDLvnB9+ZlSRMpuSbOFbNulg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787328108; c=relaxed/simple; bh=wemf2gE1hMWZpseJAaIDabprgBcaAwrypXd9wmjRVu4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LErQhHNWrsxJpRoam/1WpK2DGtcL4CFW3FqkPFjJ7cDBLiWzTG3ID3i6XhoSCoVCN2EDCDUo79hnNtfUZYxjRwlJ6V3OGSC8yxOPt4E/JcVSUJ9VMswfeWsbLuBIq/4C3IzGlIlvOrOqIUIHCKoQzOqMOH7XIql8EwKLvZRjudo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ill+UuXF; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ill+UuXF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787328108; x=1818864108; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wemf2gE1hMWZpseJAaIDabprgBcaAwrypXd9wmjRVu4=; b=Ill+UuXFSI0+RxBeWCUc0f9zuRpKYUsqH5GJw59RhdN6TNLNCPsEPJYj u4vyKyk9JYxmoMvGKlA16GFBZgP6nv/c0IQwA2LBbXLfYKoTBrL/Oj2kf 5J/zA1CeJ+9d5bJHUOOvAAuwaKNrlC/jRMeQPC9Vtk91QJQg8rKy3jJov CHqWHcQkBKc/CEZ46aCnWu4P5usICyUrtqI7kMTSd8JGzSYrEicNdxhRC ShT5yWG8Ia/+Lxs+xVWwGp55H06BOryB8wuAfZ8SbD7s0kzWF+MM5Vd4B dR1ZcEvYRJNCY/q6ED9n+9rLg2hiz1E+xXX+m9Gjg+UaE/cvKcGVhI2QO g==; X-CSE-ConnectionGUID: 6Nf3WyDiQSmwoYh917yUmA== X-CSE-MsgGUID: hGZYWUNYTVa5b0714eXrDw== X-IronPort-AV: E=McAfee;i="6800,10657,11882"; a="91754586" X-IronPort-AV: E=Sophos;i="6.25,235,1779174000"; d="scan'208";a="91754586" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2026 09:01:31 -0700 X-CSE-ConnectionGUID: svu2B3YeRaCL420nD9FP5w== X-CSE-MsgGUID: 4cfsBc4yQv6vVinIoG4vtw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,235,1779174000"; d="scan'208";a="266979842" Received: from abityuts-desk1.ger.corp.intel.com (HELO localhost) ([10.245.245.241]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2026 09:01:27 -0700 Date: Fri, 21 Aug 2026 19:01:25 +0300 From: Andy Shevchenko To: Triet Hoang Cc: andy@kernel.org, bleung@chromium.org, chrome-platform@lists.linux.dev, dlechner@baylibre.com, groeck@chromium.org, jic23@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, nuno.sa@analog.com Subject: Re: [PATCH] iio: cros_ec: Convert to DEFINE_SIMPLE_DEV_PM_OPS() Message-ID: References: <20260821140451.3969-1-triet.hoang.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260821140451.3969-1-triet.hoang.dev@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Fri, Aug 21, 2026 at 02:04:50PM +0000, Triet Hoang wrote: > On Fri, 21 Aug 2026 16:37:18 +0300, Andy Shevchenko wrote: > > There is a macro that combines DEFINE + EXPORT. > > Thanks for reviewing. Should I send the v2 with the update? v2 should incorporate the requested changes. > > There is room on the lines to make them longer a bit. > > > > Convert the deprecated SIMPLE_DEV_PM_OPS to DEFINE_SIMPLE_DEV_PM_OPS > > and pm_sleep_ptr(). > > > > This lets us drop the __maybe_unused annotations from the resume callbacks, > > and reduces kernel size in case CONFIG_PM or CONFIG_PM_SLEEP is disabled. > > With the new commit that you have suggested. It should be a new version of the same change, but with the comments being addressed. -- With Best Regards, Andy Shevchenko