From: "Henning P. Schmiedehausen" <hps@intermeta.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Add extended attributes to ext2/3
Date: Wed, 16 Oct 2002 09:38:02 +0000 (UTC) [thread overview]
Message-ID: <aojc1q$l37$1@forge.intermeta.de> (raw)
In-Reply-To: E181a3S-0006Nq-00@snap.thunk.org
tytso@mit.edu writes:
>+ int ea_blocks = EXT3_I(inode)->i_file_acl ?
>+ (inode->i_sb->s_blocksize >> 9) : 0;
Sometimes I wonder if we shouldn't have the block size (512) and the
bit shift (9) as defines somewhere and gradually shift away from hard
coded values...
If we ever decide to change the block size of ext2/ext3, we're in for
a "looking for nines"... :-)
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen -- Geschaeftsfuehrer
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH hps@intermeta.de
Am Schwabachgrund 22 Fon.: 09131 / 50654-0 info@intermeta.de
D-91054 Buckenhof Fax.: 09131 / 50654-20
next prev parent reply other threads:[~2002-10-16 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-15 22:20 [PATCH 2/3] Add extended attributes to ext2/3 tytso
2002-10-16 9:38 ` Henning P. Schmiedehausen [this message]
2002-10-16 16:16 ` Theodore Ts'o
2002-10-16 17:05 ` Andreas Dilger
2002-10-16 19:30 ` Theodore Ts'o
2002-10-19 18:36 ` Jan Kara
2002-10-16 17:50 ` Lorenzo Allegrucci
2002-10-16 18:32 ` Andreas Dilger
[not found] ` <200210161336.27935.agruen@suse.de>
[not found] ` <3DAD8D5E.31E177BA@digeo.com>
2002-10-16 20:32 ` [PATCH] linux-2.5.43-mm1: Further xattr/acl cleanups Andreas Gruenbacher
2002-10-16 21:15 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aojc1q$l37$1@forge.intermeta.de' \
--to=hps@intermeta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox