The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: "Rex Lu (盧建銘)" <Rex.Lu@mediatek.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Shiji Yang <yangshiji66@outlook.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Felix Fietkau <nbd@nbd.name>, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>
Subject: Re: 回覆: [PATCH] net: ethernet: mtk_wed: increase WED v2 WDMA RESV_BUFF to 0x80
Date: Mon, 24 Aug 2026 11:05:10 +0200	[thread overview]
Message-ID: <aowJRvfl2E0oYK3k@lore-desk> (raw)
In-Reply-To: <SI2PR03MB55456905E3D6E84E2337F6ADF3A02@SI2PR03MB5545.apcprd03.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

> Hi Lorenzo,
> 
>     it is only for v2.  v3 changed the hw design and fixed it.  so this RESV_BUFF register was removed  

Hi Rex,

thx for pointing this out. In this case:

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> 
> Thanks
> Rex Lu
> ________________________________________
> 寄件者: Lorenzo Bianconi
> 已傳送: 星期一, 2026 年 8 月 24 日  下午 03:48
> 收件者: Jakub Kicinski
> 副本: Shiji Yang; netdev@vger.kernel.org; Rex Lu (盧建銘); Felix Fietkau; Andrew Lunn; David S. Miller; Eric Dumazet; Paolo Abeni; Matthias Brugger; AngeloGioacchino Del Regno; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-mediatek@lists.infradead.org
> 主旨: Re: [PATCH] net: ethernet: mtk_wed: increase WED v2 WDMA RESV_BUFF to 0x80
> 
> > On Aug 21, Jakub Kicinski wrote:
> > > On Wed, 19 Aug 2026 21:07:07 +0800 Shiji Yang wrote:
> > > > Change WDMA RESV_BUFF from 0x40 to 0x80 to avoid CDM TX FIFO overflow.
> > > > Without this patch mt7986 and mt7981 may have WDMA TX hang issue. This
> > > > patch was pulled from mtk-openwrt-feeds GPL open source project.
> > >
> > > Lorenzo, could you TAL? (incl. Simon's suggestion of the Fixes tag)
> 
> I am wondering if this is necessary for v3 as well.
> @Rex any input on it?
> 
> Regarding Fixes tag, I think cf26df8833cc is the right one.
> 
> Regards,
> Lorenzo
> 
> >
> > sure, I am AFK now, I will review it next week.
> >
> > Regards,
> > Lorenzo
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-08-24  9:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 13:07 [PATCH] net: ethernet: mtk_wed: increase WED v2 WDMA RESV_BUFF to 0x80 Shiji Yang
2026-08-21 10:54 ` Simon Horman
2026-08-22  0:41 ` Jakub Kicinski
2026-08-22  8:52   ` Lorenzo Bianconi
2026-08-24  7:48     ` Lorenzo Bianconi
2026-08-24  8:00       ` 回覆: " Rex Lu (盧建銘)
2026-08-24  9:05         ` Lorenzo Bianconi [this message]
2026-08-24 18:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aowJRvfl2E0oYK3k@lore-desk \
    --to=lorenzo@kernel.org \
    --cc=Rex.Lu@mediatek.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yangshiji66@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox