From: Andrea Righi <arighi@nvidia.com>
To: Tao Cui <cui.tao@linux.dev>
Cc: tj@kernel.org, void@manifault.com, changwoo@igalia.com,
suzhidao@xiaomi.com, sched-ext@lists.linux.dev,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
Tao Cui <cuitao@kylinos.cn>
Subject: Re: [PATCH v4] docs/sched_ext: document that cgroup CPU knobs are scheduler-dependent
Date: Mon, 24 Aug 2026 15:49:18 +0200 [thread overview]
Message-ID: <aoxL3gADCc0X47Go@gpd4> (raw)
In-Reply-To: <20260824132116.560347-1-cui.tao@linux.dev>
On Mon, Aug 24, 2026 at 09:21:16PM +0800, Tao Cui wrote:
> From: Tao Cui <cuitao@kylinos.cn>
>
> The scheduler core communicates the initial cpu controller settings
> to the BPF scheduler through ops.cgroup_init() and reports subsequent
> changes through the corresponding ops.cgroup_set_*() callbacks.
> Whether and how a knob takes effect is up to the loaded scheduler:
> it may implement the corresponding callback partially or not at all,
> so cpu.max, cpu.weight and friends can silently have no effect.
>
> Document this in the basics section of sched-ext.rst.
>
> Signed-off-by: Tao Cui <cuitao@kylinos.cn>
Looks good to me now.
Reviewed-by: Andrea Righi <arighi@nvidia.com>
Thanks,
-Andrea
> ---
> v3 -> v4: Rephrase per Andrea's suggestion: mention ops.cgroup_init()
> for the initial values, ops.cgroup_set_*() only for subsequent
> changes, and disambiguate per-task nice (ops.set_weight()) from
> cpu.weight.nice.
>
> v3: https://lore.kernel.org/r/20260824091501.547649-1-cui.tao@linux.dev
>
> Documentation/scheduler/sched-ext.rst | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/scheduler/sched-ext.rst b/Documentation/scheduler/sched-ext.rst
> index 35b550671ca7..794ae80b3ba3 100644
> --- a/Documentation/scheduler/sched-ext.rst
> +++ b/Documentation/scheduler/sched-ext.rst
> @@ -242,6 +242,21 @@ optional. The following modified excerpt is from
> .name = "simple",
> };
>
> +Scheduler-Dependent Knobs
> +-------------------------
> +
> +The fair-class scheduler enforces CPU controller settings such as
> +``cpu.max``, ``cpu.weight`` and ``cpu.idle``. For sched_ext tasks, the
> +scheduler core communicates these settings to the BPF scheduler
> +through ``ops.cgroup_init()`` and reports subsequent changes through
> +the corresponding ``ops.cgroup_set_*()`` callbacks. Similarly, per-task
> +nice changes are converted to weights and reported through
> +``ops.set_weight()``.
> +
> +Each BPF scheduler is responsible for implementing the scheduling
> +semantics of these settings and may choose to ignore them. Consult the
> +loaded scheduler's documentation before relying on these controls.
> +
> Dispatch Queues
> ---------------
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-08-24 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 13:21 [PATCH v4] docs/sched_ext: document that cgroup CPU knobs are scheduler-dependent Tao Cui
2026-08-24 13:49 ` Andrea Righi [this message]
2026-08-24 17:28 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoxL3gADCc0X47Go@gpd4 \
--to=arighi@nvidia.com \
--cc=bpf@vger.kernel.org \
--cc=changwoo@igalia.com \
--cc=cui.tao@linux.dev \
--cc=cuitao@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=suzhidao@xiaomi.com \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox