From: "Henning P. Schmiedehausen" <hps@intermeta.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2.4.20-rc1] compiler fix drivers/ide/pdc202xx.c
Date: Mon, 11 Nov 2002 23:14:45 +0000 (UTC) [thread overview]
Message-ID: <aqpdl5$kt6$1@forge.intermeta.de> (raw)
In-Reply-To: 200211111502.gABF2ajg031284@pincoya.inf.utfsm.cl
Horst von Brand <vonbrand@inf.utfsm.cl> writes:
>"Henning P. Schmiedehausen" <hps@intermeta.de> said:
>> Daniel Mehrmann <daniel.mehrmann@gmx.de> writes:
>>
>> >Hello Marcelo,
>>
>> >i fix a compiler warning from pdc202xx.c.
>> >The "default:" value in the switch was empty. Gcc don`t like
>> >this. We don`t need this one.
>>
>> Correct solution is not to remove the "default:" but to add a "break;"
>So people start wondering if somehow the content of the default case got
>deleted by mistake? Better not. Plus it is needless (source) code bloat.
So comment it:
default:
break; /* Does nothing */
A switch without a default case is simply asking for trouble in the
long run.
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen -- Geschaeftsfuehrer
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH hps@intermeta.de
Am Schwabachgrund 22 Fon.: 09131 / 50654-0 info@intermeta.de
D-91054 Buckenhof Fax.: 09131 / 50654-20
prev parent reply other threads:[~2002-11-11 23:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-10 21:11 [PATCH] [2.4.20-rc1] compiler fix drivers/ide/pdc202xx.c Daniel Mehrmann
2002-11-11 11:49 ` Henning P. Schmiedehausen
2002-11-11 15:02 ` Horst von Brand
2002-11-11 23:14 ` Henning P. Schmiedehausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aqpdl5$kt6$1@forge.intermeta.de' \
--to=hps@intermeta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox