From: torvalds@transmeta.com (Linus Torvalds)
To: linux-kernel@vger.kernel.org
Subject: Re: PTRACE_GET_THREAD_AREA
Date: Fri, 20 Dec 2002 17:42:36 +0000 (UTC) [thread overview]
Message-ID: <atvkqc$6kr$1@penguin.transmeta.com> (raw)
In-Reply-To: 200212200832.gBK8Wfg29816@magilla.sf.frob.com
In article <200212200832.gBK8Wfg29816@magilla.sf.frob.com>,
Roland McGrath <roland@redhat.com> wrote:
>This patch vs 2.5.51 (should apply fine to 2.5.52) adds two new ptrace
>requests for i386, PTRACE_GET_THREAD_AREA and PTRACE_SET_THREAD_AREA.
>These let another process using ptrace do the equivalent of performing
>get_thread_area and set_thread_area system calls for another thread.
Looks fine, except I'd ask you to split up the get/set logic as separate
functions, instead of making that case-statement thing horribly big.
Big functions are bad.
So please make it look something like
case PTRACE_GET_THREAD_AREA:
ret = ptrace_get_area(addr, (struct user_desc *) data);
break;
case PTRACE_SET_THREAD_AREA:
ret = ptrace_set_area(addr, (struct user_desc *) data);
break;
instead, ok?
Linus
next prev parent reply other threads:[~2002-12-20 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-20 8:32 PTRACE_GET_THREAD_AREA Roland McGrath
2002-12-20 10:24 ` PTRACE_GET_THREAD_AREA Christoph Hellwig
2002-12-20 15:44 ` PTRACE_GET_THREAD_AREA Daniel Jacobowitz
2002-12-20 17:36 ` PTRACE_GET_THREAD_AREA Linus Torvalds
2002-12-20 15:48 ` PTRACE_GET_THREAD_AREA Daniel Jacobowitz
2002-12-20 15:55 ` PTRACE_GET_THREAD_AREA Jakub Jelinek
2002-12-20 16:08 ` PTRACE_GET_THREAD_AREA Daniel Jacobowitz
2002-12-20 21:27 ` PTRACE_GET_THREAD_AREA Roland McGrath
2002-12-20 17:42 ` Linus Torvalds [this message]
2003-01-13 3:51 ` PTRACE_GET_THREAD_AREA Roland McGrath
2003-01-13 4:03 ` PTRACE_GET_THREAD_AREA Linus Torvalds
2003-01-13 5:29 ` PTRACE_GET_THREAD_AREA Roland McGrath
[not found] <3E22B2F0.31397.E719685@localhost>
2003-01-14 3:15 ` PTRACE_GET_THREAD_AREA Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='atvkqc$6kr$1@penguin.transmeta.com' \
--to=torvalds@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox