From: James Lamanna <jamesl@appliedminds.com>
To: linux-kernel@vger.kernel.org
Subject: Remove Phidget Blacklist if kernel driver is not selected
Date: Sun, 29 Aug 2004 15:21:06 -0700 [thread overview]
Message-ID: <auto-000000530333@appliedminds.com> (raw)
This patch (compile-tested not runtime tested yet)
is to remove the blacklisting of Phidgets
if the PhidgetServo kernel driver is not included
in the kernel.
(Right now it gets rid of all Phidget Blacklists, as more
drivers are added I would expect they would be per-driver
segmented).
It gets quite annoying to have to patch recent kernels
everytime to use userspace tools (libhid + libphidgets)
as opposed to using the kernel driver, which cannot be
used because of the HID blacklist.
I don't understand why a kernel driver for the
PhidgetServo was included in the kernel. Wasn't the
point of the HID layer to be able to present HID devices
to userspace so that kernel drivers don't have to be
written for each and every device?
It seems to be that the way to control a fairly simple
device like the PhidgetServo is through userspace and
the kernel shouldn't be bothered with the device control
details.
-- James Lamanna
--- linux-2.6.8.1/drivers/usb/input/hid-core.c 2004-08-14 03:55:33.000000000 -0700
+++ linux-2.6.8.1-phidget/drivers/usb/input/hid-core.c 2004-08-29
14:53:36.037632992 -0700
@@ -1493,6 +1493,7 @@
{ USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_VOLITO, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_PTU, HID_QUIRK_IGNORE },
+#ifdef CONFIG_USB_PHIDGETSERVO
{ USB_VENDOR_ID_GLAB, USB_DEVICE_ID_4_PHIDGETSERVO_30, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GLAB, USB_DEVICE_ID_1_PHIDGETSERVO_30, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GLAB, USB_DEVICE_ID_8_8_8_IF_KIT, HID_QUIRK_IGNORE },
@@ -1501,6 +1502,7 @@
{ USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_4_PHIDGETSERVO_20,
HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_1_PHIDGETSERVO_20,
HID_QUIRK_IGNORE },
+#endif
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_UC100KM, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_CS124U, HID_QUIRK_NOGET },
next reply other threads:[~2004-08-29 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-29 22:21 James Lamanna [this message]
2004-09-06 0:20 ` Remove Phidget Blacklist if kernel driver is not selected Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auto-000000530333@appliedminds.com \
--to=jamesl@appliedminds.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox