The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 0/8] s390: Add __must_check to set_memory() primitives
Date: Thu, 19 Nov 2026 10:29:01 +0200	[thread overview]
Message-ID: <av6zTc7Lx8VtVRBm@kernel.org> (raw)
In-Reply-To: <20261118144709.202520-1-hca@linux.ibm.com>

On Wed, Nov 18, 2026 at 03:47:01PM +0100, Heiko Carstens wrote:
> A small series which adds missing return value checks of set_memory()
> calls to s390 specific call sites. Also add __must_check to set_memory()
> primitives in order to avoid that new unchecked callers will be added.
> 
> This is basically the same what was done for powerpc with [1].
> 
> Note that this (trivially) conflicts with [2]. Furthermore the kexec code
> is the only call site which for now only prints an error message instead
> of really handling the error, since error handling in common code is
> missing. That needs to be added with later changes.
> 
> While doing this conversion I realized that s390's execmem support also
> can be improved. Will happen with a follow-on series.
> 
> [1] 2abbd6d5fbe0 ("powerpc: Add __must_check to set_memory_...()")
> [2] https://lore.kernel.org/all/20261117-fixes-s390-v1-1-2d9d04ca0072@kernel.org/
> 
> Thanks,
> Heiko
> 
> Heiko Carstens (8):
>   s390/kfence: Add error handling to arch_kfence_init_pool()
>   s390/kprobes: Add error handling to alloc_insn_page()
>   s390/kexec: Let crash_protect_pages() warn in case of an error
>   s390/module: Add error handling to module_alloc_ftrace_hotpatch_trampolines()
>   s390/mm: Add error handling to arch_setup_zero_pages()
>   s390/mm: Add error handling to mark_rodata_ro()
>   s390/mm: Add error handling to vmem_map_init()
>   s390/set_memory: Add __must_check to set_memory() primitives

For the series:

Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

>  arch/s390/include/asm/kfence.h     |  3 ++-
>  arch/s390/include/asm/set_memory.h |  4 ++--
>  arch/s390/kernel/kprobes.c         |  5 ++++-
>  arch/s390/kernel/machine_kexec.c   |  7 +++++--
>  arch/s390/kernel/module.c          |  7 ++++++-
>  arch/s390/mm/init.c                | 10 ++++++++--
>  arch/s390/mm/vmem.c                | 14 +++++++++-----
>  7 files changed, 36 insertions(+), 14 deletions(-)
> 
> base-commit: 666539eecdf4db623f5e3c3e55cf9f2dfad24aa4
> -- 
> 2.56.1

-- 
Sincerely yours,
Mike.

      parent reply	other threads:[~2026-11-19  8:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 14:47 [PATCH 0/8] s390: Add __must_check to set_memory() primitives Heiko Carstens
2026-11-18 14:47 ` [PATCH 1/8] s390/kfence: Add error handling to arch_kfence_init_pool() Heiko Carstens
2026-11-18 14:47 ` [PATCH 2/8] s390/kprobes: Add error handling to alloc_insn_page() Heiko Carstens
2026-11-18 14:47 ` [PATCH 3/8] s390/kexec: Let crash_protect_pages() warn in case of an error Heiko Carstens
2026-11-18 14:47 ` [PATCH 4/8] s390/module: Add error handling to module_alloc_ftrace_hotpatch_trampolines() Heiko Carstens
2026-11-18 14:47 ` [PATCH 5/8] s390/mm: Add error handling to arch_setup_zero_pages() Heiko Carstens
2026-11-18 14:47 ` [PATCH 6/8] s390/mm: Add error handling to mark_rodata_ro() Heiko Carstens
2026-11-18 14:47 ` [PATCH 7/8] s390/mm: Add error handling to vmem_map_init() Heiko Carstens
2026-11-18 14:47 ` [PATCH 8/8] s390/set_memory: Add __must_check to set_memory() primitives Heiko Carstens
2026-11-19  8:29 ` Mike Rapoport [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av6zTc7Lx8VtVRBm@kernel.org \
    --to=rppt@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox