From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, david.rhodes@cirrus.com,
rf@opensource.cirrus.com, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: cs48l32: Release the runtime PM reference on IRQ read errors
Date: Thu, 19 Nov 2026 09:44:50 +0000 [thread overview]
Message-ID: <av7FEs0HNjmnd4wR@opensource.cirrus.com> (raw)
In-Reply-To: <20261119075733.50138-1-zhujun2@cmss.chinamobile.com>
On Thu, Nov 19, 2026 at 03:57:33PM +0800, Zhu Jun wrote:
> cs48l32_irq() acquires a runtime PM reference before reading the
> interrupt registers. If either register read fails, the handler returns
> IRQ_NONE without releasing the reference. This can prevent runtime
> suspend after a bus error.
>
> Use the existing autosuspend path for both read failures. The handler
> still returns IRQ_NONE, and a failed runtime resume still exits
> without a put.
>
> Fixes: e2bcbf99d045 ("ASoC: cs48l32: Add driver for Cirrus Logic CS48L32 audio DSP")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
prev parent reply other threads:[~2026-11-19 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 7:57 [PATCH] ASoC: cs48l32: Release the runtime PM reference on IRQ read errors Zhu Jun
2026-11-19 9:44 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av7FEs0HNjmnd4wR@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox