From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Sascha Bischoff <sascha.bischoff@arm.com>
Cc: Marc Zyngier <maz@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
Radu Rendec <radu@rendec.net>,
Timothy Hayes <timothy.hayes@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Jonathan Cameron <jic23@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Fuad Tabba <fuad.tabba@linux.dev>
Subject: Re: [PATCH v3 12/14] irqchip/gic-v5: Retain the ITT when device invalidation times out
Date: Thu, 19 Nov 2026 11:28:19 +0100 [thread overview]
Message-ID: <av7PQ4iniwWC9goF@red-moon> (raw)
In-Reply-To: <20261118-host_gicv5_fixes-v3-12-13c1859e8aa3@arm.com>
On Wed, Nov 18, 2026 at 05:35:41PM +0000, Sascha Bischoff wrote:
> Device registration publishes a DTE pointing to the new ITT before
> invalidating the ITS device cache. If invalidation times out, clearing
> the DTE in memory does not guarantee that the ITS has discarded a
> cached reference to the ITT, and hence the hardware could still try
> and access the memory. Freeing the ITT on that path can therefore
> leave the ITS accessing memory that has been reallocated.
>
> Device teardown has the same problem: it frees the ITT even when the
> invalidation issued after clearing the DTE fails to complete in the
> specified timeout.
>
> Retain the ITT on either failure path. Continue returning the
> invalidation error, and free the ITT during teardown only after
> successful completion. This deliberately retains memory on hardware
> failure because a timeout does not cancel the operation or establish
> that cached references are gone.
>
> Fixes: 57d72196dfc85 ("irqchip/gic-v5: Add GICv5 ITS support")
> Reported-by: Fuad Tabba <fuad.tabba@linux.dev>
> Signed-off-by: Sascha Bischoff <sascha.bischoff@arm.com>
> Link: https://lore.kernel.org/r/20261112145814.853424-1-fuad.tabba@linux.dev
> ---
> drivers/irqchip/irq-gic-v5-its.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
> index db13011ef6d93..cfa86aa68bf3c 100644
> --- a/drivers/irqchip/irq-gic-v5-its.c
> +++ b/drivers/irqchip/irq-gic-v5-its.c
> @@ -540,8 +540,8 @@ static int gicv5_its_device_register(struct gicv5_its_chip_data *its,
>
> ret = gicv5_its_device_cache_inv(its, its_dev);
> if (ret) {
> + /* The ITS may still have a cached reference to the ITT. */
> its_write_table_entry(its, dte, 0);
> - gicv5_its_free_itt(its_dev);
> return ret;
> }
>
> @@ -570,7 +570,9 @@ static int gicv5_its_device_unregister(struct gicv5_its_chip_data *its,
> its_write_table_entry(its, dte, 0);
>
> ret = gicv5_its_device_cache_inv(its, its_dev);
> - gicv5_its_free_itt(its_dev);
> + /* Only release the ITT once the ITS has discarded its references. */
> + if (!ret)
> + gicv5_its_free_itt(its_dev);
if (ret)
return ret;
gicv5_its_free_itt(its_dev);
return 0;
Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
>
> return ret;
> }
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-11-19 10:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 17:35 [PATCH v3 00/14] irqchip/gic-v5: Fix misc IRS and ITS host driver issues Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 01/14] irqchip/gic-v5: Reject SPIs not backed by an IRS Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 02/14] irqchip/gic-v5: Only set IRS DPS when 1ofN routing is supported Sascha Bischoff
2026-11-19 11:50 ` Fuad Tabba
2026-11-18 17:35 ` [PATCH v3 03/14] irqchip/gic-v5: Serialise IRS synchronisation requests Sascha Bischoff
2026-11-19 11:53 ` Fuad Tabba
2026-11-18 17:35 ` [PATCH v3 04/14] irqchip/gic-v5: Retain the L2 IST when mapping times out Sascha Bischoff
2026-11-19 12:00 ` Fuad Tabba
2026-11-18 17:35 ` [PATCH v3 05/14] irqchip/gic-v5: Serialise ITS invalidation commands Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 06/14] irqchip/gic-v5: Use linear DT and ITT when L2 covers all IDs Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 07/14] irqchip/gic-v5: Honour ACPI ITS noncoherent flag Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 08/14] irqchip/gic-v5: Use firmware node name in ITS warning Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 09/14] irqchip/gic-v5: Invalidate ITS device cache before freeing ITT Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 10/14] irqchip/gic-v5: Clean the allocated linear device table size Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 11/14] irqchip/gic-v5: Release ITS MMIO region on DT probe failure Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 12/14] irqchip/gic-v5: Retain the ITT when device invalidation times out Sascha Bischoff
2026-11-19 10:28 ` Lorenzo Pieralisi [this message]
2026-11-19 12:07 ` Fuad Tabba
2026-11-18 17:35 ` [PATCH v3 13/14] irqchip/gic-v5: Clean a level 2 device table before making it valid Sascha Bischoff
2026-11-19 10:19 ` Lorenzo Pieralisi
2026-11-18 17:35 ` [PATCH v3 14/14] irqchip/gic-v5: Invalidate the L1 DTE when allocating an L2 device table Sascha Bischoff
2026-11-19 10:13 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av7PQ4iniwWC9goF@red-moon \
--to=lpieralisi@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=fuad.tabba@linux.dev \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=radu@rendec.net \
--cc=rafael.j.wysocki@intel.com \
--cc=sascha.bischoff@arm.com \
--cc=tglx@kernel.org \
--cc=timothy.hayes@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox