The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Michal Hocko <mhocko@suse.com>, Tejun Heo <tj@kernel.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [BUG] sched: BUG() in select_fallback_rq() at boot with isolcpus=domain on the boot CPU and CONFIG_CPUSETS=n
Date: Thu, 19 Nov 2026 17:03:59 +0100	[thread overview]
Message-ID: <av8d79cn662slr_K@localhost.localdomain> (raw)
In-Reply-To: <c40da4c4-1f70-44f7-983c-3349199b5b68@redhat.com>

Le Wed, Nov 18, 2026 at 10:55:35AM -0500, Waiman Long a écrit :
> On 11/18/26 9:49 AM, Frederic Weisbecker wrote:
> > Le Tue, Nov 17, 2026 at 10:13:02AM -0500, Waiman Long a écrit :
> > > On 11/17/26 9:48 AM, Mathieu Desnoyers wrote:
> > > > Hi,
> > > > 
> > > > With CONFIG_CPUSETS=n, a kernel booted with isolcpus=domain,0 hits the
> > > > BUG() in select_fallback_rq() during boot. CPU 0 is the boot CPU. I
> > > > found it while testing a SCHED_DEADLINE series [1]. I then reproduced
> > > > it on v7.4-rc2 alone. tip/master of 2026-11-17 and next-20261116 have
> > > > the same code. A proposed fix follows the scissors line.
> > > > 
> > > > Trigger
> > > > =======
> > > > 
> > > > Build x86-64 with CONFIG_CPUSETS=n. Boot a VM of 4 CPUs with
> > > > isolcpus=domain,0 or isolcpus=domain,0,1. The kernel panics before
> > > > init runs, in every boot.
> > > > 
> > > > These boot fine:
> > > > - the same kernel with isolcpus=domain,1,2, or without isolcpus;
> > > > - a kernel with CONFIG_CPUSETS=y, with isolcpus=domain,0,1.
> > > I am now thinking about disallowing the boot CPU from being domain isolated.
> > > That will include using isolcpus=domain boot time isolation parameter as
> > > well as in setting up isolated cpuset partition. Will that be a simpler
> > > solution than fixing all these places where isolating the boot CPU will
> > > cause various problems that need to be fixed?
> > You can try that, hopefully nobody relies on that. nohz_full supports the
> > boot CPU to be isolated but it's a heresy.
> 
> The upcoming runtime modification of nohz_full CPU will not support the boot
> CPU

Agreed.

> at least for x86, as the boot CPU cannot be made offline.

We should forbid that on all archs.

> I would not
> recommend putting the boot CPU into nohz_full boot parameter, though we are
> not going to forbid it.

It's already supported and unfortunately we can't remove that as that would
break kernel ABI.

-- 
Frederic Weisbecker
SUSE Labs

      reply	other threads:[~2026-11-19 16:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 14:48 [BUG] sched: BUG() in select_fallback_rq() at boot with isolcpus=domain on the boot CPU and CONFIG_CPUSETS=n Mathieu Desnoyers
2026-11-17 15:02 ` Peter Zijlstra
2026-11-18 17:35   ` Mathieu Desnoyers
2026-11-17 15:13 ` Waiman Long
2026-11-18 14:49   ` Frederic Weisbecker
2026-11-18 15:55     ` Waiman Long
2026-11-19 16:03       ` Frederic Weisbecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av8d79cn662slr_K@localhost.localdomain \
    --to=frederic@kernel.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox