From: Chen Yu <chen.yu@linux.dev>
To: Chen Yu <yu.c.chen@intel.com>
Cc: tony.luck@intel.com, reinette.chatre@intel.com, tglx@kernel.org,
bp@alien8.de, mingo@redhat.com, dave.hansen@linux.intel.com,
hpa@zytor.com, fenghuay@nvidia.com, babu.moger@amd.com,
hongyu.ning@intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 00/12] Introduce MMIO-based CMT access for Enhanced RDT
Date: Mon, 16 Nov 2026 17:57:29 +0800 [thread overview]
Message-ID: <avrTiSvpFSqLqCh-@three-body> (raw)
In-Reply-To: <cover.1793864720.git.yu.c.chen@intel.com>
On Thu, Nov 05, 2026 at 06:07:59PM +0800, Chen Yu wrote:
> Date: Thu, 5 Nov 2026 18:07:59 +0800
> From: Chen Yu <yu.c.chen@intel.com>
> To: tony.luck@intel.com, reinette.chatre@intel.com
> Cc: tglx@kernel.org, bp@alien8.de, mingo@redhat.com,
> dave.hansen@linux.intel.com, hpa@zytor.com, fenghuay@nvidia.com,
> babu.moger@amd.com, hongyu.ning@intel.com, chen.yu@linux.dev,
> x86@kernel.org, linux-kernel@vger.kernel.org
> Subject: [PATCH v10 00/12] Introduce MMIO-based CMT access for Enhanced RDT
> X-Mailer: git-send-email 2.25.1
>
> v9: https://lore.kernel.org/lkml/cover.1791933001.git.yu.c.chen@intel.com/
> v8: https://lore.kernel.org/lkml/cover.1789705667.git.yu.c.chen@intel.com/
> v7: https://lore.kernel.org/lkml/cover.1787976868.git.yu.c.chen@intel.com/
> v6: https://lore.kernel.org/lkml/cover.1784968626.git.yu.c.chen@intel.com/
> v5: https://lore.kernel.org/lkml/cover.1782866200.git.yu.c.chen@intel.com/
> v4: https://lore.kernel.org/lkml/cover.1781332698.git.yu.c.chen@intel.com/
> v3: https://lore.kernel.org/lkml/cover.1780710620.git.yu.c.chen@intel.com/
> v2: https://lore.kernel.org/lkml/cover.1780587063.git.yu.c.chen@intel.com/
> v1: https://lore.kernel.org/lkml/cover.1779872016.git.yu.c.chen@intel.com/
>
> Intel Enhanced Resource Director Technology (ERDT) extends the existing
> RDT framework with two major capabilities:
>
> 1. MMIO-based access to monitoring and allocation registers, replacing
> the legacy MSR-based interface.
> 2. Region-aware RDT for fine-grained control over different tiers of
> memory (e.g., CXL.mem, DDR).
>
> This is described in the Intel RDT Architecture Specification:
> https://cdrdv2-public.intel.com/789566/356688-intel-rdt-arch-spec.pdf
>
> This patch set focuses on the first part: enabling MMIO-based access for
> Cache Monitoring Technology (CMT), while CAT/MBM/MBA are still using MSR.
> The platform advertises the MMIO register layout through the ACPI ERDT
> (Enhanced Resource Director Technology) table, which contains sub-tables
> describing per-domain register regions for monitoring and allocation.
>
> With ERDT, L3 cache occupancy counters are read via MMIO rather than
> MSR, allowing the reads to be performed from any CPU without requiring
> cross-CPU IPIs. This series parses the relevant ACPI sub-tables (RMDD,
> CACD, CMRC), prepares the resctrl monitor infrastructure for MMIO-based
> reads, and adds initial support for reading L3 occupancy via the CMRC
> interface. ERDT is not compatible with Sub-NUMA Cluster (SNC) mode and
> stays disabled when SNC is enabled.
>
> Thanks Tony, Reinette, Thomas, Dave, Boris, Peter, Hongyu for your time to
> look at this patch set.
>
> Internal sashiko has not reported any issues on the v10. The change history
> in the section "Changes since v9" in each patch is generated by AI.
>
Response to the sashiko 2 review feedback at
https://sashiko.dev/#/patchset/cover.1793864720.git.yu.c.chen%40intel.com
(false positive IMO)
Review1:
"In resctrl_arch_pre_mount(), all online CPUs are then added to
RDT_RESOURCE_PERF_PKG without checking erdt_try_bind_domain():
arch/x86/kernel/cpu/resctrl/core.c:resctrl_arch_pre_mount() {
...
cpus_read_lock();
mutex_lock(&domain_list_lock);
r->mon_capable = true;
rdt_mon_capable = true;
for_each_online_cpu(cpu)
domain_add_cpu_mon(cpu, r);
mutex_unlock(&domain_list_lock);
cpus_read_unlock();
}
Will this cause an online CPU that failed erdt_try_bind_domain() at boot to
still be added to the RDT_RESOURCE_PERF_PKG monitoring domain on first mount,
while a CPU onlined (or offlined and re-onlined) after mount is excluded from
RDT_RESOURCE_PERF_PKG by resctrl_arch_online_cpu()?
Should resctrl_arch_pre_mount() also check erdt_try_bind_domain(cpu) before
calling domain_add_cpu_mon(cpu, r)?"
Response:
PERF_PKG(AET) does not care about ERDT information, so whether to add the "broken" CPU into
AET's domain does not impact the result - the AET monitor event's any_cpu is true, so
any CPU can read the monitor data without having to be read from the CPU in that domain.
We can keep as it is for now.
Review2:
Should cmrc_init() in arch/x86/kernel/cpu/resctrl/erdt.c also reject a zero
cmrc->up_scale (for example, !cmrc->up_scale || cmrc->up_scale > UINT_MAX)?
Response:
The correctness of cmrc->up_scale cannot be guaranteed, because we cannot distinguish between
a 0 value up_scale and any value between 0 and UINT_MAX, they have the same effect, and we have
to trust the BIOS/firmware on this up_scale. We can add the above check but are not sure if it is usable.
thanks,
Chenyu
prev parent reply other threads:[~2026-11-16 9:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 10:07 [PATCH v10 00/12] Introduce MMIO-based CMT access for Enhanced RDT Chen Yu
2026-11-05 10:08 ` [PATCH v10 01/12] x86/topology: Export topo_lookup_cpuid() for resctrl use Chen Yu
2026-11-05 10:08 ` [PATCH v10 02/12] arm,x86,fs/resctrl: Move resctrl_arch_round_mon_val() out of line Chen Yu
2026-11-05 10:08 ` [PATCH v10 03/12] x86/resctrl: Require 64-bit x86 for resctrl support Chen Yu
2026-11-05 10:08 ` [PATCH v10 04/12] x86/resctrl: Detect Sub-NUMA Cluster mode before enumerating resources Chen Yu
2026-11-05 10:08 ` [PATCH v10 05/12] x86/resctrl: Parse ACPI ERDT table and save CACD cpumask per RMD Chen Yu
2026-11-05 10:08 ` [PATCH v10 06/12] x86/resctrl: Attach ACPI ERDT information to L3 mon domain on CPU online Chen Yu
2026-11-05 10:09 ` [PATCH v10 07/12] x86/resctrl: Parse ACPI CMRC table Chen Yu
2026-11-05 10:09 ` [PATCH v10 08/12] x86/resctrl: Refactor the monitor read function Chen Yu
2026-11-05 10:09 ` [PATCH v10 09/12] fs/resctrl: Do not invoke smp_processor_id() in preemptible context Chen Yu
2026-11-05 10:09 ` [PATCH v10 10/12] x86/resctrl: Introduce erdt_cpu_has() and erdt_support() Chen Yu
2026-11-05 10:09 ` [PATCH v10 11/12] x86/resctrl: Add the ERDT CMT scale Chen Yu
2026-11-05 10:10 ` [PATCH v10 12/12] x86/resctrl: Add MMIO-based LLC occupancy monitoring support Chen Yu
2026-11-16 9:57 ` Chen Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avrTiSvpFSqLqCh-@three-body \
--to=chen.yu@linux.dev \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=hongyu.ning@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox