The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Ahmed S. Darwish" <darwi@linutronix.de>
To: Julian Braha <julianbraha@gmail.com>
Cc: "Clark Williams" <clrkwllms@kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nicolas Schier" <nsc@kernel.org>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Frederic Weisbecker" <frederic@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"John Ogness" <john.ogness@linutronix.de>,
	"Derek Barbosa" <debarbos@redhat.com>,
	"Zbigniew Jędrzejewski-Szmek" <zbyszek@amutable.com>,
	"Daan De Meyer" <daan.j.demeyer@gmail.com>,
	"Luca Boccassi" <luca.boccassi@gmail.com>,
	linux-rt-devel@lists.linux.dev, debian-kernel@lists.debian.org,
	linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, arighi@nvidia.com
Subject: Re: [PATCH v1 03/10] kconfig-checker: Add the configuration checker code
Date: Mon, 16 Nov 2026 11:52:33 +0100	[thread overview]
Message-ID: <avrgcfcsp2FBVG4u@lx-t490> (raw)
In-Reply-To: <81c91813-79ff-4d36-92e6-8c0ecc1772c7@gmail.com>

Hi Julian,

On Thu, 12 Nov 2026, Julian Braha wrote:
> On 11/9/26 13:00, Ahmed S. Darwish wrote:
> >
> > In v2 of this series, I'll make the schema explicitly versioned. This
> > way, new features like the above can be cleanly added.
> >
>
> Adding schema versioning would be great.

Yup.

> > P.S., I can definitely implement such support, but I'm a bit hesitant
> > to adding features that are not yet needed by the existing mainline
> > policies.
>
> I suppose it's not necessary to support these option types at the start,
> as there are few of them, relatively speaking. But it would be good to
> add some input validation in case a user attempts this.
>
> So I've finally had some time to sit down and test this:
>
> I created my own policy with these other types, and sure enough, if I
> specify them as 'disabled' in the policy like this:
>
>     rules:
>       - name: CONFIG_LOG_BUF_SHIFT
>         expected: n
>         severity: high
>
>       - name: CONFIG_PHYSICAL_START
>         expected: n
>         severity: high
>
>       - name: CONFIG_DEFAULT_HOSTNAME
>         expected: n
>         severity: high
>
> and my .config has these values:
>     CONFIG_LOG_BUF_SHIFT=17
>     CONFIG_PHYSICAL_START=0x1000000
>     CONFIG_DEFAULT_HOSTNAME="example"
>
> then the config passes the check -- but it would probably be better to
> provide a warning or something about these options.
>
> Also, if I modify my policy to set 'expected' to 'y' for these, it
> reports "not in .config" (which would likely be confusing to the user).
>
> This regex stmt should match all int, hex, and string options for you:
>     unsupported = re.compile(r'^(CONFIG_[A-Za-z0-9_]+)=[0-9a-fA-F"-]')
> by checking the first character of its value.
>

You're definitely correct here, thanks.

If a symbol is expected as enabled or disabled in the policy, but the
.config has it as an int, hex, or a string, then the report must include
that as a policy mismatch.

So for the above case, the tool should report something like:

  * Below option is set as an integer:

     CONFIG_LOG_BUF_SHIFT

    But it's expected to be disabled instead.

And similarly for the other symbols.

I'll fix that in v2.

> The included preempt_rt policy worked as expected (nice).

Glad to hear!

All the best,
--
Ahmed S. Darwish
Linutronix GmbH

  reply	other threads:[~2026-11-16 10:52 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  9:19 [PATCH v1 00/10] tools: Introduce a kernel configuration checker Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 01/10] kconfig-checker: Add schema for rule files Ahmed S. Darwish
2026-11-08 18:59   ` Julian Braha
2026-11-09 12:40     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 02/10] kconfig-checker: Introduce PREEMPT_RT configuration rules Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 18:09     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 03/10] kconfig-checker: Add the configuration checker code Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 19:29     ` Ahmed S. Darwish
2026-11-08 18:59   ` Julian Braha
2026-11-09 13:00     ` Ahmed S. Darwish
2026-11-12 22:56       ` Julian Braha
2026-11-16 10:52         ` Ahmed S. Darwish [this message]
2026-11-06  9:19 ` [PATCH v1 04/10] kconfig: Introduce checkconfig target Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 20:07     ` Ahmed S. Darwish
2026-11-12 15:53       ` Ahmed S. Darwish
2026-11-08 18:59   ` Julian Braha
2026-11-09  0:39     ` Nathan Chancellor
2026-11-09 13:18       ` Ahmed S. Darwish
2026-11-11  6:38         ` Nicolas Schier
2026-11-12 11:32           ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 05/10] Documentation: Describe kconfig-checker usage and design Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 06/10] kconfig-checker: Split schema to support component reuse Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 18:22     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 07/10] kconfig-checker: Introduce overlays schema Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 16:47     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 08/10] kconfig-checker: Add support for rule overlays Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 09/10] Documentation: Describe kconfig-checker overlays Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 16:50     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 10/10] kconfig: Introduce OVERLAY= for make checkconfig Ahmed S. Darwish
2026-11-11  6:38   ` Nicolas Schier
2026-11-12 11:45     ` Ahmed S. Darwish
2026-11-12 21:31       ` Ahmed S. Darwish
2026-11-08 18:59 ` [PATCH v1 00/10] tools: Introduce a kernel configuration checker Julian Braha
2026-11-09  0:37   ` Nathan Chancellor
2026-11-09 16:15     ` Ahmed S. Darwish
2026-11-09 16:52       ` Nathan Chancellor
2026-11-09 17:04         ` Ahmed S. Darwish
2026-11-09 15:49   ` Ahmed S. Darwish
2026-11-10 18:18     ` Julian Braha
2026-11-10 20:33       ` Ahmed S. Darwish
2026-11-11  6:38 ` Nicolas Schier
2026-11-12 12:36   ` Ahmed S. Darwish
2026-11-12 17:50     ` Nathan Chancellor
2026-11-12 19:14       ` Ahmed S. Darwish
2026-11-12 21:44         ` Nathan Chancellor
2026-11-12 23:14     ` Julian Braha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avrgcfcsp2FBVG4u@lx-t490 \
    --to=darwi@linutronix.de \
    --cc=arighi@nvidia.com \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=corbet@lwn.net \
    --cc=daan.j.demeyer@gmail.com \
    --cc=debarbos@redhat.com \
    --cc=debian-kernel@lists.debian.org \
    --cc=frederic@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.ogness@linutronix.de \
    --cc=julianbraha@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=luca.boccassi@gmail.com \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=zbyszek@amutable.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox