From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: "Carlos López" <clopez@suse.de>
Cc: kvm@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-riscv@lists.infradead.org, seanjc@google.com,
pbonzini@redhat.com, akpm@linux-foundation.org,
david@kernel.org, peterx@redhat.com, imbrenda@linux.ibm.com,
borntraeger@linux.ibm.com, frankja@linux.ibm.com,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jann Horn <jannh@google.com>,
Pedro Falcato <pfalcato@suse.de>
Subject: Re: [PATCH v3 5/9] mm/mprotect: add MM_CP_PERM_UPGRADE
Date: Mon, 16 Nov 2026 14:53:22 +0000 [thread overview]
Message-ID: <avsY22UYKI_Z3OUk@gremlin> (raw)
In-Reply-To: <079c15fb-8b41-472d-b9f2-d88826e27286@suse.de>
On Sun, Nov 15, 2026 at 11:01:52PM +0100, Carlos López wrote:
> On 11/13/26 9:37 PM, Lorenzo Stoakes (ARM) wrote:
> > On Thu, Nov 12, 2026 at 03:20:34PM +0100, Carlos López wrote:
> >> Add a change_protection() flag for changes that only add permissions,
> >> so that MMU notifier users can keep their mappings and fault in the new
> >> permissions later. mprotect() sets it when the new VMA flags only add
> >> read, write or execute permissions, or VM_ACCOUNT, which does not affect
> >> the page tables. Any other change, such as a different protection key,
> >> is not an upgrade.
> >
> > I'm struggling to comprehend what this means.
> >
> > 'Add a flag for changes that only add 'permissions' (not defined) so that 'MMU
> > notifier users' can keep mappings and 'fault' in 'the new permissions' later.
> >
> > The rest of the message just states what the code does but speaks about it as if
> > it was already what happened.
> >
> > This needs to be completely rewritten...!
>
> I'll rewrite it. By permissions I mean the access granted by the
> protection bits in the page table entries.
>
> > [...]
> >> +/* Whether this change only upgrades/adds permissions */
> >> +#define MM_CP_PERM_UPGRADE (1UL << 6)
> >
> > What are 'permissions' exactly?
>
> See above
>
> > [...]
> >> +static bool vma_flags_is_perm_upgrade(vma_flags_t old_vma_flags,
> >> + vma_flags_t new_vma_flags)
> >
> > No comment, random abbreviation (but just one word). Not ideal.
>
> I'll rename. As David noted, the name I chose is not really correct.
>
> >> +{
> >> + vm_flags_t old = vma_flags_to_legacy(old_vma_flags);
> >> + vm_flags_t new = vma_flags_to_legacy(new_vma_flags);
> >
> > This is beyond appalling and a complete abuse of the VMA flags API.
> >
> > You seem to have decided that you won't try to learn how the API works, so
> > instead you'll just write deprecated code that I have to find time to come and
> > fix up later I guess?
>
> Sorry, I'll rewrite the helper with the vma_flags_t API, using
> VMA_ACCESS_FLAGS and VMA_ACCOUNT_BIT, and document it.
>
> > And we're at v3...!
> >
> >> + /* VM_ACCOUNT does not affect page tables */
> >
> > What does this mean? And why are you referring to a deprecated constant?
>
> I meant that setting VM_ACCOUNT does not affect the protection bits of
> an entry, so it should not prevent the new flag from being set.
> mprotect() sets VM_ACCOUNT when a private mapping becomes writable,
> which is the case I wanted to cover. I'll explain this better.
Thanks for all! :)
--
Cheers, Lorenzo
next prev parent reply other threads:[~2026-11-16 14:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 14:20 [PATCH v3 0/9] KVM: don't zap secondary MMU on permission upgrade Carlos López
2026-11-12 14:20 ` [PATCH v3 1/9] mm: fix eager write-bit restore for write-notified shared mappings Carlos López
2026-11-13 20:47 ` Lorenzo Stoakes (ARM)
2026-11-15 22:00 ` Carlos López
2026-11-12 14:20 ` [PATCH v3 2/9] riscv: mm: add pud_soft_dirty() Carlos López
2026-11-12 14:20 ` [PATCH v3 3/9] mm/huge_memory: honor MM_CP_TRY_CHANGE_WRITABLE in change_huge_pud() Carlos López
2026-11-13 18:58 ` David Hildenbrand (Arm)
2026-11-15 22:00 ` Carlos López
2026-11-13 20:48 ` Lorenzo Stoakes (ARM)
2026-11-15 22:00 ` Carlos López
2026-11-12 14:20 ` [PATCH v3 4/9] mm: keep writable entries writable on protection changes Carlos López
2026-11-13 18:56 ` David Hildenbrand (Arm)
2026-11-15 21:59 ` Carlos López
2026-11-12 14:20 ` [PATCH v3 5/9] mm/mprotect: add MM_CP_PERM_UPGRADE Carlos López
2026-11-13 18:51 ` David Hildenbrand (Arm)
2026-11-15 22:03 ` Carlos López
2026-11-13 20:37 ` Lorenzo Stoakes (ARM)
2026-11-15 22:01 ` Carlos López
2026-11-16 14:53 ` Lorenzo Stoakes (ARM) [this message]
2026-11-12 14:20 ` [PATCH v3 6/9] mm/mmu_notifier: add MMU_NOTIFIER_RANGE_PERM_UPGRADE Carlos López
2026-11-12 14:20 ` [PATCH v3 7/9] KVM: pass the mmu_notifier event and flags to kvm_gfn_range Carlos López
2026-11-12 14:20 ` [PATCH v3 8/9] KVM: x86/mmu: don't zap secondary MMU on permission upgrade Carlos López
2026-11-12 14:20 ` [PATCH v3 9/9] KVM: s390: don't unmap the gmap " Carlos López
2026-11-13 19:00 ` [PATCH v3 0/9] KVM: don't zap secondary MMU " David Hildenbrand (Arm)
2026-11-13 20:32 ` Lorenzo Stoakes (ARM)
2026-11-15 22:04 ` Carlos López
2026-11-13 20:59 ` Lorenzo Stoakes (ARM)
2026-11-15 22:19 ` Carlos López
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avsY22UYKI_Z3OUk@gremlin \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=clopez@suse.de \
--cc=david@kernel.org \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jannh@google.com \
--cc=kvm@vger.kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox