The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Zhenyu Wang <zhenyuw.linux@gmail.com>
To: Tuo Li <islituo@gmail.com>
Cc: zhi.wang.linux@gmail.com, jani.nikula@linux.intel.com,
	joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
	tursulin@ursulin.net, airlied@gmail.com, simona@ffwll.ch,
	ankit.k.nautiyal@intel.com, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915/gvt: Fix NULL pointer dereference in slot switch
Date: Tue, 17 Nov 2026 10:01:16 +0900	[thread overview]
Message-ID: <avunXOrG8wfAI2cR@dell-wzy> (raw)
In-Reply-To: <20261112155822.1336713-1-islituo@gmail.com>

On Thu, Nov 12, 2026 at 11:58:22PM +0800, Tuo Li wrote:
> The running slot is updated to the pending slot before updating the running
> context. However, the condition checks the old running context instead of
> the newly assigned running slot.
> 
> When no pending slot exists, running_slot becomes NULL. If the previous
> running_context is non-NULL, the code attempts to access
> running_slot->ctx[0], resulting in a NULL pointer dereference.
> 
> To fix this possible NULL pointer dereference, check running_slot instead
> to ensure that running_context is updated only when a valid slot is
> available.

Well, just AI generated static check but without any runtime analysis,
again...and can't even show kernel oops of this, as it simply can't happen..

> 
> Fixes: 8453d674ae7e ("drm/i915/gvt: vGPU execlist virtualization")
> Signed-off-by: Tuo Li <islituo@gmail.com>
> ---
>  drivers/gpu/drm/i915/gvt/execlist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c
> index 29147a9f162e..763c310f2aaf 100644
> --- a/drivers/gpu/drm/i915/gvt/execlist.c
> +++ b/drivers/gpu/drm/i915/gvt/execlist.c
> @@ -73,7 +73,7 @@ static void switch_virtual_execlist_slot(struct intel_vgpu_execlist *execlist)
>  
>  	execlist->running_slot = execlist->pending_slot;
>  	execlist->pending_slot = NULL;
> -	execlist->running_context = execlist->running_context ?
> +	execlist->running_context = execlist->running_slot ?
>  		&execlist->running_slot->ctx[0] : NULL;
>

Current code calls this switch in case whenever running_slot is
available, so it won't have null ptr reference. But code looks a
little weird, as current code tried to assign running_context in other
place e.g when new request happened, or even it might seem to miss
when enter execlist idle state...but it is still valid in switch
call. So I think this is just harmless. If you'd like for further
cleanup, that needs testing result for sure.

Thanks.

      reply	other threads:[~2026-11-17  1:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 15:58 [PATCH] drm/i915/gvt: Fix NULL pointer dereference in slot switch Tuo Li
2026-11-17  1:01 ` Zhenyu Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avunXOrG8wfAI2cR@dell-wzy \
    --to=zhenyuw.linux@gmail.com \
    --cc=airlied@gmail.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=islituo@gmail.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=tursulin@ursulin.net \
    --cc=zhi.wang.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox