The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Renzo Davoli <renzo@cs.unibo.it>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
	"Dmitry V . Levin" <ldv@strace.io>,
	Alexey Gladkov <legion@kernel.org>,
	Eugene Syromyatnikov <evgsyr@gmail.com>,
	Charlie Jenkins <thecharlesjenkins@gmail.com>,
	Bradley Morgan <bradley.morgan@linux.dev>,
	Shuah Khan <shuah@kernel.org>,
	strace-devel@lists.strace.io, linux-api@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4 2/2] selftests/ptrace: check that PTRACE_SET_SYSCALL_INFO rejects invalid error values
Date: Tue, 17 Nov 2026 10:51:44 +0100	[thread overview]
Message-ID: <avwjsMQay_N_pfvt@cs.unibo.it> (raw)
In-Reply-To: <avwY4RW14jtVfgZO@cs.unibo.it>

On Tue, Nov 17, 2026 at 10:05:37AM +0100, Renzo Davoli wrote:
> Thanks Andrew, the fixup is correct and a good addition: the test now
> covers both sides of the -MAX_ERRNO boundary.

A follow-up for when the other two PTRACE_SET_SYSCALL_INFO series come
up:

[PATCH v11 0/3] PTRACE_SET_SYSCALL_INFO: add support for seccomp syscall skipping
https://lore.kernel.org/lkml/20261114181923.370930-1-renzo@cs.unibo.it/
[PATCH v4 0/3] ptrace_set_syscall_info: add support for instruction pointer modification
https://lore.kernel.org/lkml/20261114184720.373178-1-renzo@cs.unibo.it/

I tested the full stack on x86_64 (QEMU): this series with your fixup,
then the syscall-skipping v11, then SET_IP v4 (which depends on
syscall-skipping). set_syscall_info passes.

There is one trivial textual conflict: your "#define MAX_ERRNO" lands
right where syscall-skipping v11 patch 3/3 adds new #includes, so it
does not apply with plain "git am"; "git am -3" resolves it, and the
result differs from the stack without your fixup only by the fixup
itself. If you prefer, I can send syscall-skipping v12 rebased on top
of mm-nonmm-unstable.

renzo

      reply	other threads:[~2026-11-17  9:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 13:40 [PATCH v4 0/2] ptrace: reject out of range error values in PTRACE_SET_SYSCALL_INFO Renzo Davoli
2026-11-16 13:40 ` [PATCH v4 1/2] " Renzo Davoli
2026-11-16 14:03   ` Oleg Nesterov
2026-11-16 13:40 ` [PATCH v4 2/2] selftests/ptrace: check that PTRACE_SET_SYSCALL_INFO rejects invalid error values Renzo Davoli
2026-11-16 23:36   ` Andrew Morton
2026-11-17  9:05     ` Renzo Davoli
2026-11-17  9:51       ` Renzo Davoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avwjsMQay_N_pfvt@cs.unibo.it \
    --to=renzo@cs.unibo.it \
    --cc=akpm@linux-foundation.org \
    --cc=bradley.morgan@linux.dev \
    --cc=evgsyr@gmail.com \
    --cc=ldv@strace.io \
    --cc=legion@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=shuah@kernel.org \
    --cc=strace-devel@lists.strace.io \
    --cc=thecharlesjenkins@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox