From: Jarkko Sakkinen <jarkko@kernel.org>
To: Rustam Mustafin <rmustafin@cloudlinux.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Jaewon Yang <yong010301@gmail.com>,
Tadeusz Struk <tadeusz.struk@intel.com>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] tpm: track the response read position internally, not via the file offset
Date: Tue, 17 Nov 2026 12:59:21 +0200 [thread overview]
Message-ID: <avwzid1Ovl4ACkaQ@kernel.org> (raw)
In-Reply-To: <20261117104838.2650999-1-rmustafin@cloudlinux.com>
Please remove that claude'ism from short summary (, not.. uaargh).
On Tue, Nov 17, 2026 at 05:48:38PM +0700, Rustam Mustafin wrote:
> Commit f20d61c22bca ("tpm: Make the TPM character devices non-seekable")
Duplicate information to fixes tag.
> made pread() fail with -ESPIPE, but tpm_common_read() still indexes
> data_buffer with *off, and io_uring can still set it: IORING_OP_READ
io_uring is a data structure, not an active actor and IORING_OP_READ
is a constant.
> copies sqe->off into ki_pos without checking FMODE_PREAD, and
> loop_rw_iter() passes it to ->read(). With sqe->off = 0x1400 the read
> copies heap memory past data_buffer to user space and then zeroes it:
>
> BUG: KASAN: slab-out-of-bounds in _copy_to_user+0x4b/0x70
> Read of size 16 by task iou-wrk-148/149
> Call Trace:
> _copy_to_user+0x4b/0x70
> tpm_common_read+0x16e/0x2c0
> loop_rw_iter+0x235/0x5a0
> __io_read+0xc6e/0x11a0
> io_read+0x8a/0x180
>
> Keep the read position in file_priv, protected by buffer_mutex, and
Why open code variable names in English?
> ignore *off. This also closes a race where read() samples f_pos before
> taking buffer_mutex and a concurrent write() replaces the response in
> between.
>
> Fixes: 9488585b21be ("tpm: add support for partial reads")
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/r/CAHk-=wi8aXM9=Y8othMb1oxTv-PDw4isj-FPbXu0MXsm_EPE1g@mail.gmail.com/
> Signed-off-by: Rustam Mustafin <rmustafin@cloudlinux.com>
> ---
> - A C reproducer for the io_uring path is available on request.
> - nonseekable_open() only closes the VFS doors (lseek(), pread()); io_uring
> bypasses both, so with this patch an IORING_OP_READ that passes an
> explicit sqe->off ignores the offset and reads sequentially.
Why weren't you able to realize this in the kselftest?
>
> drivers/char/tpm/tpm-dev-common.c | 11 ++++++-----
> drivers/char/tpm/tpm-dev.h | 1 +
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm-dev-common.c b/drivers/char/tpm/tpm-dev-common.c
> index ee91f456f975..553fc6aca94d 100644
> --- a/drivers/char/tpm/tpm-dev-common.c
> +++ b/drivers/char/tpm/tpm-dev-common.c
> @@ -107,6 +107,7 @@ static void tpm_timeout_work(struct work_struct *work)
> mutex_lock(&priv->buffer_mutex);
> priv->response_read = true;
> priv->response_length = 0;
> + priv->read_pos = 0;
I did search read_pos but it had zero hits in the commit message.
> memset(priv->data_buffer, 0, sizeof(priv->data_buffer));
> mutex_unlock(&priv->buffer_mutex);
> wake_up_interruptible(&priv->async_wait);
> @@ -149,21 +150,21 @@ ssize_t tpm_common_read(struct file *file, char __user *buf,
> goto out;
> }
>
> - rc = copy_to_user(buf, priv->data_buffer + *off, ret_size);
> + rc = copy_to_user(buf, priv->data_buffer + priv->read_pos, ret_size);
> if (rc) {
> memset(priv->data_buffer, 0, TPM_BUFSIZE);
> priv->response_length = 0;
> ret_size = -EFAULT;
> } else {
> - memset(priv->data_buffer + *off, 0, ret_size);
> + memset(priv->data_buffer + priv->read_pos, 0, ret_size);
> priv->response_length -= ret_size;
> - *off += ret_size;
> + priv->read_pos += ret_size;
> }
> }
>
> out:
> if (!priv->response_length) {
> - *off = 0;
> + priv->read_pos = 0;
> timer_delete_sync(&priv->user_read_timer);
> flush = true;
> }
> @@ -214,7 +215,7 @@ ssize_t tpm_common_write(struct file *file, const char __user *buf,
>
> priv->response_length = 0;
> priv->response_read = false;
> - *off = 0;
> + priv->read_pos = 0;
>
> /*
> * If in nonblocking mode schedule an async job to send
> diff --git a/drivers/char/tpm/tpm-dev.h b/drivers/char/tpm/tpm-dev.h
> index f3742bcc73e3..34efb1ffa491 100644
> --- a/drivers/char/tpm/tpm-dev.h
> +++ b/drivers/char/tpm/tpm-dev.h
> @@ -15,6 +15,7 @@ struct file_priv {
> struct work_struct async_work;
> wait_queue_head_t async_wait;
> ssize_t response_length;
> + size_t read_pos;
> bool response_read;
> bool command_enqueued;
>
> --
> 2.52.0
>
Br, Jarkko
next prev parent reply other threads:[~2026-11-17 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 9:02 [PATCH] tpm: Reject reads outside the response buffer Jaewon Yang
2026-07-11 17:08 ` Jarkko Sakkinen
2026-07-11 18:58 ` Linus Torvalds
2026-07-12 17:11 ` [PATCH v2] tpm: Make the TPM character devices non-seekable Jaewon Yang
2026-07-12 19:54 ` Linus Torvalds
2026-07-18 18:13 ` Jarkko Sakkinen
2026-07-18 18:20 ` Jarkko Sakkinen
2026-11-17 10:48 ` [PATCH] tpm: track the response read position internally, not via the file offset Rustam Mustafin
2026-11-17 10:59 ` Jarkko Sakkinen [this message]
2026-07-18 18:17 ` [PATCH] tpm: Reject reads outside the response buffer Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avwzid1Ovl4ACkaQ@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=rmustafin@cloudlinux.com \
--cc=stable@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
--cc=yong010301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox