From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794947034; b=IWjjd1P4qa8M6AlQMCRfVpiwDvc3oCXC3JF0mBYZ8Ib9YhUf11aEX1QwzGeOnth7nfO7 CLTcNKzKvRteZimQJio3jLOlA2NlesDJViGmmUlV8SBVQ2KO0zSaprRLQkVXbmexhdjF/ h1EgRYDEd+BtuYjRVWQDOdPfFOdnQ3G+2d7yxtSwm5BuAeZ2g96mnIxCcM8+MgzWIIh72 Xf0SO7NyxCyZ/qWmxp4TWvG0bM8b4cV5LCjbOR7ZPfLsBLVyygZjK83VdTP5QQOz6n1li W8H40ktpXVYw+Up/zfvfop2dUkfj7wu999vhPprReVWi6/suWXFw2qX/gdAcdWRqsSA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794947034; h=DMARC-Filter:Received:Received:DKIM-Signature:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=tTL/AUEqSJkRG3nWH8R3uR4syPVF5VUWiQzwcpGtoTI=; b=mnNlhh/ffzMyB/wUD0o0on/HmmUcoXHSDExCBPd+LEgesRWPrRyJiLoQnsb/6DtK9kL7 uSqnUsBoFQw7RQfnd8clIIORKKVLZjMWnTSK+bXeYvEvoFo8ct77MZsvdS1BtOVsa8WcP b6P+JCycJh0reDwDYTPXgcJpeTSYKEcmVpSsJsdYo3r6u038dm6OsR9QjLBj54JUzrJfC axu+31BP0P4B4muISPK7soyt73Bdx3EMB2uOJjkBtjg+XhMdXGmzPq4CRtVW4fNQm2V5r UthRz4qFhcNPA0/DkyB6CRuoEQ2/e2TdFCiw+hgEZVM/0EWr9k8UivGSWk/5JVcp/rw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=CKQpNjIe; arc=none smtp.remote-ip=217.140.110.172 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 86764606A31C; Tue, 17 Nov 2026 20:23:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 86764606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=CKQpNjIe Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05434339; Tue, 17 Nov 2026 12:23:50 -0800 (PST) Received: from e129823.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0358C3F632; Tue, 17 Nov 2026 12:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1794947032; bh=aRKRMs6N0PcFLX51B23/Z9noAreEFY3ilqOZ6juqKJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CKQpNjIeKDKrZSWQiWGaCvz9OSOzjj76EwUxedpIrMeoTSYxRTaIa+uS/pv/zfhz0 SyEssw5+WJFIycPzE2Lgc4Y9TIW8Y8+iDqkbAERpFeZ+xaZ4UtQZ9jJLFj2Bl59duc LIZlBV4+wOyLC32RNt9QuaOD6evuZPoW18/x5Ed8= Date: Tue, 17 Nov 2026 20:23:48 +0000 From: Yeoreum Yun To: Siddharth Chintamaneni Cc: Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Sudeep Holla , Yeoreum Yun , Stuart Yoder , apais@microsoft.com, rachelmenge@linux.microsoft.com, hargar@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] tpm: tpm_crb_ffa: Only probe when ACPI TPM2 uses FF-A Message-ID: References: <20261115013456.212141-1-sidchintamaneni@gmail.com> <20261115013456.212141-3-sidchintamaneni@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261115013456.212141-3-sidchintamaneni@gmail.com> LGTM. Reviewed-by: Yeoreum Yun On Sun, Nov 15, 2026 at 01:34:54AM +0000, Siddharth Chintamaneni wrote: > Prior to commit 677042afb97a ("tpm: tpm_crb_ffa: revert defered_probed > when tpm_crb_ffa is built-in"), built-in tpm_crb_ffa only registered > tpm_crb_ffa_driver from tpm_crb_ffa_init() after crb_acpi_probe() > confirmed start_method == ACPI_TPM2_CRB_WITH_ARM_FFA. After that > commit, tpm_crb_ffa unconditionally registers on the FF-A bus at > device_initcall time (and when loaded as a module) without checking > the platform's ACPI TPM2 start method. > > A platform's firmware may expose a TPM CRB over FF-A Secure Partition > for UEFI boot services while advertising a non-FF-A start method to > the OS in the ACPI TPM2 table. When the ACPI TPM2 table designates a > non-FF-A start method, Linux has no consumer for tpm_crb_ffa and > should not probe the FF-A TPM service. > > On Microsoft Cobalt 200 systems, the ACPI TPM2 table does not use > ACPI_TPM2_CRB_WITH_ARM_FFA, yet ffa_init() discovers the FF-A TPM > partition and tpm_crb_ffa_probe() unconditionally sends > CRB_FFA_GET_INTERFACE_VERSION via FFA_MSG_SEND_DIRECT_REQ2/REQ SMC. > That request wedges the calling CPU in Secure World (with Non-Secure > interrupts and GICv3 pseudo-NMIs masked), hanging boot with an RCU CPU > stall: > > [ 5.507519] ARM FF-A: Driver version 1.2 > [ 5.507519] ARM FF-A: Firmware version 1.2 found > [ 5.507551] ARM FF-A: Notification setup failed -61, not enabled > [ 7.150580] Freeing initrd memory: 293640K > [ 65.515248] rcu: INFO: rcu_preempt detected stalls on CPUs/tasks: > [ 65.521346] rcu: 10-...0: (3 GPs behind) idle=dd9c/1/0x4000000000000000 softirq=37/37 fqs=5262 > [ 65.530031] rcu: hardirqs softirqs csw/system > [ 65.535589] rcu: number: 0 0 0 > [ 65.541146] rcu: cputime: 0 0 0 ==> 30028(ms) > [ 65.548102] rcu: (detected by 66, t=15010 jiffies, g=-951, q=1384 ncpus=132) > [ 65.555228] Sending NMI from CPU 66 to CPUs 10: > [ 75.560686] After 10 seconds, these CPUS still haven't responded to the NMI: 10 > > Check tpm2_acpi_start_method in tpm_crb_ffa_probe() and return -ENODEV > unless it equals ACPI_TPM2_CRB_WITH_ARM_FFA. Checking in probe() rather > than module_init allows tpm_crb_ffa.ko to load as a symbol dependency > of tpm_crb.ko on non-FF-A platforms when built as modules, while > skipping FF-A TPM requests unless ACPI advertises the FF-A start > method. > > Fixes: eb93f0734ef1 ("tpm_crb: ffa_tpm: Implement driver compliant to CRB over FF-A") > Signed-off-by: Siddharth Chintamaneni > --- > drivers/char/tpm/tpm_crb_ffa.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/char/tpm/tpm_crb_ffa.c b/drivers/char/tpm/tpm_crb_ffa.c > index 025c4d4b17ca..da676da6f3f0 100644 > --- a/drivers/char/tpm/tpm_crb_ffa.c > +++ b/drivers/char/tpm/tpm_crb_ffa.c > @@ -9,9 +9,11 @@ > > #define pr_fmt(fmt) "CRB_FFA: " fmt > > +#include > #include > #include > #include > +#include "tpm.h" > #include "tpm_crb_ffa.h" > > static unsigned int busy_timeout_ms = 2000; > @@ -324,6 +326,9 @@ static int tpm_crb_ffa_probe(struct ffa_device *ffa_dev) > struct tpm_crb_ffa *p; > int rc; > > + if (tpm2_acpi_start_method != ACPI_TPM2_CRB_WITH_ARM_FFA) > + return -ENODEV; > + > /* only one instance of a TPM partition is supported */ > if (tpm_crb_ffa && !IS_ERR_VALUE(tpm_crb_ffa)) > return -EEXIST; > -- > 2.45.4 > -- Sincerely, Yeoreum Yun