From: Petr Mladek <pmladek@suse.com>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc: john.ogness@linutronix.de, rostedt@goodmis.org,
senozhatsky@chromium.org, paulmck@kernel.org,
printk@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] printk: ringbuffer: Annotate speculative record reads
Date: Fri, 20 Nov 2026 13:32:02 +0100 [thread overview]
Message-ID: <awA9wqUfXuX92d4k@pathway> (raw)
In-Reply-To: <20261113075039.172176-1-zhujun2@cmss.chinamobile.com>
On Fri 2026-11-13 15:50:38, Zhu Jun wrote:
> Readers may copy a finalized record while a writer recycles its storage.
> prb_read() checks the descriptor again after copying and rejects records
> that have changed, but the plain metadata and text accesses still trigger
> KCSAN reports.
>
> Annotate the speculative copies, line counting and length read with
> data_race(). The descriptor validation continues to determine whether
> the copied record can be used.
>
> Fixes: b6cf8b3f3312 ("printk: add lockless ringbuffer")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Looks good:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
prev parent reply other threads:[~2026-11-20 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 7:50 [PATCH v3] printk: ringbuffer: Annotate speculative record reads Zhu Jun
2026-11-13 12:07 ` John Ogness
2026-11-20 12:32 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awA9wqUfXuX92d4k@pathway \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=printk@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox