The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: NanamiKite <nanami@yosoro.hk>
Cc: Jean Delvare <jdelvare@suse.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: i801: Add support for Intel Lunar Lake-M
Date: Fri, 20 Nov 2026 16:03:25 +0100	[thread overview]
Message-ID: <awBhPXzSbfpJyCyJ@black.igk.intel.com> (raw)
In-Reply-To: <tencent_6874806C455DB42610399513A0A95083C805@qq.com>

On Thu, Nov 19, 2026 at 11:37:46AM +0800, NanamiKite wrote:
> Add the SMBus PCI ID (0xa822) for Intel Lunar Lake-M (Core Ultra 200V
> series).
> 
> Tested on an Intel Core Ultra 5 226V (Lunar Lake-M) laptop via dynamic
> new_id binding with FEATURES_ICH5 | FEATURE_TCO_CNL: the controller
> binds with PCI interrupt support, handles SMBus transactions cleanly
> (verified with i2cdetect), and initializes the version 6 iTCO_wdt
> watchdog at TCOBASE 0x0400 (verified with wdctl).
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: NanamiKite <nanami@yosoro.hk>

Thanks! I'm a bit surprised that this ID has not been added to the
driver before. FWIW:

Reviewed-by: Heikki Krogerus <heikki.krogeurs@linux.intel.com>

> ---
>  Documentation/i2c/busses/i2c-i801.rst | 1 +
>  drivers/i2c/busses/Kconfig            | 1 +
>  drivers/i2c/busses/i2c-i801.c         | 3 +++
>  3 files changed, 5 insertions(+)
> 
> diff --git a/Documentation/i2c/busses/i2c-i801.rst b/Documentation/i2c/busses/i2c-i801.rst
> index bbbce90..2e7f3f0 100644
> --- a/Documentation/i2c/busses/i2c-i801.rst
> +++ b/Documentation/i2c/busses/i2c-i801.rst
> @@ -53,6 +53,7 @@ Supported adapters:
>    * Intel Wildcat Lake (SOC)
>    * Intel Diamond Rapids (SOC)
>    * Intel Nova Lake (PCH)
> +  * Intel Lunar Lake (SOC)
>  
>     Datasheets: Publicly available at the Intel website
>  
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 275aaa7..83d3f14 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -168,6 +168,7 @@ config I2C_I801
>  	    Wildcat Lake (SOC)
>  	    Diamond Rapids (SOC)
>  	    Nova Lake (PCH)
> +	    Lunar Lake (SOC)
>  
>  	  This driver can also be built as a module.  If so, the module
>  	  will be called i2c-i801.
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 9d3cc70..63ac29c 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -86,6 +86,7 @@
>   * Wildcat Lake-U (SOC)		0x4d22	32	hard	yes	yes	yes
>   * Diamond Rapids (SOC)		0x5827	32	hard	yes	yes	yes
>   * Nova Lake-S (PCH)		0x6e23	32	hard	yes	yes	yes
> + * Lunar Lake-M (SOC)		0xa822	32	hard	yes	yes	yes
>   *
>   * Features supported by this driver:
>   * Software PEC				no
> @@ -269,6 +270,7 @@
>  #define PCI_DEVICE_ID_INTEL_KABYLAKE_PCH_H_SMBUS	0xa2a3
>  #define PCI_DEVICE_ID_INTEL_CANNONLAKE_H_SMBUS		0xa323
>  #define PCI_DEVICE_ID_INTEL_COMETLAKE_V_SMBUS		0xa3a3
> +#define PCI_DEVICE_ID_INTEL_LUNAR_LAKE_M_SMBUS		0xa822
>  #define PCI_DEVICE_ID_INTEL_METEOR_LAKE_SOC_S_SMBUS	0xae22
>  #define PCI_DEVICE_ID_INTEL_PANTHER_LAKE_H_SMBUS	0xe322
>  #define PCI_DEVICE_ID_INTEL_PANTHER_LAKE_P_SMBUS	0xe422
> @@ -1069,6 +1071,7 @@ static const struct pci_device_id i801_ids[] = {
>  	{ PCI_DEVICE_DATA(INTEL, PANTHER_LAKE_P_SMBUS,		FEATURES_ICH5 | FEATURE_TCO_CNL) },
>  	{ PCI_DEVICE_DATA(INTEL, WILDCAT_LAKE_U_SMBUS,		FEATURES_ICH5 | FEATURE_TCO_CNL) },
>  	{ PCI_DEVICE_DATA(INTEL, NOVA_LAKE_S_SMBUS,		FEATURES_ICH5 | FEATURE_TCO_CNL) },
> +	{ PCI_DEVICE_DATA(INTEL, LUNAR_LAKE_M_SMBUS,		FEATURES_ICH5 | FEATURE_TCO_CNL) },
>  	{ 0, }
>  };
>  
> -- 
> 2.56.1

-- 
heikki

      reply	other threads:[~2026-11-20 15:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  3:37 [PATCH] i2c: i801: Add support for Intel Lunar Lake-M NanamiKite
2026-11-20 15:03 ` Heikki Krogerus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awBhPXzSbfpJyCyJ@black.igk.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=jdelvare@suse.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nanami@yosoro.hk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox