The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: Thomas Gerner <thomas.gerner@muenchen-mail.de>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead
Date: Fri, 20 Nov 2026 15:34:30 -0800	[thread overview]
Message-ID: <awDZBiX1VoSkO6F3@x1> (raw)
In-Reply-To: <20261020132604.90708-3-thomas.gerner@muenchen-mail.de>

On Tue, Oct 20, 2026 at 03:26:04PM +0200, Thomas Gerner wrote:
> On the BeagleV-Ahead the bluetooth module of the Ampak AP6203BM is
> identified by the btbcm driver as BCM4362A2. The module is connected by
> UART4, several gpio pins and an I2S interface. The I2S is currently not
> used as there is currently no driver.
> 
> Signed-off-by: Thomas Gerner <thomas.gerner@muenchen-mail.de>
> ---
> Changes in v2:
> 	- use default pinctrl definition for bluetooth in and out pins

Thanks for sending v2. Sorry for the delay in review.

> 	
>  .../boot/dts/thead/th1520-beaglev-ahead.dts   | 85 +++++++++++++++++++
>  1 file changed, 85 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
> index e16484a47653..7161a9d4c61f 100644
> --- a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
> +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
> @@ -76,6 +76,23 @@ led-5 {
>  		};
>  	};
>  
> +	reg_vbat_1v8: regulator-vbat-1v8 {
> +		compatible = "regulator-fixed";
> +		regulator-boot-on;
> +		regulator-max-microvolt = <1800000>;
> +		regulator-min-microvolt = <1800000>;
> +		regulator-name = "vbat-1v8";
> +	};
> +
> +	reg_vbat_3v3: regulator-vbat-3v3 {
> +		compatible = "regulator-fixed";
> +		enable-active-high;

enable-active-high has no effect without a gpio.

> +		regulator-boot-on;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-min-microvolt = <3300000>;
> +		regulator-name = "vbat-3v3";
> +	};

Nothing can switch these two rails so regulator-always-on describes them
better than regulator-boot-on.

> +
>  	hdmi-connector {
>  		compatible = "hdmi-connector";
>  		type = "d";
> @@ -152,6 +169,28 @@ led-pins {
>  };
>  
>  &padctrl0_apsys {
> +	bluetooth_pins: bluetooth-0 {
> +		in-pins {
> +			bias-disable;
> +			drive-strength = <1>;
> +			function = "gpio";
> +			input-enable;
> +			input-schmitt-enable;
> +			pins = "GPIO2_30";
> +			slew-rate = <0>;
> +		};
> +
> +		out-pins {
> +			bias-disable;
> +			drive-strength = <3>;
> +			input-disable;
> +			input-schmitt-disable;
> +			pins = "SDIO1_DETN",	/* GPIO2_29 */
> +			       "SDIO1_WPRTN";	/* GPIO2_28 */
> +			slew-rate = <0>;
> +		};
> +	};
> +
>  	gmac0_pins: gmac0-0 {
>  		tx-pins {
>  			pins = "GMAC0_TX_CLK",
> @@ -268,6 +307,30 @@ reg-on-pins {
>  	};
>  };
>  
> +&padctrl1_apsys {
> +	uart4_pins: uart4-0 {
> +		rx-pins {
> +			bias-disable;
> +			drive-strength = <1>;
> +			function = "uart";
> +			input-enable;
> +			pins = "UART4_RXD", "UART4_CTSN";
> +			input-schmitt-enable;
> +			slew-rate = <0>;
> +		};
> +
> +		tx-pins {
> +			bias-disable;
> +			drive-strength = <3>;
> +			function = "uart";
> +			input-disable;
> +			pins = "UART4_TXD", "UART4_RTSN";
> +			input-schmitt-disable;
> +			slew-rate = <0>;
> +		};
> +	};
> +};
> +
>  &sdio0 {
>  	bus-width = <4>;
>  	max-frequency = <198000000>;
> @@ -314,3 +377,25 @@ &uart0 {
>  	pinctrl-0 = <&uart0_pins>;
>  	status = "okay";
>  };
> +
> +&uart4 {
> +	pinctrl-0 = <&uart4_pins>;
> +	pinctrl-names = "default";
> +	uart-has-rtscts;
> +
> +	status = "okay";
> +
> +	bluetooth {
> +		compatible = "brcm,bcm4329-bt";
> +		device-wakeup-gpios = <&gpio2 29 GPIO_ACTIVE_HIGH>;
> +		interrupt-parent = <&gpio2>;
> +		interrupts = <30 IRQ_TYPE_EDGE_RISING>;
> +		interrupt-names = "host-wakeup";
> +		max-speed = <921600>;
> +		pinctrl-0 = <&bluetooth_pins>;
> +		pinctrl-names = "default";
> +		shutdown-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>; 	/* BT-REG-ON */

This triggers checkpatch:

WARNING: please, no space before tabs
#230: FILE: arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts:397:
+^I^Ishutdown-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>; ^I/* BT-REG-ON */$

> +		vbat-supply = <&reg_vbat_3v3>;
> +		vddio-supply = <&reg_vbat_1v8>;
> +	};
> +};
> -- 
> 2.53.0
> 

Thanks,
Drew

      reply	other threads:[~2026-11-20 23:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 13:26 [PATCH v2 0/2] Enable bluetooth on BeagleV-Ahead Thomas Gerner
2026-10-20 13:26 ` [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead Thomas Gerner
2026-11-20 23:53   ` Drew Fustini
2026-10-20 13:26 ` [PATCH v2 2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead Thomas Gerner
2026-11-20 23:34   ` Drew Fustini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awDZBiX1VoSkO6F3@x1 \
    --to=fustini@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guoren@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=thomas.gerner@muenchen-mail.de \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox