The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	bhelgaas@google.com
Subject: Re: [PATCH 4/4] PCI/AER: Hide the "aer" sysfs directory on devices without AER
Date: Sun, 22 Nov 2026 18:56:48 +0100	[thread overview]
Message-ID: <awMs4CwlPT2vsDV2@wunner.de> (raw)
In-Reply-To: <20261121013125.GA934416@bhelgaas>

On Fri, Nov 20, 2026 at 07:31:25PM -0600, Bjorn Helgaas wrote:
> On Tue, Nov 10, 2026 at 03:56:14PM -0600, Yazen Ghannam wrote:
> > aer_attr_group is a named group, so sysfs creates an "aer" directory for
> > every PCI device. aer_attrs_are_visible() hides the attributes when the
> > device has no aer_info.
> > 
> > But this doesn't apply to the entire "aer" group. So devices without AER
> > end up having an empty "aer" directory.
> 
> This applies specifically to the ratelimit-related things in the "aer"
> directory, right?

Yes.

> If so I might amend this commit log to mention
> that, since Lukas's subsequent "PCI/AER: Enable baseline capability
> error reporting" enables aer_dev_correctable, aer_dev_fatal, etc even
> for non-AER PCIe devices.

With that subsequent patch, the "aer" subdirectory with the ratelimiting
knobs appears below every PCIe device (unless allocation of aer_info fails
due to high memory pressure), but not e.g. below Conventional PCI devices.

> At least they're internal so they're easier to change than
> "aer_dev_correctable" etc, which are even more unfortunate now.

Baseline capability error reporting depends on presence of an AER-capable
Root Port, hence is still in a sense AER-related.

Thanks,

Lukas

  reply	other threads:[~2026-11-22 17:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 21:56 [PATCH 0/4] AER sysfs fixes Yazen Ghannam
2026-11-10 21:56 ` [PATCH 1/4] MAINTAINERS: Add the AER sysfs ABI file to PCI SUBSYSTEM Yazen Ghannam
2026-11-10 21:56 ` [PATCH 2/4] PCI/AER: Clamp negative ratelimit burst to zero Yazen Ghannam
2026-11-20 18:10   ` Bjorn Helgaas
2026-11-20 21:13     ` Yazen Ghannam
2026-11-21  0:12       ` Bjorn Helgaas
2026-11-10 21:56 ` [PATCH 3/4] PCI/AER: Report the ratelimit interval in milliseconds Yazen Ghannam
2026-11-18 16:39   ` Sang-Heon Jeon
2026-11-10 21:56 ` [PATCH 4/4] PCI/AER: Hide the "aer" sysfs directory on devices without AER Yazen Ghannam
2026-11-21  1:31   ` Bjorn Helgaas
2026-11-22 17:56     ` Lukas Wunner [this message]
2026-11-19  0:02 ` [PATCH 0/4] AER sysfs fixes Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awMs4CwlPT2vsDV2@wunner.de \
    --to=lukas@wunner.de \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox