From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB200C61D97 for ; Thu, 23 Nov 2023 15:32:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346148AbjKWPb6 (ORCPT ); Thu, 23 Nov 2023 10:31:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346230AbjKWPbi (ORCPT ); Thu, 23 Nov 2023 10:31:38 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80DA010C8; Thu, 23 Nov 2023 07:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700753434; x=1732289434; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=wf42AL/tv0Fj/STvDq+UcPvgDOY05tysJaWbd/9145E=; b=Hqrjk+jiyfN8HamNPWp0k6xmrsveyLqNEM3lm/RDkms2oFbzQa5atP/D z94HbW6A+kVl93JOuL9o44bYWQhy6bFi6ypQCBpB59Q6DZwRdOexDmOdF bV2nIdbwGB57uCdAOh6EBJ9X/Xwv5Hkp5pi28F+QJjfaZXFJsG8UxfOxx adkHPmRfeak1Dj0bsccl7oMOevf6Vz2FrzeR0yLdJJEfwQAXm9MDEz6KY paJC6LZIh7hnRF/3lQo94M7IyTJLMh+FJwVA/DdmZJP+dzfNDnsPdi0pd EzXhi6BSjPbRVgHyyiPG7cnvuGq86FVYAZimpX4cm9JTlsXkMDdpfm7GL w==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="5431839" X-IronPort-AV: E=Sophos;i="6.04,222,1695711600"; d="scan'208";a="5431839" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2023 07:30:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,222,1695711600"; d="scan'208";a="15698967" Received: from mstrobel-mobl.ger.corp.intel.com ([10.252.40.70]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2023 07:30:26 -0800 Date: Thu, 23 Nov 2023 17:30:23 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: SungHwan Jung cc: Hans de Goede , "Lee, Chun-Yi" , Jean Delvare , Guenter Roeck , platform-driver-x86@vger.kernel.org, LKML , linux-hwmon@vger.kernel.org Subject: Re: [PATCH v3 2/2] platform/x86: acer-wmi: add fan speed monitoring for Predator PHN16-71 In-Reply-To: <20231123152229.4920-3-onenowy@gmail.com> Message-ID: References: <20231123152229.4920-1-onenowy@gmail.com> <20231123152229.4920-3-onenowy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Nov 2023, SungHwan Jung wrote: > Support CPU and GPU fan speed monitoring through WMI for Predator > PHN16-71. > > This patch depends on patch "platform/x86: acer-wmi: Add platform > profile and mode key support for Predator PHN16-71" > > "select ACPI_VIDEO" cause recursive dependency and it is not recommended > to use "select" for visible symbol, "select" has changed to "depends on". > > Signed-off-by: SungHwan Jung > --- > drivers/platform/x86/Kconfig | 3 +- > drivers/platform/x86/acer-wmi.c | 98 ++++++++++++++++++++++++++++++++- > 2 files changed, 99 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 7e69fdacc..33ddb644e 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -177,7 +177,8 @@ config ACER_WMI > depends on INPUT > depends on RFKILL || RFKILL = n > depends on ACPI_WMI > - select ACPI_VIDEO > + depends on HWMON > + depends on ACPI_VIDEO > select INPUT_SPARSEKMAP > select LEDS_CLASS > select NEW_LEDS > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c > index e3650dce0..f2f3b1c45 100644 > --- a/drivers/platform/x86/acer-wmi.c > +++ b/drivers/platform/x86/acer-wmi.c > static const struct key_entry acer_wmi_keymap[] __initconst = { > @@ -241,6 +244,7 @@ struct hotkey_function_type_aa { > #define ACER_CAP_TURBO_LED BIT(8) > #define ACER_CAP_TURBO_FAN BIT(9) > #define ACER_CAP_PLATFORM_PROFILE BIT(10) > +#define ACER_CAP_FAN_SPEED_READ BIT(11) It would be nice to align these with tabs. > @@ -1722,6 +1727,25 @@ static int acer_gsensor_event(void) > return 0; > } > > +static int acer_get_fan_speed(int fan) > +{ > + if (quirks->predator_v4) { > + acpi_status status; > + u64 fanspeed; > + > + status = WMI_gaming_execute_u64( > + ACER_WMID_GET_GAMING_SYS_INFO_METHODID, > + fan == 0 ? ACER_WMID_CMD_GET_PREDATOR_V4_CPU_FAN_SPEED : > + ACER_WMID_CMD_GET_PREDATOR_V4_GPU_FAN_SPEED, > + &fanspeed); > + > + if (ACPI_FAILURE(status)) > + return -EIO; > + return fanspeed >> 8; Define a named field using GENMASK() and use FIELD_GET() ? -- i.