public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Denis Benato <benato.denis96@gmail.com>
To: "Tim Wassink" <timwassink.dev@gmail.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Luke D. Jones" <luke@ljones.dev>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: asus-nb-wmi: add quirk_asus_ignore_fan for UX3405MA
Date: Mon, 22 Dec 2025 03:54:23 +0100	[thread overview]
Message-ID: <b02a7c96-9653-4ab2-ac4a-86d365af1a2d@gmail.com> (raw)
In-Reply-To: <20251221210218.12274-1-timwassink.dev@gmail.com>


On 12/21/25 22:01, Tim Wassink wrote:
> The ASUS Zenbook 14 (UX3405MA) uses a newer WMI interface for thermal
> management that does not support the legacy WMI fan control methods.
> Currently, this results in ENODEV (-19) errors in dmesg when the driver
> attempts to fetch factory fan curve defaults.
>
> Add a quirk to use quirk_asus_ignore_fan to silence these errors and
> signal that legacy fan control is intentionally unsupported, as thermal
> policies are handled through the platform_profile interface.
It is my understanding that this patch suppresses the error,
while maintaining the current behavior in every other aspect,
correct?
> Signed-off-by: Tim Wassink <timwassink.dev@gmail.com>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 6a62bc5b02fd..eaa8abe506cb 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -544,6 +544,15 @@ static const struct dmi_system_id asus_quirks[] = {
>  		},
>  		.driver_data = &quirk_asus_zenbook_duo_kbd,
>  	},
> +	{
> +		.callback = dmi_matched,
> +		.ident = "ASUS Zenbook 14 UX3405MA",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "UX3405MA"),
> +		},
> +		.driver_data = &quirk_asus_ignore_fan,
> +	},
>  	{
>  		.callback = dmi_matched,
>  		.ident = "ASUS ROG Z13",

  reply	other threads:[~2025-12-22  2:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-21 21:01 [PATCH] platform/x86: asus-nb-wmi: add quirk_asus_ignore_fan for UX3405MA Tim Wassink
2025-12-22  2:54 ` Denis Benato [this message]
2025-12-22 10:44   ` Tim Wassink
2025-12-23 13:50     ` Denis Benato
2025-12-24 23:43       ` Tim Wassink
2025-12-25 17:13         ` Denis Benato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b02a7c96-9653-4ab2-ac4a-86d365af1a2d@gmail.com \
    --to=benato.denis96@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=timwassink.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox