From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752809AbcIAJ2i (ORCPT ); Thu, 1 Sep 2016 05:28:38 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:27107 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751063AbcIAJ2f (ORCPT ); Thu, 1 Sep 2016 05:28:35 -0400 X-AuditID: cbfec7f5-f792e6d0000013f5-50-57c7f4c0789a Subject: Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards To: Javier Martinez Canillas References: <1472645679-5696-1-git-send-email-javier@osg.samsung.com> <1472645679-5696-2-git-send-email-javier@osg.samsung.com> <20160831174657.GA19969@kozik-lap> <0e8e0b3c-0dd9-c44b-d1ad-03c840d3a725@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland From: Krzysztof Kozlowski Message-id: Date: Thu, 01 Sep 2016 11:28:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <0e8e0b3c-0dd9-c44b-d1ad-03c840d3a725@osg.samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t/xq7oHvhwPN1h4jtti/pFzrBZv3q5h snj9wtCi//FrZovLu+awWcw4v4/JYun1i0wWrXuPsDtweKyZt4bRY9OqTjaPLf132T36tqxi 9Pi8SS6ANYrLJiU1J7MstUjfLoErY972eywFv3gqdjVNZ2lg3M3VxcjJISFgItEw6R0jhC0m ceHeejYQW0hgKaPE558lXYxcQPYzRomNOz8xgSSEBaIkTh1cxQxiiwiYSvxa+4IVougMk8Sz Y83MIA6zwEmgjombWboYOTjYBLQl/m0pBmngFbCVWHfuBFgzi4CqxM8pu8C2iQpESNxa9ZER okZQ4sfkeywgNqeAs8Spo3+ZQcYwC6hLTJmSCxJmFpCX2LzmLfMERoFZSDpmIVTNQlK1gJF5 FaNoamlyQXFSeq6RXnFibnFpXrpecn7uJkZIqH/dwbj0mNUhRgEORiUeXoc3x8KFWBPLiitz DzFKcDArifD+/nQ8XIg3JbGyKrUoP76oNCe1+BCjNAeLkjjvzF3vQ4QE0hNLUrNTUwtSi2Cy TBycUg2MHCouGztnqZVfOXHXKWUja2/89PTmFuu3V/2/P3S6Or2rs/WG+oEjvS+1Z3zj3Ne/ mmnC/Kkinzy2pAr6Tq6fq+YyNfhuzGcBTsUNRyRDnjbkXOA3MTTS2uwms/rSkj0tVxg3ZnF8 EKmSNnFx1DFTzajfK/Tj/ZVFW5LfHZCI8P1Qv2TRP95EJZbijERDLeai4kQARKDHa3ECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2016 11:19 AM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote: >> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote: >>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts >>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts >>>>> @@ -21,6 +21,11 @@ >>>>> bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200"; >>>>> }; >>>>> >>>>> + memory { >>>>> + device_type = "memory"; >>>>> + reg = <0 0>; >>>>> + }; >>>> >>>> This looks okay, but the default size and address cells won't be >>>> present. Won't that be a problem? >>>> >>> >>> They will be present since at this point exynos5440.dtsi is still including >>> exynos5440.dtsi, we are just overriding the memory node with the same values >>> than skeleton.dtsi so this can be removed later in patch 7/7. >> >> I don't get it. exynos5440.dtsi does not set size/address cells in top node. >> > > Sorry, maybe I'm misunderstanding your question. The size/address cells are set > in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are > set in that included dtsi). Where? Nothing in my sources... 15 / { 16 compatible = "samsung,exynos5440", "samsung,exynos5"; 17 18 interrupt-parent = <&gic>; > > IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB > before and after $SUBJECT. Maybe these are also the default values so no differences... stating them explicitly would be useful. Best regards, Krzysztof