From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Nathan Chancellor <nathan@kernel.org>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
patches@lists.linux.dev
Subject: Re: [PATCH -next] ASoC: Intel: sof_da7219_mx98360a: Access num_codecs through dai_link
Date: Thu, 22 Sep 2022 19:58:55 +0200 [thread overview]
Message-ID: <b0595977-7cf4-7261-d006-a43ce6b63e31@linux.intel.com> (raw)
In-Reply-To: <20220922153752.336193-1-nathan@kernel.org>
On 9/22/22 17:37, Nathan Chancellor wrote:
> After commit 3989ade2d1e7 ("ASoC: soc.h: remove num_cpus/codecs"), the
> following build error occurs:
>
> sound/soc/intel/boards/sof_da7219_max98373.c:198:27: error: no member named 'num_codecs' in 'struct snd_soc_pcm_runtime'
> for (j = 0; j < runtime->num_codecs; j++) {
> ~~~~~~~ ^
> 1 error generated.
>
> This conversion was missed by the aforementioned change. Do it now to
> fix the build error.
>
> Fixes: 3989ade2d1e7 ("ASoC: soc.h: remove num_cpus/codecs")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/intel/boards/sof_da7219_max98373.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/sof_da7219_max98373.c b/sound/soc/intel/boards/sof_da7219_max98373.c
> index 34cf849a8344..e048e789e633 100644
> --- a/sound/soc/intel/boards/sof_da7219_max98373.c
> +++ b/sound/soc/intel/boards/sof_da7219_max98373.c
> @@ -195,7 +195,7 @@ static int ssp1_hw_params(struct snd_pcm_substream *substream,
> struct snd_soc_pcm_runtime *runtime = asoc_substream_to_rtd(substream);
> int ret, j;
>
> - for (j = 0; j < runtime->num_codecs; j++) {
> + for (j = 0; j < runtime->dai_link->num_codecs; j++) {
> struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(runtime, j);
>
> if (!strcmp(codec_dai->component->name, MAXIM_DEV0_NAME)) {
>
> base-commit: a921986f445ad611b441c8ee7749dc6dfc770481
next prev parent reply other threads:[~2022-09-22 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 15:37 [PATCH -next] ASoC: Intel: sof_da7219_mx98360a: Access num_codecs through dai_link Nathan Chancellor
2022-09-22 17:58 ` Pierre-Louis Bossart [this message]
2022-09-23 17:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0595977-7cf4-7261-d006-a43ce6b63e31@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox